From 81c0f29ad962733b0750bdab2d3250e2c796a578 Mon Sep 17 00:00:00 2001
From: GitLab Bot
Date: Fri, 8 Apr 2022 21:09:52 +0000
Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master
---
.../components/service_ping_disabled.vue | 2 +-
.../components/board_filtered_search.vue | 30 ++-
.../javascripts/ide/components/jobs/stage.vue | 2 +-
.../javascripts/ide/stores/actions/project.js | 2 +-
.../approve_access_request_button.vue | 2 +-
.../pages/projects/network/network.js | 2 +-
.../javascripts/pages/sessions/new/index.js | 2 +-
.../pages/sessions/new/length_validator.js | 2 +-
.../javascripts/pages/shared/wikis/edit.js | 4 +-
.../jobs_shared/job_name_component.vue | 2 +-
.../components/states/mr_widget_merging.vue | 2 +-
.../vue_shared/components/markdown/header.vue | 2 +-
.../user_avatar/user_avatar_image_new.vue | 2 +-
.../user_avatar/user_avatar_image_old.vue | 2 +-
.../components/user_popover/user_popover.vue | 2 +-
.../enforces_two_factor_authentication.rb | 11 +-
app/controllers/groups/boards_controller.rb | 3 +-
app/controllers/groups_controller.rb | 1 -
app/controllers/projects/boards_controller.rb | 3 +-
app/controllers/projects/issues_controller.rb | 1 -
app/graphql/mutations/ci/pipeline/cancel.rb | 2 +
app/graphql/mutations/notes/update/note.rb | 3 +-
app/models/group.rb | 16 +-
.../ci_cd/_auto_devops_form.html.haml | 18 +-
.../development/iteration_cadences.yml | 8 -
...6175548_ci_pipeline_config_auto_devops.yml | 2 +-
...deprecate-toggle-notes-confidentiality.yml | 9 +
doc/api/graphql/reference/index.md | 2 +-
doc/api/notes.md | 55 +++--
.../avoiding_downtime_in_migrations.md | 11 +
doc/development/background_migrations.md | 11 +
doc/development/code_review.md | 2 +
doc/development/deleting_migrations.md | 11 +
doc/development/post_deployment_migrations.md | 11 +
doc/development/workhorse/channel.md | 228 +++++++++---------
doc/development/workhorse/configuration.md | 129 +++++-----
doc/development/workhorse/gitlab_features.md | 2 +-
doc/development/workhorse/new_features.md | 76 ++++--
doc/raketasks/backup_restore.md | 2 +-
doc/update/deprecations.md | 12 +
doc/user/discussions/index.md | 23 +-
lib/api/notes.rb | 2 +-
lib/backup/artifacts.rb | 14 --
lib/backup/builds.rb | 14 --
lib/backup/database.rb | 5 -
lib/backup/files.rb | 13 +-
lib/backup/lfs.rb | 14 --
lib/backup/manager.rb | 162 ++++++++-----
lib/backup/packages.rb | 14 --
lib/backup/pages.rb | 18 --
lib/backup/registry.rb | 19 --
lib/backup/repositories.rb | 5 -
lib/backup/task.rb | 10 -
lib/backup/terraform_state.rb | 14 --
lib/backup/uploads.rb | 14 --
.../Security/API-Fuzzing.latest.gitlab-ci.yml | 27 ++-
.../Security/DAST-API.latest.gitlab-ci.yml | 9 +-
lib/gitlab/graphql/deprecation.rb | 2 +-
locale/gitlab.pot | 6 +
rubocop/cop/gitlab/mark_used_feature_flags.rb | 1 +
spec/controllers/graphql_controller_spec.rb | 7 +-
.../components/board_filtered_search_spec.js | 4 +-
.../profile/add_ssh_key_validation_spec.js | 2 +-
.../user_lists/store/edit/actions_spec.js | 2 +-
.../user_lists/store/edit/mutations_spec.js | 2 +-
.../user_lists/store/index/actions_spec.js | 2 +-
.../user_lists/store/index/mutations_spec.js | 2 +-
.../user_lists/store/new/actions_spec.js | 2 +-
.../extensions/test_report/index_spec.js | 12 +-
.../components/notes/placeholder_note_spec.js | 2 +-
spec/lib/backup/artifacts_spec.rb | 24 --
spec/lib/backup/files_spec.rb | 14 +-
spec/lib/backup/lfs_spec.rb | 26 --
spec/lib/backup/manager_spec.rb | 24 +-
spec/lib/backup/object_backup_spec.rb | 35 ---
spec/lib/backup/pages_spec.rb | 25 --
spec/lib/backup/task_spec.rb | 6 -
spec/lib/backup/uploads_spec.rb | 25 --
spec/models/group_spec.rb | 41 +---
.../mutations/ci/pipeline_cancel_spec.rb | 1 +
...tlab_style_deprecations_shared_examples.rb | 6 +-
.../models/group_shared_examples.rb | 43 ++++
spec/tasks/gitlab/backup_rake_spec.rb | 18 +-
83 files changed, 676 insertions(+), 724 deletions(-)
delete mode 100644 config/feature_flags/development/iteration_cadences.yml
create mode 100644 data/deprecations/14-10-deprecate-toggle-notes-confidentiality.yml
create mode 100644 doc/development/avoiding_downtime_in_migrations.md
create mode 100644 doc/development/background_migrations.md
create mode 100644 doc/development/deleting_migrations.md
create mode 100644 doc/development/post_deployment_migrations.md
delete mode 100644 lib/backup/artifacts.rb
delete mode 100644 lib/backup/builds.rb
delete mode 100644 lib/backup/lfs.rb
delete mode 100644 lib/backup/packages.rb
delete mode 100644 lib/backup/pages.rb
delete mode 100644 lib/backup/registry.rb
delete mode 100644 lib/backup/terraform_state.rb
delete mode 100644 lib/backup/uploads.rb
delete mode 100644 spec/lib/backup/artifacts_spec.rb
delete mode 100644 spec/lib/backup/lfs_spec.rb
delete mode 100644 spec/lib/backup/object_backup_spec.rb
delete mode 100644 spec/lib/backup/pages_spec.rb
delete mode 100644 spec/lib/backup/uploads_spec.rb
create mode 100644 spec/support/shared_examples/models/group_shared_examples.rb
diff --git a/app/assets/javascripts/analytics/devops_reports/components/service_ping_disabled.vue b/app/assets/javascripts/analytics/devops_reports/components/service_ping_disabled.vue
index 400326e41e1..b9501107e37 100644
--- a/app/assets/javascripts/analytics/devops_reports/components/service_ping_disabled.vue
+++ b/app/assets/javascripts/analytics/devops_reports/components/service_ping_disabled.vue
@@ -43,7 +43,7 @@ export default {
{{ s__('ServicePing|Turn on service ping to review instance-level analytics.') }}
-
+
{{ s__('ServicePing|Turn on service ping') }}
diff --git a/app/assets/javascripts/boards/components/board_filtered_search.vue b/app/assets/javascripts/boards/components/board_filtered_search.vue
index 95d4fd5bc0a..aeb2cee590d 100644
--- a/app/assets/javascripts/boards/components/board_filtered_search.vue
+++ b/app/assets/javascripts/boards/components/board_filtered_search.vue
@@ -4,7 +4,10 @@ import { mapActions } from 'vuex';
import { getIdFromGraphQLId, isGid } from '~/graphql_shared/utils';
import { updateHistory, setUrlParams } from '~/lib/utils/url_utility';
import { __ } from '~/locale';
-import { FILTERED_SEARCH_TERM } from '~/vue_shared/components/filtered_search_bar/constants';
+import {
+ FILTERED_SEARCH_TERM,
+ FILTER_ANY,
+} from '~/vue_shared/components/filtered_search_bar/constants';
import FilteredSearch from '~/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue';
import { AssigneeFilterType } from '~/boards/constants';
@@ -42,6 +45,7 @@ export default {
search,
milestoneTitle,
iterationId,
+ iterationCadenceId,
types,
weight,
epicId,
@@ -95,10 +99,20 @@ export default {
});
}
- if (iterationId) {
+ let iterationData = null;
+
+ if (iterationId && iterationCadenceId) {
+ iterationData = `${iterationId}&${iterationCadenceId}`;
+ } else if (iterationCadenceId) {
+ iterationData = `${FILTER_ANY}&${iterationCadenceId}`;
+ } else if (iterationId) {
+ iterationData = iterationId;
+ }
+
+ if (iterationData) {
filteredSearchValue.push({
type: 'iteration',
- value: { data: iterationId, operator: '=' },
+ value: { data: iterationData, operator: '=' },
});
}
@@ -228,9 +242,12 @@ export default {
epicId,
myReactionEmoji,
iterationId,
+ iterationCadenceId,
releaseTag,
confidential,
} = this.filterParams;
+ let iteration = iterationId;
+ let cadence = iterationCadenceId;
let notParams = {};
if (Object.prototype.hasOwnProperty.call(this.filterParams, 'not')) {
@@ -251,6 +268,10 @@ export default {
);
}
+ if (iterationId?.includes('&')) {
+ [iteration, cadence] = iterationId.split('&');
+ }
+
return mapValues(
{
...notParams,
@@ -259,7 +280,8 @@ export default {
assignee_username: assigneeUsername,
assignee_id: assigneeId,
milestone_title: milestoneTitle,
- iteration_id: iterationId,
+ iteration_id: iteration,
+ iteration_cadence_id: cadence,
search,
types,
weight,
diff --git a/app/assets/javascripts/ide/components/jobs/stage.vue b/app/assets/javascripts/ide/components/jobs/stage.vue
index 796ca1349c5..7797850f097 100644
--- a/app/assets/javascripts/ide/components/jobs/stage.vue
+++ b/app/assets/javascripts/ide/components/jobs/stage.vue
@@ -1,6 +1,6 @@