kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix Admin area user access level radio button labels 

In the admin user edit form, access level radio button labels didn't have
the correct 'for' value. Clicking on the label did not select the radio
button. This makes usability a bit nicer since the click area is increased
when the label is clickable.
This commit is contained in:
Drew Blessing 2019-07-25 10:51:48 -05:00
parent 029381b1d9
commit 81f44275bd
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/admin/users/_access_levels.html.haml
View File

@ -19,7 +19,7 @@
- editing_current_user = (current_user == @user)
= f.radio_button :access_level, :regular, disabled: editing_current_user
= label_tag :regular, class: 'font-weight-bold' do
= f.label :access_level_regular, class: 'font-weight-bold' do
Regular
%p.light
Regular users have access to their groups and projects
@ -27,7 +27,7 @@
= render_if_exists 'admin/users/auditor_access_level_radio', f: f, disabled: editing_current_user
= f.radio_button :access_level, :admin, disabled: editing_current_user
= label_tag :admin, class: 'font-weight-bold' do
= f.label :access_level_admin, class: 'font-weight-bold' do
Admin
%p.light
Administrators have access to all groups, projects and users and can manage all features in this installation

5
changelogs/unreleased/dblessing-fix-admin-user-radio-labels.yml Normal file
View File

@ -0,0 +1,5 @@
---
title: Fix admin area user access level radio button labels
merge_request: 31154
author:
type: fixed