From 8280fa786e71c14d39b1ae80e93f251f3685286a Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 6 Jul 2022 18:08:29 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITALY_SERVER_VERSION | 2 +- app/assets/javascripts/jobs/bridge/app.vue | 118 -------------- .../jobs/bridge/components/constants.js | 1 - .../jobs/bridge/components/empty_state.vue | 45 ------ .../jobs/bridge/components/sidebar.vue | 105 ------------- .../graphql/queries/pipeline.query.graphql | 70 --------- app/assets/javascripts/jobs/index.js | 41 +---- .../pipelines/charts/components/app.vue | 15 +- .../surveys/merge_request_experience/app.vue | 6 +- .../stylesheets/pages/merge_requests.scss | 7 + app/controllers/projects/jobs_controller.rb | 4 - app/finders/issuable_finder.rb | 2 +- app/helpers/emails_helper.rb | 94 +++++++++-- app/models/concerns/milestoneable.rb | 2 +- app/models/merge_request_diff_file.rb | 33 ++-- .../terraform/module_version_presenter.rb | 50 ++++++ .../admin/application_settings/_eks.html.haml | 2 +- ...ernal_authorization_service_form.html.haml | 2 +- .../application_settings/_floc.html.haml | 2 +- .../application_settings/_gitpod.html.haml | 2 +- .../_jira_connect_application_key.html.haml | 2 +- .../application_settings/_kroki.html.haml | 2 +- .../application_settings/_mailgun.html.haml | 2 +- .../application_settings/_plantuml.html.haml | 2 +- .../application_settings/_snowplow.html.haml | 2 +- .../_sourcegraph.html.haml | 2 +- .../_third_party_offers.html.haml | 2 +- .../application_settings/general.html.haml | 16 +- app/views/layouts/mailer.html.haml | 4 +- app/views/layouts/mailer.text.erb | 2 +- app/views/layouts/notify.html.haml | 11 +- app/views/layouts/notify.text.erb | 2 +- .../approved_merge_request_email.html.haml | 4 +- ...rge_when_pipeline_succeeds_email.html.haml | 4 +- .../unapproved_merge_request_email.html.haml | 4 +- app/views/projects/jobs/show.html.haml | 5 +- app/views/pwa/offline.html.haml | 2 +- .../ci_docker_image_pull_policy.yml | 2 +- .../development/trigger_job_retry_action.yml | 8 - db/docs/namespace_bans.yml | 9 ++ .../20220628120708_create_namespace_bans.rb | 15 ++ ...namespace_bans_namespace_id_foreign_key.rb | 15 ++ ..._add_namespace_bans_user_id_foreign_key.rb | 15 ++ ...0629220129_increase_webauthn_xid_length.rb | 17 ++ ...d_indices_on_security_scans_info_column.rb | 27 ++++ db/schema_migrations/20220628120708 | 1 + db/schema_migrations/20220628121644 | 1 + db/schema_migrations/20220628121712 | 1 + db/schema_migrations/20220629220129 | 1 + db/schema_migrations/20220706132238 | 1 + db/structure.sql | 38 ++++- .../monitoring/prometheus/gitlab_metrics.md | 1 + doc/ci/yaml/index.md | 6 +- doc/development/integrations/secure.md | 35 +++++ doc/user/analytics/ci_cd_analytics.md | 16 +- .../project/integrations/webhook_events.md | 22 ++- lib/api/entities/terraform/module_version.rb | 18 +++ lib/api/terraform/modules/v1/packages.rb | 10 ++ lib/api/usage_data.rb | 2 +- lib/gitlab/data_builder/issuable.rb | 2 +- lib/gitlab/database/gitlab_schemas.yml | 1 + lib/gitlab/hook_data/merge_request_builder.rb | 3 +- .../import_export/project/import_export.yml | 2 +- lib/gitlab/metrics/memory.rb | 15 ++ lib/gitlab/metrics/samplers/ruby_sampler.rb | 12 +- lib/unnested_in_filters/rewriter.rb | 6 + locale/gitlab.pot | 41 +++-- metrics_server/dependencies.rb | 1 + .../page/group/settings/package_registries.rb | 6 +- spec/features/unsubscribe_links_spec.rb | 2 +- .../terraform/modules/v1/single_version.json | 55 +++++++ spec/frontend/jobs/bridge/app_spec.js | 146 ------------------ .../bridge/components/empty_state_spec.js | 58 ------- .../jobs/bridge/components/sidebar_spec.js | 99 ------------ spec/frontend/jobs/bridge/mock_data.js | 102 ------------ .../pipelines/charts/components/app_spec.js | 85 +++++----- spec/helpers/emails_helper_spec.rb | 2 +- .../hook_data/merge_request_builder_spec.rb | 52 ++++--- spec/lib/gitlab/metrics/memory_spec.rb | 40 +++++ .../metrics/samplers/ruby_sampler_spec.rb | 6 + spec/lib/unnested_in_filters/rewriter_spec.rb | 15 ++ .../mailers/emails/admin_notification_spec.rb | 2 +- spec/mailers/emails/profile_spec.rb | 8 +- spec/mailers/notify_spec.rb | 9 +- spec/models/merge_request_diff_file_spec.rb | 49 +++--- .../api/terraform/modules/v1/packages_spec.rb | 69 +++++++++ .../finders/issues_finder_shared_examples.rb | 11 ++ .../modules/v1/packages_shared_examples.rb | 16 ++ .../commits/_commit.html.haml_spec.rb | 2 +- .../projects/jobs/show.html.haml_spec.rb | 15 -- workhorse/go.mod | 4 +- workhorse/go.sum | 10 +- 92 files changed, 850 insertions(+), 1028 deletions(-) delete mode 100644 app/assets/javascripts/jobs/bridge/app.vue delete mode 100644 app/assets/javascripts/jobs/bridge/components/constants.js delete mode 100644 app/assets/javascripts/jobs/bridge/components/empty_state.vue delete mode 100644 app/assets/javascripts/jobs/bridge/components/sidebar.vue delete mode 100644 app/assets/javascripts/jobs/bridge/graphql/queries/pipeline.query.graphql create mode 100644 app/presenters/terraform/module_version_presenter.rb delete mode 100644 config/feature_flags/development/trigger_job_retry_action.yml create mode 100644 db/docs/namespace_bans.yml create mode 100644 db/migrate/20220628120708_create_namespace_bans.rb create mode 100644 db/migrate/20220628121644_add_namespace_bans_namespace_id_foreign_key.rb create mode 100644 db/migrate/20220628121712_add_namespace_bans_user_id_foreign_key.rb create mode 100644 db/migrate/20220629220129_increase_webauthn_xid_length.rb create mode 100644 db/post_migrate/20220706132238_add_indices_on_security_scans_info_column.rb create mode 100644 db/schema_migrations/20220628120708 create mode 100644 db/schema_migrations/20220628121644 create mode 100644 db/schema_migrations/20220628121712 create mode 100644 db/schema_migrations/20220629220129 create mode 100644 db/schema_migrations/20220706132238 create mode 100644 lib/api/entities/terraform/module_version.rb create mode 100644 lib/gitlab/metrics/memory.rb create mode 100644 spec/fixtures/api/schemas/public_api/v4/packages/terraform/modules/v1/single_version.json delete mode 100644 spec/frontend/jobs/bridge/app_spec.js delete mode 100644 spec/frontend/jobs/bridge/components/empty_state_spec.js delete mode 100644 spec/frontend/jobs/bridge/components/sidebar_spec.js delete mode 100644 spec/frontend/jobs/bridge/mock_data.js create mode 100644 spec/lib/gitlab/metrics/memory_spec.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 0fa805d2ff5..4008a63e5c9 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -ac72695adc90343b7255869818376f505bde8315 +6944c95243e2b6ed8f783ae903cb9b03ad50e0f9 diff --git a/app/assets/javascripts/jobs/bridge/app.vue b/app/assets/javascripts/jobs/bridge/app.vue deleted file mode 100644 index c639e49083b..00000000000 --- a/app/assets/javascripts/jobs/bridge/app.vue +++ /dev/null @@ -1,118 +0,0 @@ - - diff --git a/app/assets/javascripts/jobs/bridge/components/constants.js b/app/assets/javascripts/jobs/bridge/components/constants.js deleted file mode 100644 index 33310b3157a..00000000000 --- a/app/assets/javascripts/jobs/bridge/components/constants.js +++ /dev/null @@ -1 +0,0 @@ -export const SIDEBAR_COLLAPSE_BREAKPOINTS = ['xs', 'sm']; diff --git a/app/assets/javascripts/jobs/bridge/components/empty_state.vue b/app/assets/javascripts/jobs/bridge/components/empty_state.vue deleted file mode 100644 index bd07d863719..00000000000 --- a/app/assets/javascripts/jobs/bridge/components/empty_state.vue +++ /dev/null @@ -1,45 +0,0 @@ - - - diff --git a/app/assets/javascripts/jobs/bridge/components/sidebar.vue b/app/assets/javascripts/jobs/bridge/components/sidebar.vue deleted file mode 100644 index 3ba07cf55d1..00000000000 --- a/app/assets/javascripts/jobs/bridge/components/sidebar.vue +++ /dev/null @@ -1,105 +0,0 @@ - - diff --git a/app/assets/javascripts/jobs/bridge/graphql/queries/pipeline.query.graphql b/app/assets/javascripts/jobs/bridge/graphql/queries/pipeline.query.graphql deleted file mode 100644 index 338ca9f16c7..00000000000 --- a/app/assets/javascripts/jobs/bridge/graphql/queries/pipeline.query.graphql +++ /dev/null @@ -1,70 +0,0 @@ -query getPipelineData($fullPath: ID!, $iid: ID!) { - project(fullPath: $fullPath) { - id - pipeline(iid: $iid) { - id - iid - path - sha - ref - refPath - commit { - id - shortId - title - webPath - } - detailedStatus { - id - icon - group - } - stages { - edges { - node { - id - name - jobs { - nodes { - id - createdAt - name - scheduledAt - startedAt - status - triggered - detailedStatus { - id - detailsPath - icon - group - text - tooltip - } - downstreamPipeline { - id - path - } - stage { - id - name - } - } - } - } - } - } - user { - id - avatarUrl - name - username - webPath - webUrl - status { - message - } - } - } - } -} diff --git a/app/assets/javascripts/jobs/index.js b/app/assets/javascripts/jobs/index.js index 26dd38bbe08..8fb4c480ef9 100644 --- a/app/assets/javascripts/jobs/index.js +++ b/app/assets/javascripts/jobs/index.js @@ -1,7 +1,4 @@ import Vue from 'vue'; -import VueApollo from 'vue-apollo'; -import createDefaultClient from '~/lib/graphql'; -import BridgeApp from './bridge/app.vue'; import JobApp from './components/job_app.vue'; import createStore from './store'; @@ -51,43 +48,7 @@ const initializeJobPage = (element) => { }); }; -const initializeBridgePage = (el) => { - const { - buildId, - downstreamPipelinePath, - emptyStateIllustrationPath, - pipelineIid, - projectFullPath, - } = el.dataset; - - Vue.use(VueApollo); - const apolloProvider = new VueApollo({ - defaultClient: createDefaultClient(), - }); - - return new Vue({ - el, - apolloProvider, - provide: { - buildId, - downstreamPipelinePath, - emptyStateIllustrationPath, - pipelineIid, - projectFullPath, - }, - render(h) { - return h(BridgeApp); - }, - }); -}; - export default () => { const jobElement = document.getElementById('js-job-page'); - const bridgeElement = document.getElementById('js-bridge-page'); - - if (jobElement) { - initializeJobPage(jobElement); - } else { - initializeBridgePage(bridgeElement); - } + initializeJobPage(jobElement); }; diff --git a/app/assets/javascripts/projects/pipelines/charts/components/app.vue b/app/assets/javascripts/projects/pipelines/charts/components/app.vue index 35e7554aee2..016301368af 100644 --- a/app/assets/javascripts/projects/pipelines/charts/components/app.vue +++ b/app/assets/javascripts/projects/pipelines/charts/components/app.vue @@ -14,6 +14,8 @@ export default { LeadTimeCharts: () => import('ee_component/dora/components/lead_time_charts.vue'), TimeToRestoreServiceCharts: () => import('ee_component/dora/components/time_to_restore_service_charts.vue'), + ChangeFailureRateCharts: () => + import('ee_component/dora/components/change_failure_rate_charts.vue'), ProjectQualitySummary: () => import('ee_component/project_quality_summary/app.vue'), }, piplelinesTabEvent: 'p_analytics_ci_cd_pipelines', @@ -40,7 +42,12 @@ export default { const chartsToShow = ['pipelines']; if (this.shouldRenderDoraCharts) { - chartsToShow.push('deployment-frequency', 'lead-time', 'time-to-restore-service'); + chartsToShow.push( + 'deployment-frequency', + 'lead-time', + 'time-to-restore-service', + 'change-failure-rate', + ); } if (this.shouldRenderQualitySummary) { @@ -105,6 +112,12 @@ export default { > + + + diff --git a/app/assets/javascripts/surveys/merge_request_experience/app.vue b/app/assets/javascripts/surveys/merge_request_experience/app.vue index 5b1d9be9563..85eed6ae82a 100644 --- a/app/assets/javascripts/surveys/merge_request_experience/app.vue +++ b/app/assets/javascripts/surveys/merge_request_experience/app.vue @@ -1,5 +1,5 @@