Avoid race condition in build retry service

2017-02-14 13:51:12 +01:00 · 2017-02-14 13:51:12 +01:00 · 82e6efb809
commit 82e6efb809
parent 108d3765ab
1 changed files with 2 additions and 3 deletions
--- a/app/services/ci/retry_build_service.rb
+++ b/app/services/ci/retry_build_service.rb
@ -2,14 +2,13 @@ module Ci
  class RetryBuildService < ::BaseService
    def execute(build)
      reprocess(build).tap do |new_build|
+        build.pipeline.mark_as_processable_after_stage(build.stage_idx)
+
        new_build.enqueue!

        MergeRequests::AddTodoWhenBuildFailsService
          .new(build.project, current_user)
          .close(new_build)
-
-        build.pipeline
-          .mark_as_processable_after_stage(build.stage_idx)
      end
    end