Apply changes recomended by merge request coach
This commit is contained in:
parent
341bead035
commit
832f668f29
|
@ -416,6 +416,10 @@ class Group < Namespace
|
||||||
super || ::Gitlab::CurrentSettings.default_project_creation
|
super || ::Gitlab::CurrentSettings.default_project_creation
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def subgroup_creation_level
|
||||||
|
super || ::Gitlab::Access::MAINTAINER_SUBGROUP_ACCESS
|
||||||
|
end
|
||||||
|
|
||||||
private
|
private
|
||||||
|
|
||||||
def update_two_factor_requirement
|
def update_two_factor_requirement
|
||||||
|
|
|
@ -70,8 +70,6 @@ describe Admin::GroupsController do
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'updates the subgroup_creation_level successfully' do
|
it 'updates the subgroup_creation_level successfully' do
|
||||||
OWNER = ::Gitlab::Access::OWNER_SUBGROUP_ACCESS
|
|
||||||
|
|
||||||
expect do
|
expect do
|
||||||
post :update,
|
post :update,
|
||||||
params: { id: group.to_param,
|
params: { id: group.to_param,
|
||||||
|
|
|
@ -1,4 +1,3 @@
|
||||||
# coding: utf-8
|
|
||||||
# frozen_string_literal: true
|
# frozen_string_literal: true
|
||||||
|
|
||||||
require 'spec_helper'
|
require 'spec_helper'
|
||||||
|
@ -88,14 +87,6 @@ describe Groups::CreateService, '#execute' do
|
||||||
|
|
||||||
it { is_expected.to be_persisted }
|
it { is_expected.to be_persisted }
|
||||||
end
|
end
|
||||||
|
|
||||||
context 'as maintainer' do
|
|
||||||
before do
|
|
||||||
group.add_maintainer(user)
|
|
||||||
end
|
|
||||||
|
|
||||||
it { is_expected.to be_persisted }
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue