Simplify copy on "Create a new list" dropdown in Issue Boards

This commit is contained in:
vrod 2016-11-19 15:58:31 -02:00
parent 7100b76923
commit 8434a642f1
9 changed files with 19 additions and 17 deletions

View file

@ -243,7 +243,7 @@
}
.issue-boards-search {
width: 335px;
width: 290px;
.form-control {
display: inline-block;

View file

@ -40,9 +40,9 @@
- if can?(current_user, :admin_list, @project)
.dropdown.pull-right
%button.btn.btn-create.js-new-board-list{ type: "button", data: { toggle: "dropdown", labels: labels_filter_path, namespace_path: @project.try(:namespace).try(:path), project_path: @project.try(:path) } }
Create new list
Add list
.dropdown-menu.dropdown-menu-paging.dropdown-menu-align-right.dropdown-menu-issues-board-new.dropdown-menu-selectable
= render partial: "shared/issuable/label_page_default", locals: { show_footer: true, show_create: true, show_boards_content: true, title: "Create a new list" }
= render partial: "shared/issuable/label_page_default", locals: { show_footer: true, show_create: true, show_boards_content: true, title: "Add list" }
- if can?(current_user, :admin_label, @project)
= render partial: "shared/issuable/label_page_create"
= dropdown_loading

View file

@ -1,17 +1,15 @@
- title = local_assigns.fetch(:title, 'Assign labels')
- show_create = local_assigns.fetch(:show_create, true)
- show_footer = local_assigns.fetch(:show_footer, true)
- filter_placeholder = local_assigns.fetch(:filter_placeholder, 'Search labels')
- filter_placeholder = local_assigns.fetch(:filter_placeholder, 'Search')
- show_boards_content = local_assigns.fetch(:show_boards_content, false)
.dropdown-page-one
= dropdown_title(title)
- if show_boards_content
.issue-board-dropdown-content
%p
Each label that exists in your issue tracker can have its own dedicated
list. Select a label below to add a list to your Board and it will
automatically be populated with issues that have that label. To create
a list for a label that doesn't exist yet, simply create the label below.
Create lists from the labels you use in your project. Issues with that
label will automatically be added to the list.
= dropdown_filter(filter_placeholder)
= dropdown_content
- if @project && show_footer

View file

@ -0,0 +1,4 @@
---
title: Simplify copy on "Create a new list" dropdown in Issue Boards
merge_request: 7605
author: Victor Rodrigues

Binary file not shown.

Before

Width:  |  Height:  |  Size: 80 KiB

After

Width:  |  Height:  |  Size: 88 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 9.3 KiB

After

Width:  |  Height:  |  Size: 23 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 29 KiB

After

Width:  |  Height:  |  Size: 95 KiB

View file

@ -72,7 +72,7 @@ the list will be created and filled with the issues that have that label.
## Creating a new list
Create a new list by clicking on the **Create new list** button at the upper
Create a new list by clicking on the **Add list** button at the upper
right corner of the Issue Board.
![Issue Board welcome message](img/issue_board_add_list.png)

View file

@ -158,7 +158,7 @@ describe 'Issue Boards', feature: true, js: true do
end
it 'removes checkmark in new list dropdown after deleting' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within(find('.board:nth-child(2)')) do
@ -304,7 +304,7 @@ describe 'Issue Boards', feature: true, js: true do
context 'new list' do
it 'shows all labels in new list dropdown' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within('.dropdown-menu-issues-board-new') do
@ -315,7 +315,7 @@ describe 'Issue Boards', feature: true, js: true do
end
it 'creates new list for label' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within('.dropdown-menu-issues-board-new') do
@ -328,7 +328,7 @@ describe 'Issue Boards', feature: true, js: true do
end
it 'creates new list for Backlog label' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within('.dropdown-menu-issues-board-new') do
@ -341,7 +341,7 @@ describe 'Issue Boards', feature: true, js: true do
end
it 'creates new list for Done label' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within('.dropdown-menu-issues-board-new') do
@ -354,7 +354,7 @@ describe 'Issue Boards', feature: true, js: true do
end
it 'keeps dropdown open after adding new list' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within('.dropdown-menu-issues-board-new') do
@ -369,7 +369,7 @@ describe 'Issue Boards', feature: true, js: true do
it 'moves issues from backlog into new list' do
wait_for_board_cards(1, 6)
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax
page.within('.dropdown-menu-issues-board-new') do
@ -382,7 +382,7 @@ describe 'Issue Boards', feature: true, js: true do
end
it 'creates new list from a new label' do
click_button 'Create new list'
click_button 'Add list'
wait_for_ajax