Improve system notes for Zoom links
changes: @user a Zoom call was added to this issue into: @user added a Zoom call to this issue Same concept appleis for "removed"
This commit is contained in:
parent
61635309b8
commit
8463b21982
|
@ -598,11 +598,11 @@ module SystemNoteService
|
|||
end
|
||||
|
||||
def zoom_link_added(issue, project, author)
|
||||
create_note(NoteSummary.new(issue, project, author, _('a Zoom call was added to this issue'), action: 'pinned_embed'))
|
||||
create_note(NoteSummary.new(issue, project, author, _('added a Zoom call to this issue'), action: 'pinned_embed'))
|
||||
end
|
||||
|
||||
def zoom_link_removed(issue, project, author)
|
||||
create_note(NoteSummary.new(issue, project, author, _('a Zoom call was removed from this issue'), action: 'pinned_embed'))
|
||||
create_note(NoteSummary.new(issue, project, author, _('removed a Zoom call from this issue'), action: 'pinned_embed'))
|
||||
end
|
||||
|
||||
private
|
||||
|
|
|
@ -0,0 +1,5 @@
|
|||
---
|
||||
title: Improve system notes for Zoom links
|
||||
merge_request: 31410
|
||||
author: Jacopo Beschi @jacopo-beschi
|
||||
type: changed
|
|
@ -13348,18 +13348,15 @@ msgstr ""
|
|||
msgid "Your request for access has been queued for review."
|
||||
msgstr ""
|
||||
|
||||
msgid "a Zoom call was added to this issue"
|
||||
msgstr ""
|
||||
|
||||
msgid "a Zoom call was removed from this issue"
|
||||
msgstr ""
|
||||
|
||||
msgid "a deleted user"
|
||||
msgstr ""
|
||||
|
||||
msgid "added %{created_at_timeago}"
|
||||
msgstr ""
|
||||
|
||||
msgid "added a Zoom call to this issue"
|
||||
msgstr ""
|
||||
|
||||
msgid "ago"
|
||||
msgstr ""
|
||||
|
||||
|
@ -13896,6 +13893,9 @@ msgstr ""
|
|||
msgid "remove due date"
|
||||
msgstr ""
|
||||
|
||||
msgid "removed a Zoom call from this issue"
|
||||
msgstr ""
|
||||
|
||||
msgid "rendered diff"
|
||||
msgstr ""
|
||||
|
||||
|
|
|
@ -229,10 +229,10 @@ describe Issues::UpdateService, :mailer do
|
|||
it 'creates zoom_link_added system note when a zoom link is added to the description' do
|
||||
update_issue(description: 'Changed description https://zoom.us/j/5873603787')
|
||||
|
||||
note = find_note('a Zoom call was added')
|
||||
note = find_note('added a Zoom call')
|
||||
|
||||
expect(note).not_to be_nil
|
||||
expect(note.note).to eq('a Zoom call was added to this issue')
|
||||
expect(note.note).to eq('added a Zoom call to this issue')
|
||||
end
|
||||
|
||||
context 'when issue turns confidential' do
|
||||
|
|
|
@ -521,7 +521,7 @@ describe SystemNoteService do
|
|||
end
|
||||
|
||||
it 'sets the zoom link added note text' do
|
||||
expect(subject.note).to eq('a Zoom call was added to this issue')
|
||||
expect(subject.note).to eq('added a Zoom call to this issue')
|
||||
end
|
||||
end
|
||||
|
||||
|
@ -533,7 +533,7 @@ describe SystemNoteService do
|
|||
end
|
||||
|
||||
it 'sets the zoom link removed note text' do
|
||||
expect(subject.note).to eq('a Zoom call was removed from this issue')
|
||||
expect(subject.note).to eq('removed a Zoom call from this issue')
|
||||
end
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in New Issue