kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'pl-uninstall-button-qa' into 'master'

Browse source 
Check for "Uninstall" button reducing friction

See merge request gitlab-org/gitlab-ce!30713
This commit is contained in:
Ramya Authappan 2019-07-16 05:22:27 +00:00
commit 846f864d63
2 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
qa/qa/page/project/operations/kubernetes/show.rb
View file

@ -28,16 +28,12 @@ module QA
end
end
def await_installed(application_name, button_text: 'Installed')
def await_installed(application_name)
within(".js-cluster-application-row-#{application_name}") do
page.has_text?(button_text, wait: 300)
page.has_text?(/Installed|Uninstall/, wait: 300)
end
end
def await_uninstallable(application_name)
await_installed(application_name, button_text: 'Uninstall')
end
def ingress_ip
# We need to wait longer since it can take some time before the
# ip address is assigned for the ingress controller

2
qa/qa/resource/kubernetes_cluster.rb
View file

@ -47,7 +47,7 @@ module QA
page.install!(:runner) if @install_runner
page.await_installed(:ingress) if @install_ingress
page.await_uninstallable(:prometheus) if @install_prometheus
page.await_installed(:prometheus) if @install_prometheus
page.await_installed(:runner) if @install_runner
if @install_ingress