Merge branch 'sh-remove-local-sidekiq-admin-check' into 'master'
Remove display of local Sidekiq process in /admin/sidekiq Closes #46133 See merge request gitlab-org/gitlab-ce!23118
This commit is contained in:
commit
84db49ea0c
3 changed files with 5 additions and 43 deletions
|
@ -1,9 +1,4 @@
|
||||||
# frozen_string_literal: true
|
# frozen_string_literal: true
|
||||||
|
|
||||||
class Admin::BackgroundJobsController < Admin::ApplicationController
|
class Admin::BackgroundJobsController < Admin::ApplicationController
|
||||||
def show
|
|
||||||
ps_output, _ = Gitlab::Popen.popen(%W(ps ww -U #{Gitlab.config.gitlab.user} -o pid,pcpu,pmem,stat,start,command))
|
|
||||||
@sidekiq_processes = ps_output.split("\n").grep(/sidekiq \d+\.\d+\.\d+/)
|
|
||||||
@concurrency = Sidekiq.options[:concurrency]
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
|
|
|
@ -6,43 +6,5 @@
|
||||||
%p.light GitLab uses #{link_to "sidekiq", "http://sidekiq.org/"} library for async job processing
|
%p.light GitLab uses #{link_to "sidekiq", "http://sidekiq.org/"} library for async job processing
|
||||||
|
|
||||||
%hr
|
%hr
|
||||||
|
|
||||||
.card
|
|
||||||
.card-header Sidekiq running processes
|
|
||||||
.card-body
|
|
||||||
- if @sidekiq_processes.empty?
|
|
||||||
%h4.cred
|
|
||||||
%i.fa.fa-exclamation-triangle
|
|
||||||
There are no running sidekiq processes. Please restart GitLab
|
|
||||||
- else
|
|
||||||
.table-holder
|
|
||||||
%table.table
|
|
||||||
%thead
|
|
||||||
%th USER
|
|
||||||
%th PID
|
|
||||||
%th CPU
|
|
||||||
%th MEM
|
|
||||||
%th STATE
|
|
||||||
%th START
|
|
||||||
%th COMMAND
|
|
||||||
%tbody
|
|
||||||
- @sidekiq_processes.each do |process|
|
|
||||||
%tr
|
|
||||||
%td= gitlab_config.user
|
|
||||||
- parse_sidekiq_ps(process).each do |value|
|
|
||||||
%td= value
|
|
||||||
.clearfix
|
|
||||||
%p
|
|
||||||
%i.fa.fa-exclamation-circle
|
|
||||||
If '[#{@concurrency} of #{@concurrency} busy]' is shown, restart GitLab.
|
|
||||||
= link_to sprite_icon('question', size: 16), help_page_path('administration/restart_gitlab')
|
|
||||||
|
|
||||||
%p
|
|
||||||
%i.fa.fa-exclamation-circle
|
|
||||||
If more than one sidekiq process is listed, stop GitLab, kill the remaining sidekiq processes (sudo pkill -u #{gitlab_config.user} -f sidekiq) and restart GitLab.
|
|
||||||
= link_to sprite_icon('question', size: 16), help_page_path('administration/restart_gitlab')
|
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
.card
|
.card
|
||||||
%iframe{ src: sidekiq_path, width: '100%', height: 970, style: "border: 0" }
|
%iframe{ src: sidekiq_path, width: '100%', height: 970, style: "border: 0" }
|
||||||
|
|
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
title: Remove display of local Sidekiq process in /admin/sidekiq
|
||||||
|
merge_request: 23118
|
||||||
|
author:
|
||||||
|
type: fixed
|
Loading…
Reference in a new issue