kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch '58632-fix-mr-widget-padding' into 'master'

Browse source 
Fix MR widget padding

Closes #58632

See merge request gitlab-org/gitlab-ce!28472
This commit is contained in:
Mike Greiling 2019-05-24 16:39:51 +00:00
commit 8552e8e3cd
4 changed files with 50 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/assets/javascripts/vue_merge_request_widget/components/source_branch_removal_status.vue
View file

@ -14,7 +14,7 @@ export default {
</script> </script>
<template> <template>
<p v-once class="mr-info-list mr-links source-branch-removal-status append-bottom-0"> <p v-once class="mr-info-list mr-links append-bottom-0">
<span class="status-text" v-html="removesBranchText"> </span> <span class="status-text" v-html="removesBranchText"> </span>
<i v-tooltip :title="tooltipTitle" :aria-label="tooltipTitle" class="fa fa-question-circle"> <i v-tooltip :title="tooltipTitle" :aria-label="tooltipTitle" class="fa fa-question-circle">
</i> </i>

66
app/assets/javascripts/vue_merge_request_widget/mr_widget_options.vue
View file

@ -333,41 +333,45 @@ export default {
<div class="mr-widget-section"> <div class="mr-widget-section">
<component :is="componentName" :mr="mr" :service="service" /> <component :is="componentName" :mr="mr" :service="service" />
<section v-if="shouldRenderCollaborationStatus" class="mr-info-list mr-links"> <div class="mr-widget-info">
{{ s__('mrWidget|Allows commits from members who can merge to the target branch') }} <section v-if="shouldRenderCollaborationStatus" class="mr-info-list mr-links">
</section> <p>
{{ s__('mrWidget|Allows commits from members who can merge to the target branch') }}
</p>
</section>
<mr-widget-related-links <mr-widget-related-links
v-if="shouldRenderRelatedLinks" v-if="shouldRenderRelatedLinks"
:state="mr.state" :state="mr.state"
:related-links="mr.relatedLinks" :related-links="mr.relatedLinks"
/> />
<mr-widget-alert-message <mr-widget-alert-message
v-if="showMergePipelineForkWarning" v-if="showMergePipelineForkWarning"
type="warning" type="warning"
:help-path="mr.mergeRequestPipelinesHelpPath" :help-path="mr.mergeRequestPipelinesHelpPath"
> >
{{ {{
s__( s__(
'mrWidget|Fork merge requests do not create merge request pipelines which validate a post merge result', 'mrWidget|Fork merge requests do not create merge request pipelines which validate a post merge result',
) )
}} }}
</mr-widget-alert-message> </mr-widget-alert-message>
<mr-widget-alert-message <mr-widget-alert-message
v-if="showTargetBranchAdvancedError" v-if="showTargetBranchAdvancedError"
type="danger" type="danger"
:help-path="mr.mergeRequestPipelinesHelpPath" :help-path="mr.mergeRequestPipelinesHelpPath"
> >
{{ {{
s__( s__(
'mrWidget|The target branch has advanced, which invalidates the merge request pipeline. Please update the source branch and retry merging', 'mrWidget|The target branch has advanced, which invalidates the merge request pipeline. Please update the source branch and retry merging',
) )
}} }}
</mr-widget-alert-message> </mr-widget-alert-message>
<source-branch-removal-status v-if="shouldRenderSourceBranchRemovalStatus" /> <source-branch-removal-status v-if="shouldRenderSourceBranchRemovalStatus" />
</div>
</div> </div>
<div v-if="shouldRenderMergeHelp" class="mr-widget-footer"><mr-widget-merge-help /></div> <div v-if="shouldRenderMergeHelp" class="mr-widget-footer"><mr-widget-merge-help /></div>
</div> </div>

14
app/assets/stylesheets/pages/merge_requests.scss
View file

@ -87,6 +87,11 @@
padding: $gl-padding; padding: $gl-padding;
} }
.mr-widget-info {
padding-left: $gl-padding-50 - $gl-padding-32;
padding-right: $gl-padding;
}
.mr-state-widget { .mr-state-widget {
color: $gl-text-color; color: $gl-text-color;
@ -560,6 +565,10 @@
.mr-links { .mr-links {
padding-left: $status-icon-size + $gl-btn-padding; padding-left: $status-icon-size + $gl-btn-padding;
&:last-child {
padding-bottom: $gl-padding;
}
} }
.mr-info-list { .mr-info-list {
@ -1030,11 +1039,6 @@
background: $black-transparent; background: $black-transparent;
} }
.source-branch-removal-status {
padding-left: 50px;
padding-bottom: $gl-padding;
}
.mr-compare { .mr-compare {
.diff-file .file-title-flex-parent { .diff-file .file-title-flex-parent {
top: $header-height + 51px; top: $header-height + 51px;

5
changelogs/unreleased/58632-fix-mr-widget-padding.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Fix padding in MR widget
merge_request: 28472
author:
type: fixed