From 8607383e1dcdde62a2143890f02a72141dd44af1 Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Mon, 19 Dec 2016 18:11:18 +0800 Subject: [PATCH] Just implement it in the block Feedback: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8088#note_20223109 --- lib/gitlab/serialize/ci/variables.rb | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/lib/gitlab/serialize/ci/variables.rb b/lib/gitlab/serialize/ci/variables.rb index 0ca060cd95e..8919f0ccd00 100644 --- a/lib/gitlab/serialize/ci/variables.rb +++ b/lib/gitlab/serialize/ci/variables.rb @@ -12,20 +12,16 @@ module Gitlab object = YAML.safe_load(string, [Symbol]) - object.map(&Variables.method(:convert_key_value_to_string)) + object.map do |variable| + variable[:key] = variable[:key].to_s + variable[:value] = variable[:value].to_s + variable + end end def dump(object) YAML.dump(object) end - - private - - def convert_key_value_to_string(variable) - variable[:key] = variable[:key].to_s - variable[:value] = variable[:value].to_s - variable - end end end end