From 86ef8221778d2aff630feecfa15ba70514983dbc Mon Sep 17 00:00:00 2001 From: Mayra Cabrera Date: Tue, 15 May 2018 13:03:09 -0500 Subject: [PATCH] Makes CommitStatus and GenericCommitStatus respond to presentable methods Includes Presentable module into CommitStatus. This fixes presenter methods being called on those classes. Closes #46177 --- app/models/commit_status.rb | 1 + app/presenters/commit_status_presenter.rb | 2 ++ app/presenters/generic_commit_status_presenter.rb | 2 ++ spec/models/commit_status_spec.rb | 9 +++++++++ 4 files changed, 14 insertions(+) create mode 100644 app/presenters/commit_status_presenter.rb create mode 100644 app/presenters/generic_commit_status_presenter.rb diff --git a/app/models/commit_status.rb b/app/models/commit_status.rb index 97d89422594..a7d05722287 100644 --- a/app/models/commit_status.rb +++ b/app/models/commit_status.rb @@ -2,6 +2,7 @@ class CommitStatus < ActiveRecord::Base include HasStatus include Importable include AfterCommitQueue + include Presentable self.table_name = 'ci_builds' diff --git a/app/presenters/commit_status_presenter.rb b/app/presenters/commit_status_presenter.rb new file mode 100644 index 00000000000..028deaf235c --- /dev/null +++ b/app/presenters/commit_status_presenter.rb @@ -0,0 +1,2 @@ +class CommitStatusPresenter < Ci::BuildPresenter +end diff --git a/app/presenters/generic_commit_status_presenter.rb b/app/presenters/generic_commit_status_presenter.rb new file mode 100644 index 00000000000..da09df29a37 --- /dev/null +++ b/app/presenters/generic_commit_status_presenter.rb @@ -0,0 +1,2 @@ +class GenericCommitStatusPresenter < CommitStatusPresenter +end diff --git a/spec/models/commit_status_spec.rb b/spec/models/commit_status_spec.rb index 2ed29052dc1..eddcf616b53 100644 --- a/spec/models/commit_status_spec.rb +++ b/spec/models/commit_status_spec.rb @@ -565,4 +565,13 @@ describe CommitStatus do it_behaves_like 'commit status enqueued' end end + + describe '#present' do + let(:generic_commit_status) { create(:generic_commit_status) } + + it 'returns a presenter' do + expect(commit_status.present).to be_a(Ci::BuildPresenter) + expect(generic_commit_status.present).to be_a(Ci::BuildPresenter) + end + end end