From 886f00bcba23d67e2c86591c2eb5359ef457a2f9 Mon Sep 17 00:00:00 2001
From: Stan Hu <stanhu@gmail.com>
Date: Fri, 15 Feb 2019 05:58:23 -0800
Subject: [PATCH] Backport commit author changes from CE

This backports the changes made in EE to fix merge request approvers
from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/9574.
---
 app/models/commit_collection.rb       |  4 ++--
 app/models/merge_request.rb           |  6 +++---
 spec/models/commit_collection_spec.rb | 14 +++++++-------
 spec/models/merge_request_spec.rb     | 17 +++++++++--------
 4 files changed, 21 insertions(+), 20 deletions(-)

diff --git a/app/models/commit_collection.rb b/app/models/commit_collection.rb
index 42ec5b5e664..a9a2e9c81eb 100644
--- a/app/models/commit_collection.rb
+++ b/app/models/commit_collection.rb
@@ -20,8 +20,8 @@ class CommitCollection
     commits.each(&block)
   end
 
-  def committers
-    emails = without_merge_commits.map(&:committer_email).uniq
+  def authors
+    emails = without_merge_commits.map(&:author_email).uniq
 
     User.by_any_email(emails)
   end
diff --git a/app/models/merge_request.rb b/app/models/merge_request.rb
index 2035bffd829..52cf151b700 100644
--- a/app/models/merge_request.rb
+++ b/app/models/merge_request.rb
@@ -286,12 +286,12 @@ class MergeRequest < ActiveRecord::Base
     work_in_progress?(title) ? title : "WIP: #{title}"
   end
 
-  def committers
-    @committers ||= commits.committers
+  def commit_authors
+    @commit_authors ||= commits.authors
   end
 
   def authors
-    User.from_union([committers, User.where(id: self.author_id)])
+    User.from_union([commit_authors, User.where(id: self.author_id)])
   end
 
   # Verifies if title has changed not taking into account WIP prefix
diff --git a/spec/models/commit_collection_spec.rb b/spec/models/commit_collection_spec.rb
index 12e59b35428..0f5d03ff458 100644
--- a/spec/models/commit_collection_spec.rb
+++ b/spec/models/commit_collection_spec.rb
@@ -12,26 +12,26 @@ describe CommitCollection do
     end
   end
 
-  describe '.committers' do
+  describe '.authors' do
     it 'returns a relation of users when users are found' do
-      user = create(:user, email: commit.committer_email.upcase)
+      user = create(:user, email: commit.author_email.upcase)
       collection = described_class.new(project, [commit])
 
-      expect(collection.committers).to contain_exactly(user)
+      expect(collection.authors).to contain_exactly(user)
     end
 
-    it 'returns empty array when committers cannot be found' do
+    it 'returns empty array when authors cannot be found' do
       collection = described_class.new(project, [commit])
 
-      expect(collection.committers).to be_empty
+      expect(collection.authors).to be_empty
     end
 
     it 'excludes authors of merge commits' do
       commit = project.commit("60ecb67744cb56576c30214ff52294f8ce2def98")
-      create(:user, email: commit.committer_email.upcase)
+      create(:user, email: commit.author_email.upcase)
       collection = described_class.new(project, [commit])
 
-      expect(collection.committers).to be_empty
+      expect(collection.authors).to be_empty
     end
   end
 
diff --git a/spec/models/merge_request_spec.rb b/spec/models/merge_request_spec.rb
index afa87b8a62d..39ffef5f051 100644
--- a/spec/models/merge_request_spec.rb
+++ b/spec/models/merge_request_spec.rb
@@ -435,6 +435,7 @@ describe MergeRequest do
       it 'does not cache issues from external trackers' do
         issue  = ExternalIssue.new('JIRA-123', subject.project)
         commit = double('commit1', safe_message: "Fixes #{issue.to_reference}")
+
         allow(subject).to receive(:commits).and_return([commit])
 
         expect { subject.cache_merge_request_closes_issues!(subject.author) }.not_to raise_error
@@ -1023,23 +1024,23 @@ describe MergeRequest do
     end
   end
 
-  describe '#committers' do
-    it 'returns all the committers of every commit in the merge request' do
-      users = subject.commits.map(&:committer_email).uniq.map do |email|
+  describe '#commit_authors' do
+    it 'returns all the authors of every commit in the merge request' do
+      users = subject.commits.map(&:author_email).uniq.map do |email|
         create(:user, email: email)
       end
 
-      expect(subject.committers).to match_array(users)
+      expect(subject.commit_authors).to match_array(users)
     end
 
-    it 'returns an empty array if no committer is associated with a user' do
-      expect(subject.committers).to be_empty
+    it 'returns an empty array if no author is associated with a user' do
+      expect(subject.commit_authors).to be_empty
     end
   end
 
   describe '#authors' do
-    it 'returns a list with all the committers in the merge request and author' do
-      users = subject.commits.map(&:committer_email).uniq.map do |email|
+    it 'returns a list with all the commit authors in the merge request and author' do
+      users = subject.commits.map(&:author_email).uniq.map do |email|
         create(:user, email: email)
       end