From 88bacc889f129f8d95af34f1781dd66769ec27cc Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 8 Apr 2022 12:08:48 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo.yml | 18 - .../multiline_operation_indentation.yml | 106 +++++ .rubocop_todo/layout/space_inside_parens.yml | 440 ++++++++++++++++++ .../lint/constant_definition_in_block.yml | 53 +++ .../behaviors/markdown/render_gfm.js | 2 +- .../behaviors/shortcuts/shortcuts_issuable.js | 2 +- .../javascripts/blob/pdf/pdf_viewer.vue | 2 +- .../boards/components/board_card_inner.vue | 2 +- .../code_navigation/components/app.vue | 2 +- .../javascripts/diffs/components/app.vue | 2 +- .../diffs/components/diff_content.vue | 6 +- .../diffs/components/diff_discussions.vue | 2 +- .../diffs/components/diff_file.vue | 2 +- .../diffs/components/diff_line_note_form.vue | 11 +- app/assets/javascripts/diffs/store/actions.js | 2 +- .../javascripts/diffs/utils/performance.js | 2 +- .../folder/environments_folder_bundle.js | 2 +- .../ide/components/ide_status_bar.vue | 4 +- .../image_diff/helpers/init_image_diff.js | 2 +- .../jira_connect/subscriptions/index.js | 2 +- .../mr_popover/components/mr_popover.vue | 4 +- .../components/diff_discussion_header.vue | 2 +- .../notes/components/diff_with_note.vue | 2 +- .../notes/components/note_edited_text.vue | 2 +- .../notes/components/note_header.vue | 2 +- .../notes/components/noteable_discussion.vue | 2 +- app/assets/javascripts/pages/admin/index.js | 4 +- .../javascripts/pages/projects/index.js | 4 +- .../javascripts/pages/projects/project.js | 2 +- .../repository/components/last_commit.vue | 8 +- .../javascripts/serverless/components/url.vue | 2 +- .../components/copy_email_to_clipboard.vue | 2 +- .../components/mr_widget_status_icon.vue | 2 +- .../vue_shared/components/awards_list.vue | 2 +- app/controllers/groups/releases_controller.rb | 4 +- app/finders/releases/group_releases_finder.rb | 8 +- app/helpers/wiki_helper.rb | 4 + app/models/ci/namespace_mirror.rb | 20 + app/models/ci/secure_file.rb | 7 + app/models/concerns/from_set_operator.rb | 7 +- app/models/user.rb | 23 +- app/models/wiki.rb | 53 ++- app/models/wiki_page.rb | 4 +- app/services/event_create_service.rb | 5 +- app/uploaders/ci/secure_file_uploader.rb | 2 +- app/views/errors/_footer.html.haml | 4 +- app/views/layouts/errors.html.haml | 4 +- app/views/projects/forks/index.html.haml | 13 +- app/views/shared/wikis/_form.html.haml | 2 +- .../ci_owned_runners_unnest_index.yml | 8 + ...0324175325_add_key_data_to_secure_files.rb | 17 + ...e_mirrors_unnest_index_on_traversal_ids.rb | 25 + db/schema_migrations/20220324175325 | 1 + db/schema_migrations/20220329110630 | 1 + db/structure.sql | 6 +- .../reference_architectures/25k_users.md | 6 +- .../reference_architectures/index.md | 28 +- doc/api/api_resources.md | 1 + doc/api/group_releases.md | 77 +++ doc/api/releases/index.md | 8 +- .../index.md | 2 +- doc/development/code_review.md | 4 +- .../add_foreign_key_to_existing_column.md | 2 +- .../avoiding_downtime_in_migrations.md | 12 +- .../{ => database}/background_migrations.md | 16 +- .../database/database_reviewer_guidelines.md | 2 +- .../{ => database}/deleting_migrations.md | 0 doc/development/database/index.md | 8 +- .../database/loose_foreign_keys.md | 4 +- .../database/not_null_constraints.md | 2 +- .../post_deployment_migrations.md | 0 .../database/rename_database_tables.md | 2 +- .../strings_and_the_text_data_type.md | 4 +- .../database/table_partitioning.md | 2 +- doc/development/database_review.md | 10 +- .../iterating_tables_in_batches.md | 2 +- .../merge_request_performance_guidelines.md | 2 +- doc/development/migration_style_guide.md | 18 +- doc/development/scalability.md | 2 +- .../service_ping/metrics_dictionary.md | 2 +- .../service_ping/metrics_lifecycle.md | 2 + .../sidekiq/compatibility_across_updates.md | 2 +- doc/raketasks/backup_restore.md | 2 +- doc/raketasks/migrate_snippets.md | 2 +- doc/update/zero_downtime.md | 2 +- lib/api/entities/basic_release_details.rb | 16 + lib/api/entities/release.rb | 8 +- lib/api/releases.rb | 60 ++- lib/api/wikis.rb | 2 +- .../ci/pipeline/chain/template_usage.rb | 2 +- lib/gitlab/pagination/offset_pagination.rb | 8 +- .../ci_template_unique_counter.rb | 9 +- .../gitlab_migration_large_project_spec.rb | 22 +- spec/factories/ci/builds.rb | 4 +- .../v4/release/release_for_guest.json | 1 + spec/lib/gitlab/ci/build/image_spec.rb | 2 +- spec/lib/gitlab/ci/config/entry/image_spec.rb | 16 +- spec/lib/gitlab/ci/config/entry/root_spec.rb | 14 +- .../ci/config/external/file/project_spec.rb | 4 +- .../gitlab/ci/config/external/mapper_spec.rb | 44 +- .../ci/config/external/processor_spec.rb | 30 +- spec/lib/gitlab/ci/config_spec.rb | 34 +- .../ci/pipeline/chain/template_usage_spec.rb | 2 +- spec/lib/gitlab/ci/yaml_processor_spec.rb | 28 +- spec/lib/gitlab/config/loader/yaml_spec.rb | 10 +- spec/lib/gitlab/path_regex_spec.rb | 2 +- .../ci_template_unique_counter_spec.rb | 44 +- .../web_ide/config/entry/terminal_spec.rb | 4 +- spec/lib/gitlab/web_ide/config_spec.rb | 4 +- spec/models/ci/build_spec.rb | 4 +- spec/models/ci/namespace_mirror_spec.rb | 47 ++ .../environments/deployment_preloader_spec.rb | 10 +- spec/models/user_spec.rb | 8 + spec/models/web_ide_terminal_spec.rb | 6 +- .../api/ci/runner/jobs_request_post_spec.rb | 2 +- spec/requests/api/lint_spec.rb | 6 +- spec/requests/api/releases_spec.rb | 78 ++++ .../environment_serializer_spec.rb | 28 +- .../ci/create_pipeline_service_spec.rb | 10 +- .../create_web_ide_terminal_service_spec.rb | 2 +- spec/services/event_create_service_spec.rb | 5 +- spec/support/gitlab_stubs/gitlab_ci.yml | 2 +- .../user_creates_wiki_page_shared_examples.rb | 6 + .../from_set_operator_shared_examples.rb | 6 + .../models/wiki_shared_examples.rb | 13 + .../environment_serializer_shared_examples.rb | 11 +- .../uploaders/ci/secure_file_uploader_spec.rb | 4 +- 127 files changed, 1396 insertions(+), 370 deletions(-) create mode 100644 .rubocop_todo/layout/multiline_operation_indentation.yml create mode 100644 .rubocop_todo/layout/space_inside_parens.yml create mode 100644 .rubocop_todo/lint/constant_definition_in_block.yml create mode 100644 config/feature_flags/development/ci_owned_runners_unnest_index.yml create mode 100644 db/migrate/20220324175325_add_key_data_to_secure_files.rb create mode 100644 db/migrate/20220329110630_add_ci_namespace_mirrors_unnest_index_on_traversal_ids.rb create mode 100644 db/schema_migrations/20220324175325 create mode 100644 db/schema_migrations/20220329110630 create mode 100644 doc/api/group_releases.md rename doc/development/{ => database}/avoiding_downtime_in_migrations.md (97%) rename doc/development/{ => database}/background_migrations.md (96%) rename doc/development/{ => database}/deleting_migrations.md (100%) rename doc/development/{ => database}/post_deployment_migrations.md (100%) create mode 100644 lib/api/entities/basic_release_details.rb diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d30728c1596..6303568cad1 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -11,13 +11,6 @@ Gitlab/PolicyRuleBoolean: Exclude: - 'ee/app/policies/ee/identity_provider_policy.rb' -# Offense count: 170 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, IndentationWidth. -# SupportedStyles: aligned, indented -Layout/MultilineOperationIndentation: - Enabled: false - # Offense count: 754 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -25,17 +18,6 @@ Layout/MultilineOperationIndentation: Layout/SpaceInLambdaLiteral: Enabled: false -# Offense count: 585 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: space, no_space -Layout/SpaceInsideParens: - Enabled: false - -# Offense count: 84 -Lint/ConstantDefinitionInBlock: - Enabled: false - # Offense count: 2 # Configuration parameters: AllowComments. Lint/EmptyFile: diff --git a/.rubocop_todo/layout/multiline_operation_indentation.yml b/.rubocop_todo/layout/multiline_operation_indentation.yml new file mode 100644 index 00000000000..0f2404ee3cc --- /dev/null +++ b/.rubocop_todo/layout/multiline_operation_indentation.yml @@ -0,0 +1,106 @@ +--- +# Cop supports --auto-correct. +Layout/MultilineOperationIndentation: + # Offense count: 252 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/controllers/projects/application_controller.rb' + - 'app/controllers/repositories/git_http_client_controller.rb' + - 'app/controllers/sent_notifications_controller.rb' + - 'app/graphql/types/ci/stage_type.rb' + - 'app/helpers/application_settings_helper.rb' + - 'app/helpers/auth_helper.rb' + - 'app/helpers/issuables_helper.rb' + - 'app/helpers/mirror_helper.rb' + - 'app/helpers/packages_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/storage_helper.rb' + - 'app/helpers/visibility_level_helper.rb' + - 'app/helpers/whats_new_helper.rb' + - 'app/models/concerns/admin_changed_password_notifier.rb' + - 'app/models/integrations/prometheus.rb' + - 'app/models/namespaces/traversal/linear_scopes.rb' + - 'app/models/packages/conan/metadatum.rb' + - 'app/models/packages/sem_ver.rb' + - 'app/models/project.rb' + - 'app/models/project_statistics.rb' + - 'app/models/user.rb' + - 'app/services/ci/create_downstream_pipeline_service.rb' + - 'app/services/ci/create_pipeline_service.rb' + - 'app/services/git/branch_hooks_service.rb' + - 'app/services/groups/group_links/create_service.rb' + - 'app/services/groups/transfer_service.rb' + - 'app/services/issues/update_service.rb' + - 'app/services/labels/promote_service.rb' + - 'app/services/labels/transfer_service.rb' + - 'app/services/projects/container_repository/cleanup_tags_service.rb' + - 'app/services/webauthn/authenticate_service.rb' + - 'app/validators/feature_flag_strategies_validator.rb' + - 'app/workers/container_expiration_policies/cleanup_container_repository_worker.rb' + - 'config/initializers/devise_dynamic_password_length_validation.rb' + - 'danger/utility_css/Dangerfile' + - 'ee/app/controllers/smartcard_controller.rb' + - 'ee/app/graphql/resolvers/boards/epic_lists_resolver.rb' + - 'ee/app/helpers/ee/application_settings_helper.rb' + - 'ee/app/helpers/ee/boards_helper.rb' + - 'ee/app/helpers/groups/security_features_helper.rb' + - 'ee/app/helpers/groups/sso_helper.rb' + - 'ee/app/models/ee/namespace.rb' + - 'ee/app/models/ee/namespace/root_storage_size.rb' + - 'ee/app/models/ee/project.rb' + - 'ee/app/models/ee/user.rb' + - 'ee/app/models/vulnerabilities/finding_signature.rb' + - 'ee/app/policies/ee/base_policy.rb' + - 'ee/app/services/analytics/cycle_analytics/value_streams/update_service.rb' + - 'ee/app/services/ee/merge_requests/build_service.rb' + - 'ee/app/services/ee/projects/operations/update_service.rb' + - 'ee/lib/ee/api/entities/group.rb' + - 'ee/lib/ee/api/helpers.rb' + - 'ee/lib/ee/gitlab/middleware/read_only/controller.rb' + - 'ee/lib/ee/gitlab/quick_actions/issue_actions.rb' + - 'ee/lib/ee/sidebars/projects/menus/ci_cd_menu.rb' + - 'ee/lib/ee/sidebars/projects/menus/issues_menu.rb' + - 'ee/lib/elastic/latest/issue_class_proxy.rb' + - 'ee/lib/sidebars/groups/menus/analytics_menu.rb' + - 'ee/lib/sidebars/groups/menus/security_compliance_menu.rb' + - 'ee/spec/services/ci/create_pipeline_service/dast_configuration_spec.rb' + - 'lib/api/maven_packages.rb' + - 'lib/api/users.rb' + - 'lib/api/validations/validators/array_none_any.rb' + - 'lib/gitlab/ci/reports/security/finding_key.rb' + - 'lib/gitlab/database/load_balancing/connection_proxy.rb' + - 'lib/gitlab/database/query_analyzers/prevent_cross_database_modification.rb' + - 'lib/gitlab/elasticsearch/logs/lines.rb' + - 'lib/gitlab/form_builders/gitlab_ui_form_builder.rb' + - 'lib/gitlab/git_access.rb' + - 'lib/gitlab/gl_repository/repo_type.rb' + - 'lib/gitlab/jwt_token.rb' + - 'lib/gitlab/kubernetes/helm/v2/install_command.rb' + - 'lib/gitlab/kubernetes/helm/v2/patch_command.rb' + - 'lib/gitlab/kubernetes/helm/v3/install_command.rb' + - 'lib/gitlab/kubernetes/helm/v3/patch_command.rb' + - 'lib/gitlab/pagination/cursor_based_keyset.rb' + - 'lib/gitlab/quick_actions/issue_and_merge_request_actions.rb' + - 'lib/gitlab/rack_attack/request.rb' + - 'lib/gitlab/x509/signature.rb' + - 'lib/gitlab_edition.rb' + - 'lib/kramdown/converter/commonmark.rb' + - 'lib/sidebars/groups/menus/packages_registries_menu.rb' + - 'lib/sidebars/projects/menus/analytics_menu.rb' + - 'lib/sidebars/projects/menus/deployments_menu.rb' + - 'lib/sidebars/projects/menus/hidden_menu.rb' + - 'lib/sidebars/projects/menus/monitor_menu.rb' + - 'lib/sidebars/projects/menus/settings_menu.rb' + - 'qa/qa/ee/page/group/roadmap.rb' + - 'qa/qa/page/component/snippet.rb' + - 'qa/qa/runtime/api/repository_storage_moves.rb' + - 'rubocop/cop/gitlab/keys_first_and_values_first.rb' + - 'rubocop/cop/migration/hash_index.rb' + - 'rubocop/migration_helpers.rb' + - 'spec/frontend/fixtures/tabs.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' + - 'spec/services/ci/create_pipeline_service_spec.rb' + - 'spec/services/projects/import_export/export_service_spec.rb' + - 'spec/support/shared_examples/lib/gitlab/database/background_migration_job_shared_examples.rb' + - 'spec/support/shared_examples/models/with_debian_distributions_shared_examples.rb' diff --git a/.rubocop_todo/layout/space_inside_parens.yml b/.rubocop_todo/layout/space_inside_parens.yml new file mode 100644 index 00000000000..62d33391a25 --- /dev/null +++ b/.rubocop_todo/layout/space_inside_parens.yml @@ -0,0 +1,440 @@ +--- +# Cop supports --auto-correct. +Layout/SpaceInsideParens: + # Offense count: 701 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/controllers/projects/environments_controller.rb' + - 'app/controllers/projects/pipeline_schedules_controller.rb' + - 'app/graphql/mutations/ci/job/base.rb' + - 'app/helpers/icons_helper.rb' + - 'app/helpers/projects_helper.rb' + - 'app/helpers/reminder_emails_helper.rb' + - 'app/models/alert_management/alert.rb' + - 'app/models/ci/build_metadata.rb' + - 'app/models/concerns/milestoneable.rb' + - 'app/models/concerns/mirror_authentication.rb' + - 'app/models/concerns/protected_ref_access.rb' + - 'app/models/cycle_analytics/project_level_stage_adapter.rb' + - 'app/models/merge_request.rb' + - 'app/models/pages_domain.rb' + - 'app/models/project.rb' + - 'app/services/ci/archive_trace_service.rb' + - 'app/services/jira_import/start_import_service.rb' + - 'app/services/labels/transfer_service.rb' + - 'app/services/packages/debian/create_distribution_service.rb' + - 'app/services/packages/debian/update_distribution_service.rb' + - 'app/services/packages/npm/create_package_service.rb' + - 'app/services/personal_access_tokens/revoke_service.rb' + - 'app/services/snippets/create_service.rb' + - 'app/services/spam/spam_verdict_service.rb' + - 'config/initializers/wikicloth_redos_patch.rb' + - 'db/post_migrate/20210722042939_update_issuable_slas_where_issue_closed.rb' + - 'ee/app/graphql/resolvers/external_issue_resolver.rb' + - 'ee/app/helpers/billing_plans_helper.rb' + - 'ee/app/helpers/ee/boards_helper.rb' + - 'ee/app/models/ee/lfs_object.rb' + - 'ee/app/models/ee/merge_request_diff.rb' + - 'ee/app/models/ee/pages_deployment.rb' + - 'ee/app/models/ee/upload.rb' + - 'ee/app/models/requirements_management/requirement.rb' + - 'ee/app/models/resource_iteration_event.rb' + - 'ee/app/services/compliance_management/frameworks/create_service.rb' + - 'ee/app/services/compliance_management/frameworks/destroy_service.rb' + - 'ee/app/services/compliance_management/frameworks/update_service.rb' + - 'ee/app/services/elastic/cluster_reindexing_service.rb' + - 'ee/app/services/namespaces/check_storage_size_service.rb' + - 'ee/app/services/sitemap/create_service.rb' + - 'ee/lib/ee/gitlab/auth/ldap/access.rb' + - 'ee/lib/gitlab/auth/smartcard/session.rb' + - 'ee/spec/controllers/admin/licenses_controller_spec.rb' + - 'ee/spec/controllers/ee/groups_controller_spec.rb' + - 'ee/spec/controllers/groups/analytics/productivity_analytics_controller_spec.rb' + - 'ee/spec/controllers/projects/issues_controller_spec.rb' + - 'ee/spec/controllers/projects/merge_requests/creations_controller_spec.rb' + - 'ee/spec/controllers/projects/merge_requests_controller_spec.rb' + - 'ee/spec/controllers/projects/security/vulnerabilities_controller_spec.rb' + - 'ee/spec/controllers/projects/settings/operations_controller_spec.rb' + - 'ee/spec/features/account_recovery_regular_check_spec.rb' + - 'ee/spec/features/billings/billing_plans_spec.rb' + - 'ee/spec/features/boards/board_filters_spec.rb' + - 'ee/spec/features/boards/group_boards/board_deletion_spec.rb' + - 'ee/spec/features/boards/user_visits_board_spec.rb' + - 'ee/spec/features/groups/analytics/ci_cd_analytics_spec.rb' + - 'ee/spec/features/groups/issues_spec.rb' + - 'ee/spec/features/groups/iteration_spec.rb' + - 'ee/spec/features/groups/iterations/user_creates_iteration_in_cadence_spec.rb' + - 'ee/spec/features/groups/iterations/user_edits_iteration_cadence_spec.rb' + - 'ee/spec/features/groups/iterations/user_edits_iteration_spec.rb' + - 'ee/spec/features/merge_request/user_edits_multiple_reviewers_mr_spec.rb' + - 'ee/spec/features/merge_requests/user_resets_approvers_spec.rb' + - 'ee/spec/features/merge_requests/user_views_all_merge_requests_spec.rb' + - 'ee/spec/features/merge_trains/two_merge_requests_on_train_spec.rb' + - 'ee/spec/finders/ee/alert_management/alerts_finder_spec.rb' + - 'ee/spec/finders/ee/alert_management/http_integrations_finder_spec.rb' + - 'ee/spec/finders/epics_finder_spec.rb' + - 'ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb' + - 'ee/spec/frontend/fixtures/analytics/devops_reports/devops_adoption/enabled_namespaces.rb' + - 'ee/spec/frontend/fixtures/epic.rb' + - 'ee/spec/frontend/fixtures/projects.rb' + - 'ee/spec/graphql/ee/resolvers/board_lists_resolver_spec.rb' + - 'ee/spec/graphql/mutations/app_sec/fuzzing/coverage/corpus/create_spec.rb' + - 'ee/spec/graphql/mutations/dast/profiles/create_spec.rb' + - 'ee/spec/graphql/resolvers/epics_resolver_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/drop_invalid_remediations_spec.rb' + - 'ee/spec/lib/ee/gitlab/usage_data_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/auth_hash_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/dynamic_settings_spec.rb' + - 'ee/spec/lib/gitlab/auth/group_saml/group_lookup_spec.rb' + - 'ee/spec/lib/gitlab/auth/otp/session_enforcer_spec.rb' + - 'ee/spec/lib/gitlab/auth/smartcard/ldap_certificate_spec.rb' + - 'ee/spec/lib/gitlab/auth_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/cluster_image_scanning_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/coverage_fuzzing_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_api_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_api_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_latest_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/dast_runner_validation_gitlab_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/ci/templates/secure_binaries_ci_yaml_spec.rb' + - 'ee/spec/lib/gitlab/geo/git_ssh_proxy_spec.rb' + - 'ee/spec/lib/gitlab/geo/log_cursor/events/event_spec.rb' + - 'ee/spec/lib/gitlab/graphql/aggregations/epics/lazy_epic_aggregate_spec.rb' + - 'ee/spec/lib/gitlab/status_page/storage/s3_client_spec.rb' + - 'ee/spec/mailers/notify_spec.rb' + - 'ee/spec/migrations/add_non_null_constraint_for_escalation_rule_on_pending_alert_escalations_spec.rb' + - 'ee/spec/migrations/drop_invalid_remediations_spec.rb' + - 'ee/spec/models/allowed_email_domain_spec.rb' + - 'ee/spec/models/boards/epic_board_position_spec.rb' + - 'ee/spec/models/dora/change_failure_rate_metric_spec.rb' + - 'ee/spec/models/ee/integrations/jira_spec.rb' + - 'ee/spec/models/ee/iteration_spec.rb' + - 'ee/spec/models/ee/key_spec.rb' + - 'ee/spec/models/ee/system_note_metadata_spec.rb' + - 'ee/spec/models/geo/every_geo_event_spec.rb' + - 'ee/spec/models/incident_management/escalation_rule_spec.rb' + - 'ee/spec/models/ip_restriction_spec.rb' + - 'ee/spec/models/issue_spec.rb' + - 'ee/spec/models/ldap_group_link_spec.rb' + - 'ee/spec/models/license_spec.rb' + - 'ee/spec/models/member_spec.rb' + - 'ee/spec/models/project_spec.rb' + - 'ee/spec/models/release_highlight_spec.rb' + - 'ee/spec/models/security/orchestration_policy_configuration_spec.rb' + - 'ee/spec/models/vulnerabilities/feedback_spec.rb' + - 'ee/spec/requests/api/boards_spec.rb' + - 'ee/spec/requests/api/epics_spec.rb' + - 'ee/spec/requests/api/graphql/group/epics_spec.rb' + - 'ee/spec/requests/api/graphql/mutations/iterations/update_spec.rb' + - 'ee/spec/requests/api/graphql/projects/compliance_frameworks_spec.rb' + - 'ee/spec/requests/api/group_boards_spec.rb' + - 'ee/spec/requests/api/iterations_spec.rb' + - 'ee/spec/requests/api/ldap_group_links_spec.rb' + - 'ee/spec/requests/api/project_milestones_spec.rb' + - 'ee/spec/requests/customers_dot/proxy_controller_spec.rb' + - 'ee/spec/requests/survey_responses_controller_spec.rb' + - 'ee/spec/serializers/member_user_entity_spec.rb' + - 'ee/spec/services/app_sec/dast/profiles/create_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_profile_secret_variables/create_or_update_service_spec.rb' + - 'ee/spec/services/app_sec/dast/site_validations/runner_service_spec.rb' + - 'ee/spec/services/app_sec/fuzzing/coverage/corpuses/create_service_spec.rb' + - 'ee/spec/services/ci_cd/github_integration_setup_service_spec.rb' + - 'ee/spec/services/ci_cd/github_setup_service_spec.rb' + - 'ee/spec/services/ee/boards/issues/list_service_spec.rb' + - 'ee/spec/services/ee/notification_service_spec.rb' + - 'ee/spec/services/ee/users/update_service_spec.rb' + - 'ee/spec/services/epic_issues/update_service_spec.rb' + - 'ee/spec/services/geo/container_repository_sync_spec.rb' + - 'ee/spec/services/geo/replication_toggle_request_service_spec.rb' + - 'ee/spec/services/gitlab_subscriptions/create_service_spec.rb' + - 'ee/spec/services/projects/update_mirror_service_spec.rb' + - 'ee/spec/services/search/group_service_spec.rb' + - 'ee/spec/services/search/project_service_spec.rb' + - 'ee/spec/services/security/merge_reports_service_spec.rb' + - 'ee/spec/services/vulnerability_exports/exporters/csv_service_spec.rb' + - 'ee/spec/support/shared_examples/services/geo/geo_request_service_shared_examples.rb' + - 'ee/spec/workers/elastic/migration_worker_spec.rb' + - 'ee/spec/workers/geo/container_repository_sync_dispatch_worker_spec.rb' + - 'ee/spec/workers/security/auto_fix_worker_spec.rb' + - 'ee/spec/workers/security/create_orchestration_policy_worker_spec.rb' + - 'lib/backup/files.rb' + - 'lib/gitlab/ci/reports/security/finding.rb' + - 'lib/gitlab/ci/runner_instructions.rb' + - 'lib/gitlab/database/partitioning/single_numeric_list_partition.rb' + - 'lib/gitlab/database/postgres_hll/buckets.rb' + - 'lib/gitlab/diff/parser.rb' + - 'lib/gitlab/diff/rendered/notebook/diff_file.rb' + - 'lib/gitlab/gitaly_client/commit_service.rb' + - 'lib/gitlab/prometheus_client.rb' + - 'lib/gitlab/sidekiq_daemon/memory_killer.rb' + - 'lib/gitlab/tracking/incident_management.rb' + - 'lib/gitlab/visibility_level.rb' + - 'lib/security/ci_configuration/sast_build_action.rb' + - 'qa/qa/page/group/settings/group_deploy_tokens.rb' + - 'qa/qa/page/merge_request/show.rb' + - 'qa/qa/tools/delete_subgroups.rb' + - 'qa/spec/runtime/feature_spec.rb' + - 'qa/spec/scenario/template_spec.rb' + - 'spec/controllers/boards/issues_controller_spec.rb' + - 'spec/controllers/groups/children_controller_spec.rb' + - 'spec/controllers/groups/registry/repositories_controller_spec.rb' + - 'spec/controllers/groups/releases_controller_spec.rb' + - 'spec/controllers/groups/runners_controller_spec.rb' + - 'spec/controllers/groups_controller_spec.rb' + - 'spec/controllers/omniauth_callbacks_controller_spec.rb' + - 'spec/controllers/projects/environments_controller_spec.rb' + - 'spec/controllers/projects/issues_controller_spec.rb' + - 'spec/controllers/projects/registry/repositories_controller_spec.rb' + - 'spec/controllers/projects/runners_controller_spec.rb' + - 'spec/dependencies/omniauth_saml_spec.rb' + - 'spec/factories/usage_data.rb' + - 'spec/features/admin/admin_runners_spec.rb' + - 'spec/features/boards/board_filters_spec.rb' + - 'spec/features/boards/user_visits_board_spec.rb' + - 'spec/features/dashboard/datetime_on_tooltips_spec.rb' + - 'spec/features/graphql_known_operations_spec.rb' + - 'spec/features/groups/activity_spec.rb' + - 'spec/features/groups/board_sidebar_spec.rb' + - 'spec/features/groups/empty_states_spec.rb' + - 'spec/features/groups/issues_spec.rb' + - 'spec/features/groups/milestone_spec.rb' + - 'spec/features/groups/milestones_sorting_spec.rb' + - 'spec/features/issues/create_issue_for_discussions_in_merge_request_spec.rb' + - 'spec/features/merge_request/user_edits_assignees_sidebar_spec.rb' + - 'spec/features/profiles/two_factor_auths_spec.rb' + - 'spec/features/projects/branches/user_views_branches_spec.rb' + - 'spec/features/projects/fork_spec.rb' + - 'spec/features/projects/issues/viewing_issues_with_external_authorization_enabled_spec.rb' + - 'spec/features/projects/jobs_spec.rb' + - 'spec/features/projects/pipeline_schedules_spec.rb' + - 'spec/features/projects/releases/user_views_edit_release_spec.rb' + - 'spec/features/projects/releases/user_views_releases_spec.rb' + - 'spec/finders/alert_management/http_integrations_finder_spec.rb' + - 'spec/finders/events_finder_spec.rb' + - 'spec/finders/labels_finder_spec.rb' + - 'spec/frontend/fixtures/api_merge_requests.rb' + - 'spec/frontend/fixtures/api_projects.rb' + - 'spec/frontend/fixtures/application_settings.rb' + - 'spec/frontend/fixtures/blob.rb' + - 'spec/frontend/fixtures/branches.rb' + - 'spec/frontend/fixtures/clusters.rb' + - 'spec/frontend/fixtures/deploy_keys.rb' + - 'spec/frontend/fixtures/issues.rb' + - 'spec/frontend/fixtures/jobs.rb' + - 'spec/frontend/fixtures/labels.rb' + - 'spec/frontend/fixtures/merge_requests.rb' + - 'spec/frontend/fixtures/merge_requests_diffs.rb' + - 'spec/frontend/fixtures/metrics_dashboard.rb' + - 'spec/frontend/fixtures/pipeline_schedules.rb' + - 'spec/frontend/fixtures/pipelines.rb' + - 'spec/frontend/fixtures/projects.rb' + - 'spec/frontend/fixtures/prometheus_service.rb' + - 'spec/frontend/fixtures/raw.rb' + - 'spec/frontend/fixtures/services.rb' + - 'spec/frontend/fixtures/snippet.rb' + - 'spec/frontend/fixtures/todos.rb' + - 'spec/graphql/mutations/todos/restore_many_spec.rb' + - 'spec/graphql/resolvers/board_list_issues_resolver_spec.rb' + - 'spec/graphql/resolvers/board_lists_resolver_spec.rb' + - 'spec/graphql/resolvers/board_resolver_spec.rb' + - 'spec/graphql/resolvers/boards_resolver_spec.rb' + - 'spec/graphql/resolvers/group_packages_resolver_spec.rb' + - 'spec/graphql/resolvers/projects_resolver_spec.rb' + - 'spec/graphql/resolvers/recent_boards_resolver_spec.rb' + - 'spec/graphql/resolvers/users_resolver_spec.rb' + - 'spec/helpers/badges_helper_spec.rb' + - 'spec/helpers/ci/builds_helper_spec.rb' + - 'spec/helpers/ci/runners_helper_spec.rb' + - 'spec/helpers/dev_ops_report_helper_spec.rb' + - 'spec/helpers/git_helper_spec.rb' + - 'spec/helpers/gitlab_routing_helper_spec.rb' + - 'spec/helpers/gitlab_script_tag_helper_spec.rb' + - 'spec/helpers/tab_helper_spec.rb' + - 'spec/initializers/carrierwave_patch_spec.rb' + - 'spec/initializers/rdoc_segfault_patch_spec.rb' + - 'spec/lib/api/entities/snippet_spec.rb' + - 'spec/lib/banzai/filter/references/alert_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/feature_flag_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/label_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/merge_request_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/references/snippet_reference_filter_spec.rb' + - 'spec/lib/banzai/filter/repository_link_filter_spec.rb' + - 'spec/lib/bitbucket_server/representation/comment_spec.rb' + - 'spec/lib/bulk_imports/common/pipelines/lfs_objects_pipeline_spec.rb' + - 'spec/lib/error_tracking/sentry_client/projects_spec.rb' + - 'spec/lib/error_tracking/sentry_client/repo_spec.rb' + - 'spec/lib/gitlab/app_text_logger_spec.rb' + - 'spec/lib/gitlab/auth/o_auth/auth_hash_spec.rb' + - 'spec/lib/gitlab/auth/o_auth/user_spec.rb' + - 'spec/lib/gitlab/auth/saml/auth_hash_spec.rb' + - 'spec/lib/gitlab/ci/build/image_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/reports_spec.rb' + - 'spec/lib/gitlab/ci/config/entry/trigger_spec.rb' + - 'spec/lib/gitlab/ci/parsers_spec.rb' + - 'spec/lib/gitlab/ci/pipeline/seed/build_spec.rb' + - 'spec/lib/gitlab/ci/reports/security/vulnerability_reports_comparer_spec.rb' + - 'spec/lib/gitlab/ci/reports/test_suite_spec.rb' + - 'spec/lib/gitlab/ci/templates/5_minute_production_app_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/AWS/deploy_ecs_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Terraform/base_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/Terraform/base_latest_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/auto_devops_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/flutter_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/kaniko_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/managed_cluster_applications_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/npm_spec.rb' + - 'spec/lib/gitlab/ci/templates/terraform_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/ci/templates/terraform_latest_gitlab_ci_yaml_spec.rb' + - 'spec/lib/gitlab/database/background_migration/batched_job_spec.rb' + - 'spec/lib/gitlab/database/migrations/runner_spec.rb' + - 'spec/lib/gitlab/database/reindexing/reindex_concurrently_spec.rb' + - 'spec/lib/gitlab/database/rename_reserved_paths_migration/v1/rename_projects_spec.rb' + - 'spec/lib/gitlab/database_spec.rb' + - 'spec/lib/gitlab/diff/highlight_cache_spec.rb' + - 'spec/lib/gitlab/exclusive_lease_helpers_spec.rb' + - 'spec/lib/gitlab/git/blob_spec.rb' + - 'spec/lib/gitlab/git/commit_spec.rb' + - 'spec/lib/gitlab/git/diff_spec.rb' + - 'spec/lib/gitlab/git/repository_spec.rb' + - 'spec/lib/gitlab/grape_logging/loggers/queue_duration_logger_spec.rb' + - 'spec/lib/gitlab/graphql/lazy_spec.rb' + - 'spec/lib/gitlab/graphql/markdown_field_spec.rb' + - 'spec/lib/gitlab/health_checks/simple_check_shared.rb' + - 'spec/lib/gitlab/highlight_spec.rb' + - 'spec/lib/gitlab/import_export/attributes_permitter_spec.rb' + - 'spec/lib/gitlab/import_export/file_importer_spec.rb' + - 'spec/lib/gitlab/import_export/json/streaming_serializer_spec.rb' + - 'spec/lib/gitlab/import_export/project/export_task_spec.rb' + - 'spec/lib/gitlab/import_export/project/tree_saver_spec.rb' + - 'spec/lib/gitlab/issuables_count_for_state_spec.rb' + - 'spec/lib/gitlab/kubernetes/rollout_status_spec.rb' + - 'spec/lib/gitlab/metrics/dashboard/processor_spec.rb' + - 'spec/lib/gitlab/middleware/same_site_cookies_spec.rb' + - 'spec/lib/gitlab/puma_logging/json_formatter_spec.rb' + - 'spec/lib/gitlab/rack_attack/instrumented_cache_store_spec.rb' + - 'spec/lib/gitlab/redis/cache_spec.rb' + - 'spec/lib/gitlab/redis/queues_spec.rb' + - 'spec/lib/gitlab/redis/shared_state_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executed_spec.rb' + - 'spec/lib/gitlab/sidekiq_middleware/duplicate_jobs/strategies/until_executing_spec.rb' + - 'spec/lib/gitlab/usage/metric_definition_spec.rb' + - 'spec/lib/gitlab/usage/metrics/instrumentations/generic_metric_spec.rb' + - 'spec/lib/gitlab/usage/metrics/name_suggestion_spec.rb' + - 'spec/lib/gitlab/usage_data_spec.rb' + - 'spec/lib/gitlab/utils/delegator_override/validator_spec.rb' + - 'spec/lib/gitlab/utils/usage_data_spec.rb' + - 'spec/lib/security/ci_configuration/container_scanning_build_action_spec.rb' + - 'spec/lib/security/ci_configuration/sast_build_action_spec.rb' + - 'spec/lib/security/ci_configuration/sast_iac_build_action_spec.rb' + - 'spec/lib/security/ci_configuration/secret_detection_build_action_spec.rb' + - 'spec/mailers/emails/profile_spec.rb' + - 'spec/migrations/20211130165043_backfill_sequence_column_for_sprints_table_spec.rb' + - 'spec/migrations/backfill_issues_upvotes_count_spec.rb' + - 'spec/migrations/schedule_copy_ci_builds_columns_to_security_scans2_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/ci/build_trace_spec.rb' + - 'spec/models/ci/pipeline_spec.rb' + - 'spec/models/ci/trigger_request_spec.rb' + - 'spec/models/clusters/applications/prometheus_spec.rb' + - 'spec/models/deploy_token_spec.rb' + - 'spec/models/environment_spec.rb' + - 'spec/models/environment_status_spec.rb' + - 'spec/models/experiment_spec.rb' + - 'spec/models/exported_protected_branch_spec.rb' + - 'spec/models/group_spec.rb' + - 'spec/models/integrations/jira_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/metrics/dashboard/annotation_spec.rb' + - 'spec/models/namespace_setting_spec.rb' + - 'spec/models/namespace_spec.rb' + - 'spec/models/network/graph_spec.rb' + - 'spec/models/packages/package_spec.rb' + - 'spec/models/project_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/models/users/calloutable_spec.rb' + - 'spec/policies/clusters/agent_policy_spec.rb' + - 'spec/presenters/ci/build_presenter_spec.rb' + - 'spec/presenters/packages/conan/package_presenter_spec.rb' + - 'spec/requests/api/boards_spec.rb' + - 'spec/requests/api/ci/runner/jobs_artifacts_spec.rb' + - 'spec/requests/api/ci/runner/jobs_request_post_spec.rb' + - 'spec/requests/api/ci/runners_reset_registration_token_spec.rb' + - 'spec/requests/api/ci/runners_spec.rb' + - 'spec/requests/api/dependency_proxy_spec.rb' + - 'spec/requests/api/deployments_spec.rb' + - 'spec/requests/api/files_spec.rb' + - 'spec/requests/api/go_proxy_spec.rb' + - 'spec/requests/api/graphql/boards/board_list_issues_query_spec.rb' + - 'spec/requests/api/graphql/ci/jobs_spec.rb' + - 'spec/requests/api/graphql/ci/pipelines_spec.rb' + - 'spec/requests/api/graphql/mutations/award_emojis/remove_spec.rb' + - 'spec/requests/api/graphql/mutations/award_emojis/toggle_spec.rb' + - 'spec/requests/api/graphql/mutations/ci/runners_registration_token/reset_spec.rb' + - 'spec/requests/api/group_boards_spec.rb' + - 'spec/requests/api/issues/issues_spec.rb' + - 'spec/requests/api/issues/post_projects_issues_spec.rb' + - 'spec/requests/api/labels_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/requests/api/pages/pages_spec.rb' + - 'spec/requests/api/project_milestones_spec.rb' + - 'spec/requests/api/project_snippets_spec.rb' + - 'spec/requests/api/snippets_spec.rb' + - 'spec/requests/api/submodules_spec.rb' + - 'spec/requests/jwt_controller_spec.rb' + - 'spec/requests/projects/merge_requests/diffs_spec.rb' + - 'spec/requests/projects/merge_requests_spec.rb' + - 'spec/requests/projects/releases_controller_spec.rb' + - 'spec/requests/search_controller_spec.rb' + - 'spec/serializers/analytics_build_entity_spec.rb' + - 'spec/serializers/merge_request_user_entity_spec.rb' + - 'spec/services/authorized_project_update/project_create_service_spec.rb' + - 'spec/services/authorized_project_update/project_group_link_create_service_spec.rb' + - 'spec/services/boards/issues/list_service_spec.rb' + - 'spec/services/ci/compare_test_reports_service_spec.rb' + - 'spec/services/ci/pipeline_processing/atomic_processing_service/status_collection_spec.rb' + - 'spec/services/ci/retry_job_service_spec.rb' + - 'spec/services/clusters/gcp/provision_service_spec.rb' + - 'spec/services/clusters/gcp/verify_provision_status_service_spec.rb' + - 'spec/services/groups/destroy_service_spec.rb' + - 'spec/services/groups/update_shared_runners_service_spec.rb' + - 'spec/services/import/gitlab_projects/file_acquisition_strategies/file_upload_spec.rb' + - 'spec/services/issues/export_csv_service_spec.rb' + - 'spec/services/labels/promote_service_spec.rb' + - 'spec/services/members/invite_service_spec.rb' + - 'spec/services/notes/update_service_spec.rb' + - 'spec/services/packages/composer/composer_json_service_spec.rb' + - 'spec/services/packages/npm/create_package_service_spec.rb' + - 'spec/services/projects/lfs_pointers/lfs_download_service_spec.rb' + - 'spec/services/search/group_service_spec.rb' + - 'spec/services/security/merge_reports_service_spec.rb' + - 'spec/services/suggestions/apply_service_spec.rb' + - 'spec/services/system_notes/issuables_service_spec.rb' + - 'spec/services/users/destroy_service_spec.rb' + - 'spec/services/x509_certificate_revoke_service_spec.rb' + - 'spec/support/helpers/database/partitioning_helpers.rb' + - 'spec/support/helpers/dependency_proxy_helpers.rb' + - 'spec/support/helpers/javascript_fixtures_helpers.rb' + - 'spec/support/shared_contexts/services/projects/container_repository/delete_tags_service_shared_context.rb' + - 'spec/support/shared_examples/ci/badge_template_shared_examples.rb' + - 'spec/support/shared_examples/controllers/destroy_hook_shared_examples.rb' + - 'spec/support/shared_examples/features/project_features_apply_to_issuables_shared_examples.rb' + - 'spec/support/shared_examples/features/wiki/user_views_wiki_page_shared_examples.rb' + - 'spec/support/shared_examples/finders/packages/debian/distributions_finder_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/position_formatters_shared_examples.rb' + - 'spec/support/shared_examples/lib/gitlab/sidekiq_middleware/strategy_shared_examples.rb' + - 'spec/support/shared_examples/mailers/notify_shared_examples.rb' + - 'spec/support/shared_examples/models/concerns/integrations/slack_mattermost_notifier_shared_examples.rb' + - 'spec/support/shared_examples/models/packages/debian/distribution_shared_examples.rb' + - 'spec/support/shared_examples/requests/api/composer_packages_shared_examples.rb' + - 'spec/support/shared_examples/requests/releases_shared_examples.rb' + - 'spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb' + - 'spec/tasks/gitlab/backup_rake_spec.rb' + - 'spec/tasks/gitlab/db_rake_spec.rb' + - 'spec/validators/devise_email_validator_spec.rb' + - 'spec/views/shared/runners/_runner_details.html.haml_spec.rb' + - 'spec/workers/gitlab/jira_import/stage/import_labels_worker_spec.rb' + - 'spec/workers/pipeline_schedule_worker_spec.rb' + - 'spec/workers/purge_dependency_proxy_cache_worker_spec.rb' + - 'spec/workers/releases/manage_evidence_worker_spec.rb' + - 'spec/workers/run_pipeline_schedule_worker_spec.rb' diff --git a/.rubocop_todo/lint/constant_definition_in_block.yml b/.rubocop_todo/lint/constant_definition_in_block.yml new file mode 100644 index 00000000000..1ffea85dfb0 --- /dev/null +++ b/.rubocop_todo/lint/constant_definition_in_block.yml @@ -0,0 +1,53 @@ +--- +Lint/ConstantDefinitionInBlock: + # Offense count: 105 + # Temporarily disabled due to too many offenses + Enabled: false + Exclude: + - 'app/models/concerns/ignorable_columns.rb' + - 'app/models/concerns/partitioned_table.rb' + - 'app/workers/concerns/worker_context.rb' + - 'config/application.rb' + - 'config/initializers/direct_upload_support.rb' + - 'config/initializers/elastic_client_setup.rb' + - 'ee/app/models/concerns/ee/issuable_link.rb' + - 'ee/app/models/ee/application_setting.rb' + - 'ee/app/models/ee/ci/job_artifact.rb' + - 'ee/app/models/ee/ci/pipeline.rb' + - 'ee/app/models/ee/epic.rb' + - 'ee/app/models/ee/issue.rb' + - 'ee/app/models/ee/merge_request_diff.rb' + - 'ee/app/models/ee/plan.rb' + - 'ee/app/models/ee/project_import_state.rb' + - 'ee/app/models/ee/user.rb' + - 'ee/app/models/ee/vulnerability.rb' + - 'ee/app/presenters/ee/commit_status_presenter.rb' + - 'ee/app/services/ee/notes/quick_actions_service.rb' + - 'ee/lib/ee/api/search.rb' + - 'ee/lib/ee/gitlab/ci/status/build/failed.rb' + - 'ee/lib/gitlab/subscription_portal/clients/rest.rb' + - 'ee/lib/tasks/geo.rake' + - 'ee/spec/db/schema_support.rb' + - 'ee/spec/support/matchers/locked_schema.rb' + - 'lib/api/search.rb' + - 'lib/gitlab/quick_actions/issue_actions.rb' + - 'lib/tasks/cache.rake' + - 'lib/tasks/dev.rake' + - 'lib/tasks/gitlab/docs/compile_deprecations.rake' + - 'lib/tasks/gitlab/graphql.rake' + - 'lib/tasks/gitlab/refresh_project_statistics_build_artifacts_size.rake' + - 'lib/tasks/gitlab/snippets.rake' + - 'lib/tasks/gitlab/tw/codeowners.rake' + - 'lib/tasks/gitlab/update_templates.rake' + - 'lib/tasks/tanuki_emoji.rake' + - 'spec/db/schema_spec.rb' + - 'spec/lib/gitlab/quick_actions/dsl_spec.rb' + - 'spec/lib/marginalia_spec.rb' + - 'spec/mailers/notify_spec.rb' + - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb' + - 'spec/models/concerns/bulk_insert_safe_spec.rb' + - 'spec/models/concerns/bulk_insertable_associations_spec.rb' + - 'spec/models/concerns/triggerable_hooks_spec.rb' + - 'spec/models/repository_spec.rb' + - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb' + - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb' diff --git a/app/assets/javascripts/behaviors/markdown/render_gfm.js b/app/assets/javascripts/behaviors/markdown/render_gfm.js index 5079da9aa02..abda31679d8 100644 --- a/app/assets/javascripts/behaviors/markdown/render_gfm.js +++ b/app/assets/javascripts/behaviors/markdown/render_gfm.js @@ -24,7 +24,7 @@ $.fn.renderGFM = function renderGFM() { const mrPopoverElements = this.find('.gfm-merge_request').get(); if (mrPopoverElements.length) { - import(/* webpackChunkName: 'MrPopoverBundle' */ '../../mr_popover') + import(/* webpackChunkName: 'MrPopoverBundle' */ '~/mr_popover') .then(({ default: initMRPopovers }) => { initMRPopovers(mrPopoverElements); }) diff --git a/app/assets/javascripts/behaviors/shortcuts/shortcuts_issuable.js b/app/assets/javascripts/behaviors/shortcuts/shortcuts_issuable.js index 16556252a64..6124befd3b6 100644 --- a/app/assets/javascripts/behaviors/shortcuts/shortcuts_issuable.js +++ b/app/assets/javascripts/behaviors/shortcuts/shortcuts_issuable.js @@ -4,7 +4,7 @@ import { clickCopyToClipboardButton } from '~/behaviors/copy_to_clipboard'; import { getSelectedFragment } from '~/lib/utils/common_utils'; import { isElementVisible } from '~/lib/utils/dom_utils'; import { DEBOUNCE_DROPDOWN_DELAY } from '~/vue_shared/components/sidebar/labels_select_widget/constants'; -import Sidebar from '../../right_sidebar'; +import Sidebar from '~/right_sidebar'; import { CopyAsGFM } from '../markdown/copy_as_gfm'; import { keysFor, diff --git a/app/assets/javascripts/blob/pdf/pdf_viewer.vue b/app/assets/javascripts/blob/pdf/pdf_viewer.vue index a1a62abeb6f..e07e415d6cf 100644 --- a/app/assets/javascripts/blob/pdf/pdf_viewer.vue +++ b/app/assets/javascripts/blob/pdf/pdf_viewer.vue @@ -1,6 +1,6 @@