kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Adds cluster_for_group factory for convienence 

Also means we don't have to resort to an update statement to set parent
for child groups who also have clusters.

This is much shorter than

```
create(:cluster, :provided_by_gcp, :group, groups: [group])
```
This commit is contained in:
Thong Kuah 2019-07-17 11:32:04 +12:00
parent ddf2dcf7fd
commit 88bf3fe8b4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/factories/clusters/clusters.rb
View File

@ -5,6 +5,8 @@ FactoryBot.define do
cluster_type :project_type
managed true
factory :cluster_for_group, traits: [:provided_by_gcp, :group]
trait :instance do
cluster_type { Clusters::Cluster.cluster_types[:instance_type] }
end

10
spec/models/concerns/deployment_platform_spec.rb
View File

@ -46,12 +46,11 @@ describe DeploymentPlatform do
end
context 'when child group has configured kubernetes cluster', :nested_groups do
let!(:child_group1_cluster) { create(:cluster, :provided_by_gcp, :group) }
let(:child_group1) { child_group1_cluster.group }
let(:child_group1) { create(:group, parent: group) }
let!(:child_group1_cluster) { create(:cluster_for_group, groups: [child_group1]) }
before do
project.update!(group: child_group1)
child_group1.update!(parent: group)
end
it 'returns the Kubernetes platform for the child group' do
@ -59,11 +58,10 @@ describe DeploymentPlatform do
end
context 'deeply nested group' do
let!(:child_group2_cluster) { create(:cluster, :provided_by_gcp, :group) }
let(:child_group2) { child_group2_cluster.group }
let(:child_group2) { create(:group, parent: child_group1) }
let!(:child_group2_cluster) { create(:cluster_for_group, groups: [child_group2]) }
before do
child_group2.update!(parent: child_group1)
project.update!(group: child_group2)
end