Merge branch 'frozen-string-enable-app-presenters' into 'master'

Enable frozen string in presenters and policies

See merge request gitlab-org/gitlab-ce!20819

app/policies/application_setting/term_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationSetting
   class TermPolicy < BasePolicy
     include Gitlab::Utils::StrongMemoize

app/policies/base_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'declarative_policy'
 
 class BasePolicy < DeclarativePolicy::Base

app/policies/ci/build_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class BuildPolicy < CommitStatusPolicy
     condition(:protected_ref) do

app/policies/ci/pipeline_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class PipelinePolicy < BasePolicy
     delegate { @subject.project }

app/policies/ci/pipeline_schedule_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class PipelineSchedulePolicy < PipelinePolicy
     alias_method :pipeline_schedule, :subject

app/policies/ci/runner_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class RunnerPolicy < BasePolicy
     with_options scope: :subject, score: 0

app/policies/ci/trigger_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class TriggerPolicy < BasePolicy
     delegate { @subject.project }

app/policies/clusters/cluster_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Clusters
   class ClusterPolicy < BasePolicy
     alias_method :cluster, :subject

app/policies/commit_status_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CommitStatusPolicy < BasePolicy
   delegate { @subject.project }
 

app/policies/deploy_key_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DeployKeyPolicy < BasePolicy
   with_options scope: :subject, score: 0
   condition(:private_deploy_key) { @subject.private? }

app/policies/deploy_token_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DeployTokenPolicy < BasePolicy
   with_options scope: :subject, score: 0
   condition(:maintainer) { @subject.project.team.maintainer?(@user) }

app/policies/deployment_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DeploymentPolicy < BasePolicy
   delegate { @subject.project }
 end

app/policies/environment_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EnvironmentPolicy < BasePolicy
   delegate { @subject.project }
 

app/policies/external_issue_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ExternalIssuePolicy < BasePolicy
   delegate { @subject.project }
 end

app/policies/global_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GlobalPolicy < BasePolicy
   desc "User is blocked"
   with_options scope: :user, score: 0

app/policies/group_label_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupLabelPolicy < BasePolicy
   delegate { @subject.group }
 end

app/policies/group_member_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupMemberPolicy < BasePolicy
   delegate :group
 

app/policies/group_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupPolicy < BasePolicy
   desc "Group is public"
   with_options scope: :subject, score: 0

app/policies/issuable_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IssuablePolicy < BasePolicy
   delegate { @subject.project }
 

app/policies/issue_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IssuePolicy < IssuablePolicy
   # This class duplicates the same check of Issue#readable_by? for performance reasons
   # Make sure to sync this class checks with issue.rb to avoid security problems.

app/policies/merge_request_policy.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class MergeRequestPolicy < IssuablePolicy
 end

app/policies/namespace_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NamespacePolicy < BasePolicy
   rule { anonymous }.prevent_all
 

app/policies/nil_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NilPolicy < BasePolicy
   rule { default }.prevent_all
 end

app/policies/note_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NotePolicy < BasePolicy
   delegate { @subject.project }
   delegate { @subject.noteable if DeclarativePolicy.has_policy?(@subject.noteable) }

app/policies/personal_snippet_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PersonalSnippetPolicy < BasePolicy
   condition(:public_snippet, scope: :subject) { @subject.public? }
   condition(:is_author) { @user && @subject.author == @user }

app/policies/project_label_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectLabelPolicy < BasePolicy
   delegate { @subject.project }
 end

app/policies/project_member_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectMemberPolicy < BasePolicy
   delegate { @subject.project }
 

app/policies/project_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectPolicy < BasePolicy
   extend ClassMethods
 

app/policies/project_policy/class_methods.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectPolicy
   module ClassMethods
     def create_read_update_admin_destroy(name)

app/policies/project_snippet_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectSnippetPolicy < BasePolicy
   delegate :project
 

app/policies/protected_branch_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProtectedBranchPolicy < BasePolicy
   delegate { @subject.project }
 

app/policies/user_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class UserPolicy < BasePolicy
   desc "The current user is the user in question"
   condition(:user_is_self, score: 0) { @subject == @user }

app/presenters/ci/build_metadata_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class BuildMetadataPresenter < Gitlab::View::Presenter::Delegated
     TIMEOUT_SOURCES = {

app/presenters/ci/build_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class BuildPresenter < CommitStatusPresenter
     def erased_by_user?

app/presenters/ci/group_variable_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class GroupVariablePresenter < Gitlab::View::Presenter::Delegated
     presents :variable

app/presenters/ci/pipeline_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class PipelinePresenter < Gitlab::View::Presenter::Delegated
     include Gitlab::Utils::StrongMemoize

app/presenters/ci/variable_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Ci
   class VariablePresenter < Gitlab::View::Presenter::Delegated
     presents :variable

app/presenters/clusters/cluster_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Clusters
   class ClusterPresenter < Gitlab::View::Presenter::Delegated
     presents :cluster

app/presenters/commit_status_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CommitStatusPresenter < Gitlab::View::Presenter::Delegated
   CALLOUT_FAILURE_MESSAGES = {
       unknown_failure: 'There is an unknown failure, please try again',

app/presenters/conversational_development_index/metric_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ConversationalDevelopmentIndex
   class MetricPresenter < Gitlab::View::Presenter::Simple
     def cards

app/presenters/generic_commit_status_presenter.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class GenericCommitStatusPresenter < CommitStatusPresenter
 end

app/presenters/group_member_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupMemberPresenter < MemberPresenter
   private
 

app/presenters/member_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MemberPresenter < Gitlab::View::Presenter::Delegated
   presents :member
 

app/presenters/members_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MembersPresenter < Gitlab::View::Presenter::Delegated
   include Enumerable
 

app/presenters/merge_request_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MergeRequestPresenter < Gitlab::View::Presenter::Delegated
   include ActionView::Helpers::UrlHelper
   include GitlabRoutingHelper

app/presenters/project_member_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectMemberPresenter < MemberPresenter
   private
 

app/presenters/project_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ProjectPresenter < Gitlab::View::Presenter::Delegated
   include ActionView::Helpers::NumberHelper
   include ActionView::Helpers::UrlHelper

app/presenters/projects/settings/deploy_keys_presenter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Projects
   module Settings
     class DeployKeysPresenter < Gitlab::View::Presenter::Simple

changelogs/unreleased/frozen-string-enable-app-presenters-policies.yml

@@ -0,0 +1,5 @@
+---
+title: Enable frozen string in app/presenters and app/policies
+merge_request: 20819
+author: gfyoung
+type: performance