kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Don't use arguments keyword in gettext script 

Causing SAST build to fail unnecessarily.

Follow-up to !19378.
This commit is contained in:
gfyoung 2018-08-19 00:16:05 -07:00
parent d195ee8f81
commit 8a3d565c8e
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
changelogs/unreleased/arguments-keyword-sast.yml Normal file
View File

@ -0,0 +1,5 @@
---
title: Don't use arguments keyword in gettext script
merge_request: 21296
author: gfyoung
type: fixed

10
scripts/frontend/extract_gettext_all.js
View File

@ -7,7 +7,7 @@ const {
} = require('gettext-extractor-vue'); } = require('gettext-extractor-vue');
const ensureSingleLine = require('../../app/assets/javascripts/locale/ensure_single_line.js'); const ensureSingleLine = require('../../app/assets/javascripts/locale/ensure_single_line.js');
const arguments = argumentsParser const args = argumentsParser
.option('-f, --file <file>', 'Extract message from one single file') .option('-f, --file <file>', 'Extract message from one single file')
.option('-a, --all', 'Extract message from all js/vue files') .option('-a, --all', 'Extract message from all js/vue files')
.parse(process.argv); .parse(process.argv);
@ -61,12 +61,12 @@ function printJson() {
console.log(JSON.stringify(messages)); console.log(JSON.stringify(messages));
} }
if (arguments.file) { if (args.file) {
vueParser.parseFile(arguments.file).then(() => printJson()); vueParser.parseFile(args.file).then(() => printJson());
} else if (arguments.all) { } else if (args.all) {
vueParser.parseFilesGlob('{ee/app,app}/assets/javascripts/**/*.{js,vue}').then(() => printJson()); vueParser.parseFilesGlob('{ee/app,app}/assets/javascripts/**/*.{js,vue}').then(() => printJson());
} else { } else {
console.warn('ERROR: Please use the script correctly:'); console.warn('ERROR: Please use the script correctly:');
arguments.outputHelp(); args.outputHelp();
process.exit(1); process.exit(1);
} }