From 8a70817cd9327a4cdfbd71a11f9aa22e838fabf6 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 14 Jan 2022 12:18:55 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/database/multiple_databases.yml | 11 - .../components/deployments_service_table.vue | 61 ++ .../google_cloud/components/home.vue | 17 +- app/assets/javascripts/group.js | 7 +- .../container_registry/explorer/index.js | 37 +- .../components/details/npm_installation.vue | 6 +- .../components/list/package_list_row.vue | 20 +- .../package_registry/constants.js | 1 + .../package_registry/index.js | 58 +- .../package_registry/pages/details.js | 27 - .../details/app.vue => pages/details.vue} | 12 +- .../package_registry/router.js | 20 +- .../shared/components/registry_breadcrumb.vue | 11 +- .../packages_and_registries/shared/utils.js | 35 + .../pages/groups/packages/index.js | 8 + .../pages/groups/packages/index/index.js | 3 - .../pages/projects/packages/packages/index.js | 8 + .../projects/packages/packages/index/index.js | 3 - .../projects/packages/packages/show/index.js | 3 - .../admin_runners/admin_runners_app.vue | 41 +- .../javascripts/runner/admin_runners/index.js | 8 +- ...registration_token_reset_dropdown_item.vue | 30 +- .../components/stat/runner_online_stat.vue | 17 - .../runner/components/stat/runner_stats.vue | 49 ++ .../components/stat/runner_status_stat.vue | 65 ++ .../graphql/get_group_runners.query.graphql | 2 +- .../get_group_runners_count.query.graphql | 20 + .../group_runners/group_runners_app.vue | 52 +- app/controllers/groups/packages_controller.rb | 5 + .../projects/packages/packages_controller.rb | 3 +- .../mutations/issues/set_escalation_status.rb | 46 ++ app/graphql/resolvers/base_issues_resolver.rb | 3 +- .../escalation_status_enum.rb | 14 + app/graphql/types/issue_type.rb | 9 + app/graphql/types/mutation_type.rb | 1 + app/helpers/ci/runners_helper.rb | 5 +- app/models/alert_management/alert.rb | 13 - app/models/ci/build.rb | 4 +- app/models/ci/runner.rb | 11 +- .../incident_management/escalatable.rb | 11 + app/models/project.rb | 9 +- app/models/user.rb | 6 +- app/services/ci/create_pipeline_service.rb | 16 +- app/services/ci/update_build_queue_service.rb | 14 +- .../after_update_service.rb | 42 + app/services/issues/update_service.rb | 7 +- app/views/admin/deploy_keys/index.html.haml | 43 +- app/views/groups/packages/index.html.haml | 5 +- .../packages/packages/index.html.haml | 5 +- .../projects/packages/packages/show.html.haml | 9 - .../empty_states/_deploy_keys.html.haml | 9 - .../development/admin_deploy_keys_vue.yml | 8 - ...nging_to_parent_group_of_project_query.yml | 8 - .../ci_publish_pipeline_events.yml | 8 - ...mary_and_secondary_stores_for_sessions.yml | 8 - ..._primary_store_as_default_for_sessions.yml | 8 - config/metrics/schema.json | 2 +- config/routes/group.rb | 2 +- config/sidekiq_queues.yml | 2 + ...lculate_finding_signatures_as_completed.rb | 20 + db/schema_migrations/20211217174331 | 1 + doc/api/graphql/reference/index.md | 34 + doc/user/admin_area/license.md | 2 +- lib/gitlab/redis/multi_store.rb | 232 ------ lib/gitlab/redis/sessions.rb | 36 +- locale/gitlab.pot | 32 +- qa/qa/page/project/packages/show.rb | 2 +- .../groups/packages_controller_spec.rb | 27 + .../packages/packages_controller_spec.rb | 28 + spec/features/admin/admin_deploy_keys_spec.rb | 153 ++-- spec/features/admin/admin_runners_spec.rb | 18 +- spec/features/groups/packages_spec.rb | 3 + spec/features/projects/packages_spec.rb | 3 + spec/frontend/fixtures/runner.rb | 146 ++-- .../google_cloud/components/app_spec.js | 2 + .../deployments_service_table_spec.js | 40 + .../google_cloud/components/home_spec.js | 4 +- .../npm_installation_spec.js.snap | 2 +- .../details/npm_installation_spec.js | 10 +- .../package_list_row_spec.js.snap | 10 +- .../components/list/package_list_row_spec.js | 23 +- .../app_spec.js => pages/details_spec.js} | 30 +- .../registry_breadcrumb_spec.js.snap | 22 +- .../header/validation_segment_spec.js | 31 +- .../admin_runners/admin_runners_app_spec.js | 40 +- ...stration_token_reset_dropdown_item_spec.js | 34 +- .../stat/runner_online_stat_spec.js | 34 - .../components/stat/runner_stats_spec.js | 46 ++ .../stat/runner_status_stat_spec.js | 67 ++ .../group_runners/group_runners_app_spec.js | 46 +- spec/frontend/runner/mock_data.js | 2 + .../security_configuration/mock_data.js | 10 +- .../issues/set_escalation_status_spec.rb | 66 ++ .../escalation_status_enum_spec.rb | 25 + spec/graphql/types/issue_type_spec.rb | 47 +- spec/helpers/ci/runners_helper_spec.rb | 3 +- spec/lib/gitlab/redis/multi_store_spec.rb | 716 ------------------ spec/lib/gitlab/redis/sessions_spec.rb | 75 +- .../instrumentations/database_metric_spec.rb | 2 +- spec/lib/gitlab/usage_data_queries_spec.rb | 4 - ...te_finding_signatures_as_completed_spec.rb | 64 ++ spec/models/alert_management/alert_spec.rb | 33 - spec/models/ci/runner_spec.rb | 42 +- spec/models/user_spec.rb | 21 + spec/models/users_statistics_spec.rb | 2 +- .../issues/set_escalation_status_spec.rb | 82 ++ .../api/graphql/project/issues_spec.rb | 37 + .../ci/create_pipeline_service_spec.rb | 24 - .../after_update_service_spec.rb | 58 ++ spec/services/issues/update_service_spec.rb | 9 +- .../features/packages_shared_examples.rb | 4 +- ...lti_store_feature_flags_shared_examples.rb | 43 -- .../escalatable_shared_examples.rb | 33 + 113 files changed, 1729 insertions(+), 1819 deletions(-) create mode 100644 app/assets/javascripts/google_cloud/components/deployments_service_table.vue delete mode 100644 app/assets/javascripts/packages_and_registries/package_registry/pages/details.js rename app/assets/javascripts/packages_and_registries/package_registry/{components/details/app.vue => pages/details.vue} (97%) create mode 100644 app/assets/javascripts/pages/groups/packages/index.js delete mode 100644 app/assets/javascripts/pages/groups/packages/index/index.js create mode 100644 app/assets/javascripts/pages/projects/packages/packages/index.js delete mode 100644 app/assets/javascripts/pages/projects/packages/packages/index/index.js delete mode 100644 app/assets/javascripts/pages/projects/packages/packages/show/index.js delete mode 100644 app/assets/javascripts/runner/components/stat/runner_online_stat.vue create mode 100644 app/assets/javascripts/runner/components/stat/runner_stats.vue create mode 100644 app/assets/javascripts/runner/components/stat/runner_status_stat.vue create mode 100644 app/assets/javascripts/runner/graphql/get_group_runners_count.query.graphql create mode 100644 app/graphql/mutations/issues/set_escalation_status.rb create mode 100644 app/graphql/types/incident_management/escalation_status_enum.rb create mode 100644 app/services/incident_management/issuable_escalation_statuses/after_update_service.rb delete mode 100644 app/views/projects/packages/packages/show.html.haml delete mode 100644 app/views/shared/empty_states/_deploy_keys.html.haml delete mode 100644 config/feature_flags/development/admin_deploy_keys_vue.yml delete mode 100644 config/feature_flags/development/ci_decompose_belonging_to_parent_group_of_project_query.yml delete mode 100644 config/feature_flags/development/ci_publish_pipeline_events.yml delete mode 100644 config/feature_flags/development/use_primary_and_secondary_stores_for_sessions.yml delete mode 100644 config/feature_flags/development/use_primary_store_as_default_for_sessions.yml create mode 100644 db/post_migrate/20211217174331_mark_recalculate_finding_signatures_as_completed.rb create mode 100644 db/schema_migrations/20211217174331 delete mode 100644 lib/gitlab/redis/multi_store.rb create mode 100644 spec/controllers/groups/packages_controller_spec.rb create mode 100644 spec/controllers/projects/packages/packages_controller_spec.rb create mode 100644 spec/frontend/google_cloud/components/deployments_service_table_spec.js rename spec/frontend/packages_and_registries/package_registry/{components/details/app_spec.js => pages/details_spec.js} (95%) delete mode 100644 spec/frontend/runner/components/stat/runner_online_stat_spec.js create mode 100644 spec/frontend/runner/components/stat/runner_stats_spec.js create mode 100644 spec/frontend/runner/components/stat/runner_status_stat_spec.js create mode 100644 spec/graphql/mutations/issues/set_escalation_status_spec.rb create mode 100644 spec/graphql/types/incident_management/escalation_status_enum_spec.rb delete mode 100644 spec/lib/gitlab/redis/multi_store_spec.rb create mode 100644 spec/migrations/20211217174331_mark_recalculate_finding_signatures_as_completed_spec.rb create mode 100644 spec/requests/api/graphql/mutations/issues/set_escalation_status_spec.rb create mode 100644 spec/services/incident_management/issuable_escalation_statuses/after_update_service_spec.rb delete mode 100644 spec/support/shared_examples/lib/gitlab/redis/multi_store_feature_flags_shared_examples.rb diff --git a/.rubocop_todo/database/multiple_databases.yml b/.rubocop_todo/database/multiple_databases.yml index e555c2f912b..f2768276060 100644 --- a/.rubocop_todo/database/multiple_databases.yml +++ b/.rubocop_todo/database/multiple_databases.yml @@ -1,14 +1,12 @@ --- Database/MultipleDatabases: Exclude: - - ee/lib/ee/gitlab/database.rb - ee/lib/gitlab/geo/database_tasks.rb - ee/lib/gitlab/geo/geo_tasks.rb - ee/lib/gitlab/geo/health_check.rb - ee/lib/gitlab/geo/log_cursor/daemon.rb - ee/lib/pseudonymizer/dumper.rb - ee/lib/pseudonymizer/pager.rb - - ee/lib/system_check/geo/geo_database_configured_check.rb - ee/spec/lib/pseudonymizer/dumper_spec.rb - ee/spec/services/ee/merge_requests/update_service_spec.rb - lib/backup/database.rb @@ -21,14 +19,12 @@ Database/MultipleDatabases: - lib/gitlab/database/migrations/observers/query_log.rb - lib/gitlab/database/partitioning_migration_helpers/backfill_partitioned_table.rb - lib/gitlab/database.rb - - lib/gitlab/database/schema_cache_with_renamed_table.rb - lib/gitlab/database/with_lock_retries.rb - lib/gitlab/gitlab_import/importer.rb - lib/gitlab/health_checks/db_check.rb - lib/gitlab/import_export/base/relation_factory.rb - lib/gitlab/import_export/group/relation_tree_restorer.rb - lib/gitlab/legacy_github_import/importer.rb - - lib/gitlab/metrics/samplers/database_sampler.rb - lib/gitlab/seeder.rb - lib/gitlab/sherlock/query.rb - lib/system_check/orphans/repository_check.rb @@ -39,15 +35,8 @@ Database/MultipleDatabases: - spec/lib/gitlab/database_spec.rb - spec/lib/gitlab/metrics/subscribers/active_record_spec.rb - spec/lib/gitlab/profiler_spec.rb - - spec/lib/gitlab/usage_data_metrics_spec.rb - - spec/lib/gitlab/usage_data_queries_spec.rb - spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/constraints_spec.rb - spec/lib/gitlab/usage/metrics/names_suggestions/relation_parsers/joins_spec.rb - - spec/lib/gitlab/usage/metrics/instrumentations/database_metric_spec.rb - - spec/lib/gitlab/utils/usage_data_spec.rb - - spec/models/project_feature_usage_spec.rb - - spec/models/users_statistics_spec.rb - - spec/services/users/activity_service_spec.rb - spec/support/caching.rb - spec/support/gitlab/usage/metrics_instrumentation_shared_examples.rb - spec/support/helpers/database_connection_helpers.rb diff --git a/app/assets/javascripts/google_cloud/components/deployments_service_table.vue b/app/assets/javascripts/google_cloud/components/deployments_service_table.vue new file mode 100644 index 00000000000..7d27d7cf6b2 --- /dev/null +++ b/app/assets/javascripts/google_cloud/components/deployments_service_table.vue @@ -0,0 +1,61 @@ + + diff --git a/app/assets/javascripts/google_cloud/components/home.vue b/app/assets/javascripts/google_cloud/components/home.vue index 05f39de66ee..8ef110dcf22 100644 --- a/app/assets/javascripts/google_cloud/components/home.vue +++ b/app/assets/javascripts/google_cloud/components/home.vue @@ -1,11 +1,13 @@ @@ -35,7 +45,12 @@ export default { :empty-illustration-url="emptyIllustrationUrl" /> - + + + diff --git a/app/assets/javascripts/group.js b/app/assets/javascripts/group.js index f255f8a084c..b6a6720e7a1 100644 --- a/app/assets/javascripts/group.js +++ b/app/assets/javascripts/group.js @@ -13,11 +13,8 @@ export default class Group { this.updateGroupPathSlugHandler = this.updateGroupPathSlug.bind(this); this.groupNames.forEach((groupName) => { - if (groupName.value === '') { - groupName.addEventListener('keyup', this.updateHandler); - - groupName.addEventListener('keyup', this.updateGroupPathSlugHandler); - } + groupName.addEventListener('keyup', this.updateHandler); + groupName.addEventListener('keyup', this.updateGroupPathSlugHandler); }); this.groupPaths.forEach((groupPath) => { diff --git a/app/assets/javascripts/packages_and_registries/container_registry/explorer/index.js b/app/assets/javascripts/packages_and_registries/container_registry/explorer/index.js index e6c197a30dd..ca5bd8d6964 100644 --- a/app/assets/javascripts/packages_and_registries/container_registry/explorer/index.js +++ b/app/assets/javascripts/packages_and_registries/container_registry/explorer/index.js @@ -4,6 +4,7 @@ import { parseBoolean } from '~/lib/utils/common_utils'; import PerformancePlugin from '~/performance/vue_performance_plugin'; import Translate from '~/vue_shared/translate'; import RegistryBreadcrumb from '~/packages_and_registries/shared/components/registry_breadcrumb.vue'; +import { renderBreadcrumb } from '~/packages_and_registries/shared/utils'; import { apolloProvider } from './graphql/index'; import RegistryExplorer from './pages/index.vue'; import createRouter from './router'; @@ -84,38 +85,8 @@ export default () => { }, }); - const attachBreadcrumb = () => { - const breadCrumbEls = document.querySelectorAll('nav .js-breadcrumbs-list li'); - const breadCrumbEl = breadCrumbEls[breadCrumbEls.length - 1]; - const crumbs = [breadCrumbEl.querySelector('h2')]; - const nestedBreadcrumbEl = document.createElement('div'); - breadCrumbEl.replaceChild(nestedBreadcrumbEl, breadCrumbEl.querySelector('h2')); - return new Vue({ - el: nestedBreadcrumbEl, - router, - apolloProvider, - components: { - RegistryBreadcrumb, - }, - render(createElement) { - // FIXME(@tnir): this is a workaround until the MR gets merged: - // https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48115 - const parentEl = breadCrumbEl.parentElement.parentElement; - if (parentEl) { - parentEl.classList.remove('breadcrumbs-container'); - parentEl.classList.add('gl-display-flex'); - parentEl.classList.add('w-100'); - } - // End of FIXME(@tnir) - return createElement('registry-breadcrumb', { - class: breadCrumbEl.className, - props: { - crumbs, - }, - }); - }, - }); + return { + attachBreadcrumb: renderBreadcrumb(router, apolloProvider, RegistryBreadcrumb), + attachMainComponent, }; - - return { attachBreadcrumb, attachMainComponent }; }; diff --git a/app/assets/javascripts/packages_and_registries/package_registry/components/details/npm_installation.vue b/app/assets/javascripts/packages_and_registries/package_registry/components/details/npm_installation.vue index 95b09b25678..7479f748a56 100644 --- a/app/assets/javascripts/packages_and_registries/package_registry/components/details/npm_installation.vue +++ b/app/assets/javascripts/packages_and_registries/package_registry/components/details/npm_installation.vue @@ -26,7 +26,7 @@ export default { GlSprintf, GlFormRadioGroup, }, - inject: ['npmPath'], + inject: ['npmInstanceUrl'], props: { packageEntity: { type: Object, @@ -66,7 +66,9 @@ export default { npmSetupCommand(type, endpointType) { const scope = this.packageEntity.name.substring(0, this.packageEntity.name.indexOf('/')); const npmPathForEndpoint = - endpointType === INSTANCE_PACKAGE_ENDPOINT_TYPE ? this.npmPath : this.packageEntity.npmUrl; + endpointType === INSTANCE_PACKAGE_ENDPOINT_TYPE + ? this.npmInstanceUrl + : this.packageEntity.npmUrl; if (type === NPM_PACKAGE_MANAGER) { return `echo ${scope}:registry=${npmPathForEndpoint}/ >> .npmrc`; diff --git a/app/assets/javascripts/packages_and_registries/package_registry/components/list/package_list_row.vue b/app/assets/javascripts/packages_and_registries/package_registry/components/list/package_list_row.vue index 6fd96c0654f..6222c2e73d7 100644 --- a/app/assets/javascripts/packages_and_registries/package_registry/components/list/package_list_row.vue +++ b/app/assets/javascripts/packages_and_registries/package_registry/components/list/package_list_row.vue @@ -1,5 +1,5 @@