From 8b426b63d6044746a71a63b07a709bdc9a2ee832 Mon Sep 17 00:00:00 2001
From: Bob Van Landuyt <bob@vanlanduyt.co>
Date: Mon, 13 Nov 2017 18:13:03 +0100
Subject: [PATCH] Delete the fork network when removing the last membership

---
 app/models/fork_network_member.rb       | 10 ++++++++++
 spec/factories/fork_network_members.rb  |  8 ++++++++
 spec/models/fork_network_member_spec.rb | 18 ++++++++++++++++++
 3 files changed, 36 insertions(+)
 create mode 100644 spec/factories/fork_network_members.rb

diff --git a/app/models/fork_network_member.rb b/app/models/fork_network_member.rb
index 6a9b52a1ef8..eb9417dc34f 100644
--- a/app/models/fork_network_member.rb
+++ b/app/models/fork_network_member.rb
@@ -4,4 +4,14 @@ class ForkNetworkMember < ActiveRecord::Base
   belongs_to :forked_from_project, class_name: 'Project'
 
   validates :fork_network, :project, presence: true
+
+  after_destroy :cleanup_fork_network
+
+  private
+
+  def cleanup_fork_network
+    # Explicitly using `#count` makes sure we have the correct number if the
+    # relation was loaded in the fork_network.
+    fork_network.destroy if fork_network.fork_network_members.count == 0
+  end
 end
diff --git a/spec/factories/fork_network_members.rb b/spec/factories/fork_network_members.rb
new file mode 100644
index 00000000000..509c4e1fa1c
--- /dev/null
+++ b/spec/factories/fork_network_members.rb
@@ -0,0 +1,8 @@
+FactoryGirl.define do
+  factory :fork_network_member do
+    association :project
+    association :fork_network
+
+    forked_from_project { fork_network.root_project }
+  end
+end
diff --git a/spec/models/fork_network_member_spec.rb b/spec/models/fork_network_member_spec.rb
index 532ca1fca8c..25bf596fddc 100644
--- a/spec/models/fork_network_member_spec.rb
+++ b/spec/models/fork_network_member_spec.rb
@@ -5,4 +5,22 @@ describe ForkNetworkMember do
     it { is_expected.to validate_presence_of(:project) }
     it { is_expected.to validate_presence_of(:fork_network) }
   end
+
+  describe 'destroying a ForkNetworkMember' do
+    let(:fork_network_member) { create(:fork_network_member) }
+    let(:fork_network) { fork_network_member.fork_network }
+
+    it 'removes the fork network if it was the last member' do
+      fork_network.fork_network_members.destroy_all
+
+      expect(ForkNetwork.count).to eq(0)
+    end
+
+    it 'does not destroy the fork network if there are members left' do
+      fork_network_member.destroy!
+
+      # The root of the fork network is left
+      expect(ForkNetwork.count).to eq(1)
+    end
+  end
 end