kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Resolve "Label picker: Line break on long label titles"

This commit is contained in:
Ammar Alakkad 2019-07-17 14:18:12 +00:00 committed by Kushal Pandya
parent c11eb0c3a4
commit 8ba48310af
4 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/labels_select.js
View File

@ -311,7 +311,8 @@ export default class LabelsSelect {
// We need to identify which items are actually labels
if (label.id) {
selectedClass.push('label-item');
const selectedLayoutClasses = ['d-flex', 'flex-row', 'text-break-word'];
selectedClass.push('label-item', ...selectedLayoutClasses);
linkEl.dataset.labelId = label.id;
}

4
app/assets/stylesheets/pages/labels.scss
View File

@ -30,6 +30,10 @@
.dropdown-content {
max-height: 135px;
}
.dropdown-label-box {
flex: 0 0 auto;
}
}
.dropdown-new-label {

5
changelogs/unreleased/48771-label-picker-line-break-on-long-label-titles.yml Normal file
View File

@ -0,0 +1,5 @@
---
title: 'Resolve Label picker: Line break on long label titles'
merge_request: 30610
author:
type: fixed

2
spec/features/issues/bulk_assignment_labels_spec.rb
View File

@ -381,7 +381,7 @@ describe 'Issues > Labels bulk assignment' do
if unmark
items.map do |item|
# Make sure we are unmarking the item no matter the state it has currently
click_link item until find('a', text: item)[:class] == 'label-item'
click_link item until find('a', text: item)[:class].include? 'label-item'
end
end
end