From 8bac8f55ba93bb03f7391b939dc6644e67fe5216 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 7 Jan 2022 18:16:06 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITALY_SERVER_VERSION | 2 +- .../design_notes/design_discussion.vue | 85 +++-- .../design_notes/design_note_signed_out.vue | 50 +++ .../components/design_presentation.vue | 4 +- .../components/design_sidebar.vue | 24 +- .../javascripts/design_management/index.js | 4 +- .../javascripts/gitlab_version_check.js | 20 ++ .../issues/show/components/app.vue | 8 +- .../issues/show/components/fields/type.vue | 10 +- .../issues/show/components/header_actions.vue | 4 +- .../javascripts/issues/show/constants.js | 26 +- app/assets/javascripts/issues/show/index.js | 6 +- app/assets/javascripts/lib/utils/constants.js | 1 - .../javascripts/pages/help/index/index.js | 5 +- .../shared/wikis/components/wiki_form.vue | 4 +- app/assets/javascripts/version_check_image.js | 6 - .../components/gitlab_version_check.vue | 67 ++++ .../types/packages/package_details_type.rb | 43 +++ app/helpers/packages_helper.rb | 2 + app/helpers/version_check_helper.rb | 9 +- app/views/admin/dashboard/index.html.haml | 4 +- app/views/admin/labels/_form.html.haml | 31 -- app/views/admin/labels/edit.html.haml | 2 +- app/views/admin/labels/new.html.haml | 2 +- app/views/help/index.html.haml | 15 +- .../issues/_design_management.html.haml | 6 +- app/views/shared/issuable/_form.html.haml | 4 +- app/views/shared/labels/_form.html.haml | 14 +- app/views/shared/web_hooks/_form.html.haml | 32 +- app/views/shared/web_hooks/_index.html.haml | 2 +- doc/api/graphql/reference/index.md | 8 + doc/development/fe_guide/style/javascript.md | 18 - doc/user/project/integrations/webhooks.md | 11 +- lib/tasks/gitlab/gitaly.rake | 38 --- lib/version_check.rb | 8 - locale/gitlab.pot | 114 ++++--- qa/qa/runtime/env.rb | 1 + qa/qa/scenario/bootable.rb | 7 + qa/qa/scenario/shared_attributes.rb | 1 + qa/qa/scenario/template.rb | 3 +- qa/qa/specs/runner.rb | 10 +- .../scenario/test/integration/github_spec.rb | 2 +- qa/spec/spec_helper.rb | 2 +- qa/spec/specs/runner_spec.rb | 26 +- scripts/gitaly-test-build | 2 - scripts/gitaly-test-spawn | 13 +- spec/features/admin/admin_labels_spec.rb | 8 +- spec/features/help_pages_spec.rb | 17 +- .../graphql/packages/package_details.json | 24 ++ .../design_note_signed_out_spec.js.snap | 41 +++ .../design_notes/design_discussion_spec.js | 50 +++ .../design_note_signed_out_spec.js | 36 ++ .../components/design_presentation_spec.js | 25 ++ .../components/design_sidebar_spec.js | 51 +++ .../design/__snapshots__/index_spec.js.snap | 27 +- .../design_management/pages/index_spec.js | 8 + .../show/components/fields/type_spec.js | 18 +- .../show/components/header_actions_spec.js | 10 +- .../shared/wikis/components/wiki_form_spec.js | 215 +++++------- spec/frontend/version_check_image_spec.js | 42 --- .../components/gitlab_version_check_spec.js | 77 +++++ .../packages/package_details_type_spec.rb | 5 +- spec/helpers/version_check_helper_spec.rb | 47 +-- spec/lib/version_check_spec.rb | 6 - .../api/graphql/packages/package_spec.rb | 323 ++++++++++-------- spec/spec_helper.rb | 5 + spec/support/helpers/gitaly_setup.rb | 131 ++++++- spec/support/helpers/test_env.rb | 117 +------ spec/support/praefect.rb | 4 +- .../admin/dashboard/index.html.haml_spec.rb | 13 +- spec/views/help/index.html.haml_spec.rb | 1 - 71 files changed, 1276 insertions(+), 781 deletions(-) create mode 100644 app/assets/javascripts/design_management/components/design_notes/design_note_signed_out.vue create mode 100644 app/assets/javascripts/gitlab_version_check.js delete mode 100644 app/assets/javascripts/version_check_image.js create mode 100644 app/assets/javascripts/vue_shared/components/gitlab_version_check.vue delete mode 100644 app/views/admin/labels/_form.html.haml create mode 100644 spec/frontend/design_management/components/design_notes/__snapshots__/design_note_signed_out_spec.js.snap create mode 100644 spec/frontend/design_management/components/design_notes/design_note_signed_out_spec.js delete mode 100644 spec/frontend/version_check_image_spec.js create mode 100644 spec/frontend/vue_shared/components/gitlab_version_check_spec.js diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 440065b3a3a..d8dda2e23cc 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -641e24107a6f4f8593b87ed55c3aa7cd76010963 +3627c14a64ce48446e8a67299c3161ff7290d1ad diff --git a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue index 10976202d06..7fefbab977d 100644 --- a/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue +++ b/app/assets/javascripts/design_management/components/design_notes/design_discussion.vue @@ -7,6 +7,7 @@ import ReplyPlaceholder from '~/notes/components/discussion_reply_placeholder.vu import { updateGlobalTodoCount } from '~/vue_shared/components/sidebar/todo_toggle/utils'; import TimeAgoTooltip from '~/vue_shared/components/time_ago_tooltip.vue'; import DesignNotePin from '~/vue_shared/components/design_management/design_note_pin.vue'; +import { isLoggedIn } from '~/lib/utils/common_utils'; import { ACTIVE_DISCUSSION_SOURCE_TYPES } from '../../constants'; import createNoteMutation from '../../graphql/mutations/create_note.mutation.graphql'; import toggleResolveDiscussionMutation from '../../graphql/mutations/toggle_resolve_discussion.mutation.graphql'; @@ -17,6 +18,7 @@ import { hasErrors } from '../../utils/cache_update'; import { extractDesign } from '../../utils/design_management_utils'; import { ADD_DISCUSSION_COMMENT_ERROR } from '../../utils/error_messages'; import DesignNote from './design_note.vue'; +import DesignNoteSignedOut from './design_note_signed_out.vue'; import DesignReplyForm from './design_reply_form.vue'; import ToggleRepliesWidget from './toggle_replies_widget.vue'; @@ -24,6 +26,7 @@ export default { components: { ApolloMutation, DesignNote, + DesignNoteSignedOut, ReplyPlaceholder, DesignReplyForm, GlIcon, @@ -55,6 +58,14 @@ export default { required: false, default: '', }, + registerPath: { + type: String, + required: true, + }, + signInPath: { + type: String, + required: true, + }, resolvedDiscussionsExpanded: { type: Boolean, required: true, @@ -93,6 +104,7 @@ export default { isResolving: false, shouldChangeResolvedStatus: false, areRepliesCollapsed: this.discussion.resolved, + isLoggedIn: isLoggedIn(), }; }, computed: { @@ -226,7 +238,7 @@ export default { :class="{ 'gl-bg-blue-50': isDiscussionActive }" @error="$emit('update-note-error', $event)" > -