Rescue OpenSSL::SSL::SSLError in JiraService and IssueTrackerService
Add OpenSSL::SSL::SSLError to rescue in JiraService & IssueTrackerService. This will prevent an exception in production and instead display a message to the user.
This commit is contained in:
parent
39baadbd01
commit
8c07184250
3 changed files with 6 additions and 2 deletions
|
@ -76,7 +76,7 @@ class IssueTrackerService < Service
|
||||||
message = "#{self.type} received response #{response.code} when attempting to connect to #{self.project_url}"
|
message = "#{self.type} received response #{response.code} when attempting to connect to #{self.project_url}"
|
||||||
result = true
|
result = true
|
||||||
end
|
end
|
||||||
rescue HTTParty::Error, Timeout::Error, SocketError, Errno::ECONNRESET, Errno::ECONNREFUSED => error
|
rescue HTTParty::Error, Timeout::Error, SocketError, Errno::ECONNRESET, Errno::ECONNREFUSED, OpenSSL::SSL::SSLError => error
|
||||||
message = "#{self.type} had an error when trying to connect to #{self.project_url}: #{error.message}"
|
message = "#{self.type} had an error when trying to connect to #{self.project_url}: #{error.message}"
|
||||||
end
|
end
|
||||||
Rails.logger.info(message)
|
Rails.logger.info(message)
|
||||||
|
|
|
@ -294,7 +294,7 @@ class JiraService < IssueTrackerService
|
||||||
def jira_request
|
def jira_request
|
||||||
yield
|
yield
|
||||||
|
|
||||||
rescue Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, Errno::ECONNREFUSED, URI::InvalidURIError, JIRA::HTTPError => e
|
rescue Timeout::Error, Errno::EINVAL, Errno::ECONNRESET, Errno::ECONNREFUSED, URI::InvalidURIError, JIRA::HTTPError, OpenSSL::SSL::SSLError => e
|
||||||
Rails.logger.info "#{self.class.name} Send message ERROR: #{url} - #{e.message}"
|
Rails.logger.info "#{self.class.name} Send message ERROR: #{url} - #{e.message}"
|
||||||
nil
|
nil
|
||||||
end
|
end
|
||||||
|
|
4
changelogs/unreleased/mrchrisw-catch-openssl.yml
Normal file
4
changelogs/unreleased/mrchrisw-catch-openssl.yml
Normal file
|
@ -0,0 +1,4 @@
|
||||||
|
---
|
||||||
|
title: Rescue OpenSSL::SSL::SSLError in JiraService & IssueTrackerService
|
||||||
|
merge_request:
|
||||||
|
author:
|
Loading…
Reference in a new issue