Do not let NGINX buffer Git HTTP requests
Before this change NGINX would convert a chunked HTTP POST (e.g. git push) into a HTTP 1.0 single large POST. This creates an unnecessary delay, and it creates unnecessary memory pressure on gitlab-git-http-server. For the response ('proxy_buffering') I am less sure that NGINX 's buffering behavior is harmful, but it still makes more sense to me not to interfere with gitlab-git-http-server (and the Golang net/http server).
This commit is contained in:
parent
0fbd6244ec
commit
8d59b1ac45
|
@ -124,6 +124,13 @@ server {
|
|||
proxy_connect_timeout 300;
|
||||
proxy_redirect off;
|
||||
|
||||
# Do not buffer Git HTTP responses
|
||||
proxy_buffering off;
|
||||
|
||||
# Pass chunked request bodies to gitlab-git-http-server as-is
|
||||
proxy_request_buffering off;
|
||||
proxy_http_version 1.1;
|
||||
|
||||
proxy_set_header Host $http_host;
|
||||
proxy_set_header X-Real-IP $remote_addr;
|
||||
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
|
||||
|
|
|
@ -171,6 +171,13 @@ server {
|
|||
proxy_connect_timeout 300;
|
||||
proxy_redirect off;
|
||||
|
||||
# Do not buffer Git HTTP responses
|
||||
proxy_buffering off;
|
||||
|
||||
# Pass chunked request bodies to gitlab-git-http-server as-is
|
||||
proxy_request_buffering off;
|
||||
proxy_http_version 1.1;
|
||||
|
||||
proxy_set_header Host $http_host;
|
||||
proxy_set_header X-Real-IP $remote_addr;
|
||||
proxy_set_header X-Forwarded-Ssl on;
|
||||
|
|
Loading…
Reference in New Issue