Update version column after application is updated

Note: updating version column after :updating is not ideal in the
updating -> update_erroed case. This will mean that the application now
records the version as the version that failed to upgrade, not the
version that it is currently on.
This commit is contained in:
Thong Kuah 2019-01-31 12:21:03 +13:00
parent bc5a2ed8c6
commit 8ef1128f67
2 changed files with 14 additions and 0 deletions

View file

@ -10,6 +10,10 @@ module Clusters
after_transition any => [:installing] do |application|
application.update(version: application.class.const_get(:VERSION))
end
before_transition any => :updated do |application|
application.version = application.class.const_get(:VERSION)
end
end
end
end

View file

@ -78,6 +78,16 @@ shared_examples 'cluster application status specs' do |application_name|
expect(subject.cluster.application_helm.version).to eq(Gitlab::Kubernetes::Helm::HELM_VERSION)
end
it 'updates the version for the application' do
subject.update!(version: '0.0.0')
subject.make_updated!
subject.reload
expect(subject.version).to eq(subject.class.const_get(:VERSION))
end
end
describe '#make_errored' do