kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Set modal header/title size to match design spec

Browse source 
Set line height of title to 24px as given in spec
Given 16px padding, total header height is now 56px as given in spec

Use variables for padding/margin for close button (bootstrap now >4.2)
This commit is contained in:
mfluharty 2019-07-05 12:08:20 -06:00
parent 01fea14f51
commit 902641cc9a
No known key found for this signature in database
GPG key ID: 6FDA03A308D239E8
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
app/assets/stylesheets/framework/modal.scss
View file

@ -19,14 +19,14 @@
}
}
// leave enough space for the close icon
.modal-title {
line-height: $gl-line-height-24;
// leave enough space for the close icon
&.mw-100,
&.w-100 {
// after upgrading to Bootstrap 4.2 we can use $modal-header-padding-x here
// https://github.com/twbs/bootstrap/pull/26976
margin-right: -28px;
padding-right: 28px;
margin-right: -$modal-header-padding-x;
padding-right: $modal-header-padding-x;
}
}
}