From 90fc9237c20cbb20a528de1a2f294d35b479bd44 Mon Sep 17 00:00:00 2001
From: Filipa Lacerda <filipa@gitlab.com>
Date: Fri, 24 Mar 2017 12:31:48 +0000
Subject: [PATCH] Updates polling function to guarantee we won't make a request
 while polling

---
 .../vue_pipelines_index/pipelines.js          | 23 +++++++++++++------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/vue_pipelines_index/pipelines.js b/app/assets/javascripts/vue_pipelines_index/pipelines.js
index 7be453d38fb..b630ee094ee 100644
--- a/app/assets/javascripts/vue_pipelines_index/pipelines.js
+++ b/app/assets/javascripts/vue_pipelines_index/pipelines.js
@@ -49,6 +49,7 @@ export default {
       pagenum: 1,
       isLoading: false,
       hasError: false,
+      isMakingRequest: false,
     };
   },
 
@@ -136,6 +137,7 @@ export default {
       data: { page: pageNumber, scope },
       successCallback: this.successCallback,
       errorCallback: this.errorCallback,
+      notificationCallback: this.setIsMakingRequest,
     });
 
     if (!Visibility.hidden()) {
@@ -143,8 +145,8 @@ export default {
       poll.makeRequest();
     }
 
-    Visibility.change((e, state) => {
-      if (state === 'visible') {
+    Visibility.change(() => {
+      if (!Visibility.hidden()) {
         poll.restart();
       } else {
         poll.stop();
@@ -155,7 +157,7 @@ export default {
   },
 
   beforeUpdate() {
-    if (this.state.pipelines.length && this.$children) {
+    if (this.state.pipelines.length && this.$children && !this.isMakingRequest) {
       this.store.startTimeAgoLoops.call(this, Vue);
     }
   },
@@ -181,10 +183,13 @@ export default {
       const pageNumber = gl.utils.getParameterByName('page') || this.pagenum;
       const scope = gl.utils.getParameterByName('scope') || this.apiScope;
 
-      this.isLoading = true;
-      return this.service.getPipelines({ scope, page: pageNumber })
-        .then(response => this.successCallback(response))
-        .catch(() => this.errorCallback());
+      if (!this.isMakingRequest) {
+        this.isLoading = true;
+
+        this.service.getPipelines({ scope, page: pageNumber })
+          .then(response => this.successCallback(response))
+          .catch(() => this.errorCallback());
+      }
     },
 
     successCallback(resp) {
@@ -204,6 +209,10 @@ export default {
       this.hasError = true;
       this.isLoading = false;
     },
+
+    setIsMakingRequest(isMakingRequest) {
+      this.isMakingRequest = isMakingRequest;
+    },
   },
 
   template: `