kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Reduce intermittent spec failures by making VueJS resource interceptor

Browse source 
decrement outstanding resource counts when HTTP response is received

Before the count would be reduced 500 ms after a DOM update tick, which could
cause race conditions since the `DatabaseCleaner` could run in the middle of
a Rails controller handling the response.

Partial fix to #21197 and other intermittent spec failures.
This commit is contained in:
Stan Hu 2016-09-06 07:41:32 -04:00
parent 2aaab34b67
commit 924141fbfa
1 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/assets/javascripts/boards/vue_resource_interceptor.js.es6
View file

@ -1,10 +1,7 @@
Vue.http.interceptors.push((request, next) => {
Vue.http.interceptors.push((request, next) => {
Vue.activeResources = Vue.activeResources ? Vue.activeResources + 1 : 1;
Vue.nextTick(() => {
setTimeout(() => {
Vue.activeResources--;
}, 500);
next(function (response) {
Vue.activeResources--;
});
next();
});