From ec38d6290c26b6c7ad21d9436627d18402cd3f95 Mon Sep 17 00:00:00 2001 From: Axilleas Pipinellis Date: Mon, 17 Jun 2013 11:44:33 +0300 Subject: [PATCH 1/3] Removal of gitlab.socket should be in stop function too. Fix #4313 --- lib/support/init.d/gitlab | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/support/init.d/gitlab b/lib/support/init.d/gitlab index bb0151d9335..2db37ed1c7d 100644 --- a/lib/support/init.d/gitlab +++ b/lib/support/init.d/gitlab @@ -20,6 +20,7 @@ APP_USER="git" DAEMON_OPTS="-C $APP_ROOT/config/puma.rb" PID_PATH="$APP_ROOT/tmp/pids" SOCKET_PATH="$APP_ROOT/tmp/sockets" +SOCKET_FILE="$SOCKET_PATH/gitlab.socket" WEB_SERVER_PID="$PID_PATH/puma.pid" SIDEKIQ_PID="$PID_PATH/sidekiq.pid" STOP_SIDEKIQ="RAILS_ENV=production bundle exec rake sidekiq:stop" @@ -51,7 +52,7 @@ start() { exit 1 else if [ `whoami` = root ]; then - execute "rm -f $SOCKET_PATH/gitlab.socket" + ! [ -e $SOCKET_FILE ] || execute "rm $SOCKET_FILE" execute "RAILS_ENV=production bundle exec puma $DAEMON_OPTS" execute "mkdir -p $PID_PATH && $START_SIDEKIQ > /dev/null 2>&1 &" echo "$DESC started" @@ -65,12 +66,13 @@ stop() { if [ "$PID" -ne 0 -a "$STATUS" -ne 0 ]; then ## Program is running, stop it. kill -QUIT `cat $WEB_SERVER_PID` + ! [ -e $SOCKET_FILE ] || execute "rm $SOCKET_FILE" execute "mkdir -p $PID_PATH && $STOP_SIDEKIQ > /dev/null 2>&1 &" rm "$WEB_SERVER_PID" >> /dev/null echo "$DESC stopped" else ## Program is not running, exit with error. - echo "Error! $DESC not started!" + echo "Error! $DESC is not started!" exit 1 fi } @@ -81,7 +83,7 @@ restart() { if [ "$PID" -ne 0 -a "$STATUS" -ne 0 ]; then echo "Restarting $DESC..." kill -USR2 `cat $WEB_SERVER_PID` - execute "mkdir -p $PID_PATH && $STOP_SIDEKIQ > /dev/null 2>&1 &" + execute "mkdir -p $PID_PATH && $STOP_SIDEKIQ > /dev/null 2>&1" if [ `whoami` = root ]; then execute "mkdir -p $PID_PATH && $START_SIDEKIQ > /dev/null 2>&1 &" fi From e68b0cac3df483574f7fee454e71734709f22a93 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Fri, 12 Jul 2013 16:11:45 +0300 Subject: [PATCH 2/3] Update CHANGELOG --- CHANGELOG | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG b/CHANGELOG index be488aaea5b..c614443b542 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -7,6 +7,11 @@ v 5.4.0 - Misspelling fixes - Added support of unicorn and fog gems - Added client list to API doc + - Fix PostgreSQL database restoration problem + - Increase snippet content column size + - allow project import via git:// url + - Show participants on issues, including mentions + - Notify mentioned users with email v 5.3.0 - Refactored services From f1fc1ae6f10d122c6b852edc0fdf11f38a2d7e30 Mon Sep 17 00:00:00 2001 From: Dmitriy Zaporozhets Date: Fri, 12 Jul 2013 16:12:23 +0300 Subject: [PATCH 3/3] 5.4.0 is rc1 --- VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VERSION b/VERSION index c5e18371adf..6b372fac825 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -5.4.0.pre +5.4.0.rc1