kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fixed labels icon being hidden in collapsed issuable sidebar

Browse source
This commit is contained in:
Phil Hughes 2017-03-28 16:33:49 +00:00 committed by Filipa Lacerda
parent 1bec2fb3b8
commit 930069052b
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/views/shared/issuable/_sidebar.html.haml
View file

@ -121,7 +121,7 @@
- selected_labels = issuable.labels
.block.labels
.sidebar-collapsed-icon.js-sidebar-labels-tooltip{ title: issuable_labels_tooltip(issuable.labels_array), data: { placement: "left", container: "body" } }
= icon('tags', class: 'hidden', 'aria-hidden': 'true')
= icon('tags', 'aria-hidden': 'true')
%span
= selected_labels.size
.title.hide-collapsed

6
spec/javascripts/right_sidebar_spec.js
View file

@ -78,5 +78,11 @@ import '~/right_sidebar';
expect(todoToggleSpy.calls.count()).toEqual(1);
});
it('should not hide collapsed icons', () => {
[].forEach.call(document.querySelectorAll('.sidebar-collapsed-icon'), (el) => {
expect(el.querySelector('.fa, svg').classList.contains('hidden')).toBeFalsy();
});
});
});
}).call(window);