Avoid using the same name between methods and variables

This commit is contained in:
Lin Jen-Shin 2016-03-23 20:05:31 +08:00
parent 7124e5a44c
commit 9374b7eb0b
1 changed files with 7 additions and 7 deletions

View File

@ -45,12 +45,12 @@ module Gitlab
note = create_note(reply) note = create_note(reply)
unless note.persisted? unless note.persisted?
message = "The comment could not be created for the following reasons:" msg = "The comment could not be created for the following reasons:"
note.errors.full_messages.each do |error| note.errors.full_messages.each do |error|
message << "\n\n- #{error}" msg << "\n\n- #{error}"
end end
raise InvalidNoteError, message raise InvalidNoteError, msg
end end
end end
@ -63,13 +63,13 @@ module Gitlab
end end
def reply_key def reply_key
reply_key = nil key = nil
message.to.each do |address| message.to.each do |address|
reply_key = Gitlab::IncomingEmail.key_from_address(address) key = Gitlab::IncomingEmail.key_from_address(address)
break if reply_key break if key
end end
reply_key key
end end
def sent_notification def sent_notification