From 942229d2b424e0c505aa676cbd8e173e4c99d83a Mon Sep 17 00:00:00 2001
From: GitLab Bot <gitlab-bot@gitlab.com>
Date: Mon, 25 Oct 2021 18:12:16 +0000
Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master

---
 app/assets/javascripts/editor/schema/ci.json  |   4 +-
 .../ide/components/jobs/detail.vue            |   5 +-
 .../jobs/components/table/index.js            |   7 +-
 .../registration/registration_dropdown.vue    |   1 +
 .../javascripts/runner/group_runners/index.js |   2 +
 .../set_status_modal_wrapper.vue              |   2 +-
 app/assets/javascripts/terraform/index.js     |   1 +
 .../runner_instructions/constants.js          |   2 +
 .../runner_instructions_modal.vue             |  21 +-
 app/graphql/types/ci/runner_setup_type.rb     |   2 +-
 app/models/legacy_diff_note.rb                |   6 +-
 app/models/protected_branch.rb                |   7 +-
 app/models/users/credit_card_validation.rb    |   1 +
 .../upsert_credit_card_validation_service.rb  |   1 +
 app/views/profiles/show.html.haml             |   2 +-
 .../show_relevant_approval_rule_approvers.yml |   2 +-
 ...ip_legacy_diff_note_callback_on_import.yml |   8 +
 .../usage_data_instrumentation.yml            |   8 +
 ...network_to_user_credit_card_validations.rb |   9 +
 ...network_on_user_credit_card_validations.rb |  13 ++
 ...network_on_user_credit_card_validations.rb |  17 ++
 db/schema_migrations/20211013080714           |   1 +
 db/schema_migrations/20211013080715           |   1 +
 db/schema_migrations/20211013080716           |   1 +
 db/structure.sql                              |   4 +
 doc/.vale/gitlab/Acronyms.yml                 |   1 +
 .../geo/setup/external_database.md            |   6 +-
 .../operations/fast_ssh_key_lookup.md         |  38 ++++
 .../reference_architectures/10k_users.md      |   4 +-
 .../reference_architectures/25k_users.md      |   4 +-
 .../reference_architectures/2k_users.md       |   4 +-
 .../reference_architectures/3k_users.md       |   6 +-
 .../reference_architectures/50k_users.md      |   4 +-
 doc/api/graphql/reference/index.md            |   8 +-
 doc/ci/cloud_deployment/index.md              |   2 +-
 doc/ci/services/postgres.md                   |   6 +-
 .../database/loose_foreign_keys.md            | 182 ++++++++++++++++++
 .../documentation/styleguide/word_list.md     |   4 +-
 doc/install/aws/gitlab_hybrid_on_aws.md       |   6 +-
 doc/install/aws/manual_install_aws.md         |   2 +-
 .../admin_area/merge_requests_approvals.md    |   2 +-
 .../settings/account_and_limit_settings.md    |   6 +-
 doc/user/admin_area/settings/index.md         |  10 +-
 .../settings/instance_template_repository.md  |   2 +-
 doc/user/discussions/index.md                 |   4 +-
 ...asic_search.png => basic_search_v14_4.png} | Bin
 doc/user/search/img/issues_mrs_shortcut.png   | Bin 4523 -> 0 bytes
 .../search/img/issues_mrs_shortcut_v14_4.png  | Bin 0 -> 6741 bytes
 doc/user/search/index.md                      |   4 +-
 lib/api/users.rb                              |   1 +
 lib/gitlab/usage/metric.rb                    |   4 +
 .../metrics/names_suggestions/generator.rb    |   4 +
 lib/gitlab/usage_data.rb                      |  45 +++--
 lib/gitlab/usage_data_metrics.rb              |  12 +-
 lib/gitlab/usage_data_non_sql_metrics.rb      |   7 +-
 lib/gitlab/usage_data_queries.rb              |   7 +-
 lib/gitlab/utils/usage_data.rb                |   5 +
 locale/gitlab.pot                             |  55 ++++--
 .../runner_instructions_modal_spec.js         |  32 ++-
 spec/lib/gitlab/usage/metric_spec.rb          |   6 +
 .../names_suggestions/generator_spec.rb       |  28 ++-
 spec/lib/gitlab/usage_data_metrics_spec.rb    |  12 ++
 spec/lib/gitlab/usage_data_spec.rb            | 173 +++++++++++++++--
 spec/lib/gitlab/utils/usage_data_spec.rb      |  22 ++-
 spec/models/legacy_diff_note_spec.rb          |  54 ++++++
 spec/models/protected_branch_spec.rb          |  17 +-
 .../users/credit_card_validation_spec.rb      |   1 +
 spec/requests/api/users_spec.rb               |   2 +
 ...ert_credit_card_validation_service_spec.rb |  13 +-
 69 files changed, 799 insertions(+), 134 deletions(-)
 create mode 100644 config/feature_flags/development/skip_legacy_diff_note_callback_on_import.yml
 create mode 100644 config/feature_flags/development/usage_data_instrumentation.yml
 create mode 100644 db/migrate/20211013080714_add_network_to_user_credit_card_validations.rb
 create mode 100644 db/migrate/20211013080715_limit_network_on_user_credit_card_validations.rb
 create mode 100644 db/migrate/20211013080716_index_include_network_on_user_credit_card_validations.rb
 create mode 100644 db/schema_migrations/20211013080714
 create mode 100644 db/schema_migrations/20211013080715
 create mode 100644 db/schema_migrations/20211013080716
 create mode 100644 doc/development/database/loose_foreign_keys.md
 rename doc/user/search/img/{basic_search.png => basic_search_v14_4.png} (100%)
 delete mode 100644 doc/user/search/img/issues_mrs_shortcut.png
 create mode 100644 doc/user/search/img/issues_mrs_shortcut_v14_4.png

diff --git a/app/assets/javascripts/editor/schema/ci.json b/app/assets/javascripts/editor/schema/ci.json
index 0052bc00406..bce823f1106 100644
--- a/app/assets/javascripts/editor/schema/ci.json
+++ b/app/assets/javascripts/editor/schema/ci.json
@@ -555,7 +555,7 @@
     },
     "start_in": {
       "type": "string",
-      "description": "Used in conjunction with 'when: delayed' to set how long to delay before starting a job.",
+      "description": "Used in conjunction with 'when: delayed' to set how long to delay before starting a job. e.g. '5', 5 seconds, 30 minutes, 1 week, etc. Read more: https://docs.gitlab.com/ee/ci/jobs/job_control.html#run-a-job-after-a-delay",
       "minLength": 1
     },
     "allow_failure": {
@@ -939,7 +939,7 @@
         "stage": {
           "type": "string",
           "description": "Define what stage the job will run in.",
-          "default": "test"
+          "minLength": 1
         },
         "only": {
           "$ref": "#/definitions/filter",
diff --git a/app/assets/javascripts/ide/components/jobs/detail.vue b/app/assets/javascripts/ide/components/jobs/detail.vue
index 96cb4f3d495..55ae5501cdb 100644
--- a/app/assets/javascripts/ide/components/jobs/detail.vue
+++ b/app/assets/javascripts/ide/components/jobs/detail.vue
@@ -1,5 +1,5 @@
 <script>
-import { GlTooltipDirective, GlButton, GlIcon } from '@gitlab/ui';
+import { GlTooltipDirective, GlButton, GlIcon, GlSafeHtmlDirective } from '@gitlab/ui';
 import { throttle } from 'lodash';
 import { mapActions, mapState } from 'vuex';
 import { __ } from '../../../locale';
@@ -14,6 +14,7 @@ const scrollPositions = {
 export default {
   directives: {
     GlTooltip: GlTooltipDirective,
+    SafeHtml: GlSafeHtmlDirective,
   },
   components: {
     GlButton,
@@ -100,8 +101,8 @@ export default {
     <pre ref="buildJobLog" class="build-log mb-0 h-100 mr-3" @scroll="scrollBuildLog">
       <code
         v-show="!detailJob.isLoading"
+        v-safe-html="jobOutput"
         class="bash"
-        v-html="jobOutput /* eslint-disable-line vue/no-v-html */"
       >
       </code>
       <div
diff --git a/app/assets/javascripts/jobs/components/table/index.js b/app/assets/javascripts/jobs/components/table/index.js
index f24daf90815..cec871ddbb4 100644
--- a/app/assets/javascripts/jobs/components/table/index.js
+++ b/app/assets/javascripts/jobs/components/table/index.js
@@ -9,7 +9,12 @@ Vue.use(VueApollo);
 Vue.use(GlToast);
 
 const apolloProvider = new VueApollo({
-  defaultClient: createDefaultClient(),
+  defaultClient: createDefaultClient(
+    {},
+    {
+      assumeImmutableResults: true,
+    },
+  ),
 });
 
 export default (containerId = 'js-jobs-table') => {
diff --git a/app/assets/javascripts/runner/components/registration/registration_dropdown.vue b/app/assets/javascripts/runner/components/registration/registration_dropdown.vue
index 9a4ea0621ca..fd5a7d9d572 100644
--- a/app/assets/javascripts/runner/components/registration/registration_dropdown.vue
+++ b/app/assets/javascripts/runner/components/registration/registration_dropdown.vue
@@ -88,6 +88,7 @@ export default {
       <runner-instructions-modal
         v-if="instructionsModalOpened"
         ref="runnerInstructionsModal"
+        :registration-token="registrationToken"
         data-testid="runner-instructions-modal"
       />
     </gl-dropdown-item>
diff --git a/app/assets/javascripts/runner/group_runners/index.js b/app/assets/javascripts/runner/group_runners/index.js
index 9545764c68d..959e8a4fedd 100644
--- a/app/assets/javascripts/runner/group_runners/index.js
+++ b/app/assets/javascripts/runner/group_runners/index.js
@@ -1,8 +1,10 @@
+import { GlToast } from '@gitlab/ui';
 import Vue from 'vue';
 import VueApollo from 'vue-apollo';
 import createDefaultClient from '~/lib/graphql';
 import GroupRunnersApp from './group_runners_app.vue';
 
+Vue.use(GlToast);
 Vue.use(VueApollo);
 
 export const initGroupRunners = (selector = '#js-group-runners') => {
diff --git a/app/assets/javascripts/set_status_modal/set_status_modal_wrapper.vue b/app/assets/javascripts/set_status_modal/set_status_modal_wrapper.vue
index b1c8f6ef22e..0021fe909e5 100644
--- a/app/assets/javascripts/set_status_modal/set_status_modal_wrapper.vue
+++ b/app/assets/javascripts/set_status_modal/set_status_modal_wrapper.vue
@@ -339,7 +339,7 @@ export default {
           </div>
           <div class="gl-display-flex">
             <span class="gl-text-gray-600 gl-ml-5">
-              {{ s__('SetStatusModal|A busy indicator is shown next to your name and avatar.') }}
+              {{ s__('SetStatusModal|An indicator appears next to your name and avatar') }}
             </span>
           </div>
         </div>
diff --git a/app/assets/javascripts/terraform/index.js b/app/assets/javascripts/terraform/index.js
index 1b8cab0d51e..013b95c5633 100644
--- a/app/assets/javascripts/terraform/index.js
+++ b/app/assets/javascripts/terraform/index.js
@@ -22,6 +22,7 @@ export default () => {
         return object.id || defaultDataIdFromObject(object);
       },
     },
+    assumeImmutableResults: true,
   });
 
   const { emptyStateImage, projectPath, accessTokensPath, terraformApiUrl, username } = el.dataset;
diff --git a/app/assets/javascripts/vue_shared/components/runner_instructions/constants.js b/app/assets/javascripts/vue_shared/components/runner_instructions/constants.js
index facace0d809..34845e3d9e4 100644
--- a/app/assets/javascripts/vue_shared/components/runner_instructions/constants.js
+++ b/app/assets/javascripts/vue_shared/components/runner_instructions/constants.js
@@ -2,6 +2,8 @@ import { s__ } from '~/locale';
 
 export const PLATFORMS_WITHOUT_ARCHITECTURES = ['docker', 'kubernetes'];
 
+export const REGISTRATION_TOKEN_PLACEHOLDER = '$REGISTRATION_TOKEN';
+
 export const INSTRUCTIONS_PLATFORMS_WITHOUT_ARCHITECTURES = {
   docker: {
     instructions: s__(
diff --git a/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue b/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue
index 27c671ffc44..d5493aa5a66 100644
--- a/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue
+++ b/app/assets/javascripts/vue_shared/components/runner_instructions/runner_instructions_modal.vue
@@ -16,8 +16,9 @@ import { isEmpty } from 'lodash';
 import { __, s__ } from '~/locale';
 import ModalCopyButton from '~/vue_shared/components/modal_copy_button.vue';
 import {
-  PLATFORMS_WITHOUT_ARCHITECTURES,
   INSTRUCTIONS_PLATFORMS_WITHOUT_ARCHITECTURES,
+  PLATFORMS_WITHOUT_ARCHITECTURES,
+  REGISTRATION_TOKEN_PLACEHOLDER,
 } from './constants';
 import getRunnerPlatformsQuery from './graphql/queries/get_runner_platforms.query.graphql';
 import getRunnerSetupInstructionsQuery from './graphql/queries/get_runner_setup.query.graphql';
@@ -44,6 +45,11 @@ export default {
       required: false,
       default: 'runner-instructions-modal',
     },
+    registrationToken: {
+      type: String,
+      required: false,
+      default: null,
+    },
   },
   apollo: {
     platforms: {
@@ -118,6 +124,15 @@ export default {
     runnerInstallationLink() {
       return INSTRUCTIONS_PLATFORMS_WITHOUT_ARCHITECTURES[this.selectedPlatformName]?.link;
     },
+    registerInstructionsWithToken() {
+      const { registerInstructions } = this.instructions || {};
+
+      if (this.registrationToken) {
+        return registerInstructions.replace(REGISTRATION_TOKEN_PLACEHOLDER, this.registrationToken);
+      }
+
+      return registerInstructions;
+    },
   },
   methods: {
     show() {
@@ -249,11 +264,11 @@ export default {
           <pre
             class="gl-bg-gray gl-flex-grow-1 gl-white-space-pre-line"
             data-testid="register-command"
-            >{{ instructions.registerInstructions }}</pre
+            >{{ registerInstructionsWithToken }}</pre
           >
           <modal-copy-button
             :title="$options.i18n.copyInstructions"
-            :text="instructions.registerInstructions"
+            :text="registerInstructionsWithToken"
             :modal-id="$options.modalId"
             css-classes="gl-align-self-start gl-ml-2 gl-mt-2"
             category="tertiary"
diff --git a/app/graphql/types/ci/runner_setup_type.rb b/app/graphql/types/ci/runner_setup_type.rb
index 70f33cef8ad..b6b020db40e 100644
--- a/app/graphql/types/ci/runner_setup_type.rb
+++ b/app/graphql/types/ci/runner_setup_type.rb
@@ -9,7 +9,7 @@ module Types
       field :install_instructions, GraphQL::Types::String, null: false,
         description: 'Instructions for installing the runner on the specified architecture.'
       field :register_instructions, GraphQL::Types::String, null: true,
-        description: 'Instructions for registering the runner.'
+        description: 'Instructions for registering the runner. The actual registration tokens are not included in the commands. Instead, a placeholder `$REGISTRATION_TOKEN` is shown.'
     end
   end
 end
diff --git a/app/models/legacy_diff_note.rb b/app/models/legacy_diff_note.rb
index 25e90036a53..7c17b04bbc3 100644
--- a/app/models/legacy_diff_note.rb
+++ b/app/models/legacy_diff_note.rb
@@ -13,7 +13,7 @@ class LegacyDiffNote < Note
 
   validates :line_code, presence: true, line_code: true
 
-  before_create :set_diff
+  before_create :set_diff, unless: :skip_setting_st_diff?
 
   def discussion_class(*)
     LegacyDiffDiscussion
@@ -90,6 +90,10 @@ class LegacyDiffNote < Note
     self.st_diff = diff.to_hash if diff
   end
 
+  def skip_setting_st_diff?
+    st_diff.present? && importing? && Feature.enabled?(:skip_legacy_diff_note_callback_on_import, default_enabled: :yaml)
+  end
+
   def diff_for_line_code
     attributes = {
       noteable_type: noteable_type,
diff --git a/app/models/protected_branch.rb b/app/models/protected_branch.rb
index b4e2d17c3e5..96002c8668a 100644
--- a/app/models/protected_branch.rb
+++ b/app/models/protected_branch.rb
@@ -27,12 +27,17 @@ class ProtectedBranch < ApplicationRecord
   # Check if branch name is marked as protected in the system
   def self.protected?(project, ref_name)
     return true if project.empty_repo? && project.default_branch_protected?
+    return false if ref_name.blank?
 
-    Rails.cache.fetch("protected_ref-#{ref_name}-#{project.cache_key}") do
+    Rails.cache.fetch(protected_ref_cache_key(project, ref_name)) do
       self.matching(ref_name, protected_refs: protected_refs(project)).present?
     end
   end
 
+  def self.protected_ref_cache_key(project, ref_name)
+    "protected_ref-#{project.cache_key}-#{Digest::SHA1.hexdigest(ref_name)}"
+  end
+
   def self.allow_force_push?(project, ref_name)
     project.protected_branches.allowing_force_push.matching(ref_name).any?
   end
diff --git a/app/models/users/credit_card_validation.rb b/app/models/users/credit_card_validation.rb
index a4cc43d1f13..c3209bf8293 100644
--- a/app/models/users/credit_card_validation.rb
+++ b/app/models/users/credit_card_validation.rb
@@ -9,6 +9,7 @@ module Users
     belongs_to :user
 
     validates :holder_name, length: { maximum: 26 }
+    validates :network, length: { maximum: 32 }
     validates :last_digits, allow_nil: true, numericality: {
       greater_than_or_equal_to: 0, less_than_or_equal_to: 9999
     }
diff --git a/app/services/users/upsert_credit_card_validation_service.rb b/app/services/users/upsert_credit_card_validation_service.rb
index 86b5b923418..61cf598f178 100644
--- a/app/services/users/upsert_credit_card_validation_service.rb
+++ b/app/services/users/upsert_credit_card_validation_service.rb
@@ -12,6 +12,7 @@ module Users
         credit_card_validated_at: params.fetch(:credit_card_validated_at),
         expiration_date: get_expiration_date(params),
         last_digits: Integer(params.fetch(:credit_card_mask_number), 10),
+        network: params.fetch(:credit_card_type),
         holder_name: params.fetch(:credit_card_holder_name)
       }
 
diff --git a/app/views/profiles/show.html.haml b/app/views/profiles/show.html.haml
index 3e41f107e04..b1470520eea 100644
--- a/app/views/profiles/show.html.haml
+++ b/app/views/profiles/show.html.haml
@@ -71,7 +71,7 @@
           placeholder: s_("Profiles|What's your status?")
         .checkbox-icon-inline-wrapper
           = status_form.check_box :availability, { data: { testid: "user-availability-checkbox" }, label: s_("Profiles|Busy"), wrapper_class: 'gl-mr-0 gl-font-weight-bold' }, availability["busy"], availability["not_set"]
-          .gl-text-gray-600.gl-ml-5= s_('Profiles|"Busy" will be shown next to your name')
+          .gl-text-gray-600.gl-ml-5= s_('Profiles|An indicator appears next to your name and avatar')
     .col-lg-12
       %hr
   .row.user-time-preferences.js-search-settings-section
diff --git a/config/feature_flags/development/show_relevant_approval_rule_approvers.yml b/config/feature_flags/development/show_relevant_approval_rule_approvers.yml
index 2fef085381d..233f6916896 100644
--- a/config/feature_flags/development/show_relevant_approval_rule_approvers.yml
+++ b/config/feature_flags/development/show_relevant_approval_rule_approvers.yml
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/329153
 milestone: '13.12'
 type: development
 group: group::source code
-default_enabled: false
+default_enabled: true
diff --git a/config/feature_flags/development/skip_legacy_diff_note_callback_on_import.yml b/config/feature_flags/development/skip_legacy_diff_note_callback_on_import.yml
new file mode 100644
index 00000000000..43dcbee8f75
--- /dev/null
+++ b/config/feature_flags/development/skip_legacy_diff_note_callback_on_import.yml
@@ -0,0 +1,8 @@
+---
+name: skip_legacy_diff_note_callback_on_import
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/72897
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/343666
+milestone: '14.5'
+type: development
+group: group::import
+default_enabled: false
diff --git a/config/feature_flags/development/usage_data_instrumentation.yml b/config/feature_flags/development/usage_data_instrumentation.yml
new file mode 100644
index 00000000000..3708465ab77
--- /dev/null
+++ b/config/feature_flags/development/usage_data_instrumentation.yml
@@ -0,0 +1,8 @@
+---
+name: usage_data_instrumentation
+introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68808
+rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/338029
+milestone: '14.5'
+type: development
+group: group::product intelligence
+default_enabled: false
diff --git a/db/migrate/20211013080714_add_network_to_user_credit_card_validations.rb b/db/migrate/20211013080714_add_network_to_user_credit_card_validations.rb
new file mode 100644
index 00000000000..eee4cbad796
--- /dev/null
+++ b/db/migrate/20211013080714_add_network_to_user_credit_card_validations.rb
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class AddNetworkToUserCreditCardValidations < Gitlab::Database::Migration[1.0]
+  # rubocop:disable Migration/AddLimitToTextColumns
+  def change
+    add_column :user_credit_card_validations, :network, :text
+  end
+  # rubocop:enable Migration/AddLimitToTextColumns
+end
diff --git a/db/migrate/20211013080715_limit_network_on_user_credit_card_validations.rb b/db/migrate/20211013080715_limit_network_on_user_credit_card_validations.rb
new file mode 100644
index 00000000000..38a019e718d
--- /dev/null
+++ b/db/migrate/20211013080715_limit_network_on_user_credit_card_validations.rb
@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class LimitNetworkOnUserCreditCardValidations < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  def up
+    add_text_limit :user_credit_card_validations, :network, 32
+  end
+
+  def down
+    remove_text_limit :user_credit_card_validations, :network
+  end
+end
diff --git a/db/migrate/20211013080716_index_include_network_on_user_credit_card_validations.rb b/db/migrate/20211013080716_index_include_network_on_user_credit_card_validations.rb
new file mode 100644
index 00000000000..849dbab77db
--- /dev/null
+++ b/db/migrate/20211013080716_index_include_network_on_user_credit_card_validations.rb
@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+class IndexIncludeNetworkOnUserCreditCardValidations < Gitlab::Database::Migration[1.0]
+  disable_ddl_transaction!
+
+  INDEX_NAME = 'index_user_credit_card_validations_meta_data_partial_match'
+
+  def up
+    add_concurrent_index :user_credit_card_validations,
+      [:expiration_date, :last_digits, :network, :credit_card_validated_at],
+      name: INDEX_NAME
+  end
+
+  def down
+    remove_concurrent_index_by_name :user_credit_card_validations, INDEX_NAME
+  end
+end
diff --git a/db/schema_migrations/20211013080714 b/db/schema_migrations/20211013080714
new file mode 100644
index 00000000000..3579bdf3c78
--- /dev/null
+++ b/db/schema_migrations/20211013080714
@@ -0,0 +1 @@
+5c5adaf0f6f053c7e737051fbccf61d1fc36e20360a82d5fca142883d3e3bfdd
\ No newline at end of file
diff --git a/db/schema_migrations/20211013080715 b/db/schema_migrations/20211013080715
new file mode 100644
index 00000000000..ff2d473c946
--- /dev/null
+++ b/db/schema_migrations/20211013080715
@@ -0,0 +1 @@
+06d6458f7b85b3e729c3c8a8ae29c29f7c5504ea330ae3a3bcf1e0074ed66cf6
\ No newline at end of file
diff --git a/db/schema_migrations/20211013080716 b/db/schema_migrations/20211013080716
new file mode 100644
index 00000000000..d2131eb811a
--- /dev/null
+++ b/db/schema_migrations/20211013080716
@@ -0,0 +1 @@
+a5928cef69626ad5e972e8cb7a570ca83201cdfe7ec4f2401f2aa14c34b9cfb8
\ No newline at end of file
diff --git a/db/structure.sql b/db/structure.sql
index 8ff4caecb60..0aea5903949 100644
--- a/db/structure.sql
+++ b/db/structure.sql
@@ -19843,6 +19843,8 @@ CREATE TABLE user_credit_card_validations (
     expiration_date date,
     last_digits smallint,
     holder_name text,
+    network text,
+    CONSTRAINT check_1765e2b30f CHECK ((char_length(network) <= 32)),
     CONSTRAINT check_3eea080c91 CHECK (((last_digits >= 0) AND (last_digits <= 9999))),
     CONSTRAINT check_eafe45d88b CHECK ((char_length(holder_name) <= 26))
 );
@@ -26821,6 +26823,8 @@ CREATE UNIQUE INDEX index_user_canonical_emails_on_user_id_and_canonical_email O
 
 CREATE INDEX index_user_credit_card_validations_meta_data_full_match ON user_credit_card_validations USING btree (holder_name, expiration_date, last_digits, credit_card_validated_at);
 
+CREATE INDEX index_user_credit_card_validations_meta_data_partial_match ON user_credit_card_validations USING btree (expiration_date, last_digits, network, credit_card_validated_at);
+
 CREATE INDEX index_user_custom_attributes_on_key_and_value ON user_custom_attributes USING btree (key, value);
 
 CREATE UNIQUE INDEX index_user_custom_attributes_on_user_id_and_key ON user_custom_attributes USING btree (user_id, key);
diff --git a/doc/.vale/gitlab/Acronyms.yml b/doc/.vale/gitlab/Acronyms.yml
index b75f81dd075..b0970fad553 100644
--- a/doc/.vale/gitlab/Acronyms.yml
+++ b/doc/.vale/gitlab/Acronyms.yml
@@ -140,6 +140,7 @@ exceptions:
   - RPM
   - RPS
   - RSA
+  - RDS
   - RSS
   - RVM
   - SAAS
diff --git a/doc/administration/geo/setup/external_database.md b/doc/administration/geo/setup/external_database.md
index 13dbf9d1434..756e73f022f 100644
--- a/doc/administration/geo/setup/external_database.md
+++ b/doc/administration/geo/setup/external_database.md
@@ -8,7 +8,7 @@ type: howto
 # Geo with external PostgreSQL instances **(PREMIUM SELF)**
 
 This document is relevant if you are using a PostgreSQL instance that is *not
-managed by Omnibus*. This includes cloud-managed instances like AWS RDS, or
+managed by Omnibus*. This includes cloud-managed instances like Amazon RDS, or
 manually installed and configured PostgreSQL instances.
 
 NOTE:
@@ -58,7 +58,7 @@ developed and tested. We aim to be compatible with most external
 
 To set up an external database, you can either:
 
-- Set up [streaming replication](https://www.postgresql.org/docs/12/warm-standby.html#STREAMING-REPLICATION-SLOTS) yourself (for example AWS RDS, bare metal not managed by Omnibus, and so on).
+- Set up [streaming replication](https://www.postgresql.org/docs/12/warm-standby.html#STREAMING-REPLICATION-SLOTS) yourself (for example Amazon RDS, bare metal not managed by Omnibus, and so on).
 - Perform the Omnibus configuration manually as follows.
 
 #### Leverage your cloud provider's tools to replicate the primary database
@@ -200,7 +200,7 @@ This is for the installation of extensions during installation and upgrades. As
 To setup an external tracking database, follow the instructions below:
 
 NOTE:
-If you want to use AWS RDS as a tracking database, make sure it has access to
+If you want to use Amazon RDS as a tracking database, make sure it has access to
 the secondary database. Unfortunately, just assigning the same security group is not enough as
 outbound rules do not apply to RDS PostgreSQL databases. Therefore, you need to explicitly add an inbound
 rule to the read-replica's security group allowing any TCP traffic from
diff --git a/doc/administration/operations/fast_ssh_key_lookup.md b/doc/administration/operations/fast_ssh_key_lookup.md
index 8aa5af4c2bf..dec008b335e 100644
--- a/doc/administration/operations/fast_ssh_key_lookup.md
+++ b/doc/administration/operations/fast_ssh_key_lookup.md
@@ -132,6 +132,44 @@ This is a brief overview. Please refer to the above instructions for more contex
 1. Remove the `AuthorizedKeysCommand` lines from `/etc/ssh/sshd_config` or from `/assets/sshd_config` if you are using Omnibus Docker.
 1. Reload `sshd`: `sudo service sshd reload`.
 
+## Use `gitlab-sshd` instead of OpenSSH
+
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/299109) in GitLab 14.5.
+
+WARNING:
+`gitlab-sshd` is in [**Alpha**](https://about.gitlab.com/handbook/product/gitlab-the-product/#alpha-beta-ga).
+It is not ready for production use.
+
+`gitlab-sshd` is [a standalone SSH server](https://gitlab.com/gitlab-org/gitlab-shell/-/tree/main/internal/sshd)
+ written in Go. It is provided as a part of `gitlab-shell` package. It has a lower memory
+ use as a OpenSSH alternative and supports
+ [group access restriction by IP address](../../user/group/index.md) for applications
+ running behind the proxy.
+
+If you are considering switching from OpenSSH to `gitlab-sshd`, consider these concerns:
+
+- The `gitlab-sshd` component is only available for
+  [Cloud Native Helm Charts](https://docs.gitlab.com/charts/) deployments.
+- `gitlab-sshd` supports the PROXY protocol. It can run behind proxy servers that rely
+  on it, such as HAProxy.
+- `gitlab-sshd` does not share a SSH port with the system administrator's OpenSSH,
+  and requires a bind to port 22.
+- `gitlab-sshd` **does not** support SSH certificates.
+
+To switch from OpenSSH to `gitlab-sshd`:
+
+1. Set the `gitlab-shell` charts `sshDaemon` option to
+   [`gitlab-sshd`](https://docs.gitlab.com/charts/charts/gitlab/gitlab-shell/index.html#installation-command-line-options).
+   For example:
+
+   ```yaml
+   gitlab:
+     gitlab-shell:
+       sshDaemon: gitlab-sshd
+   ```
+
+1. Perform a Helm upgrade.
+
 ## Compiling a custom version of OpenSSH for CentOS 6
 
 Building a custom version of OpenSSH is not necessary for Ubuntu 16.04 users,
diff --git a/doc/administration/reference_architectures/10k_users.md b/doc/administration/reference_architectures/10k_users.md
index e731085b0ce..73aead67724 100644
--- a/doc/administration/reference_architectures/10k_users.md
+++ b/doc/administration/reference_architectures/10k_users.md
@@ -36,7 +36,7 @@ full list of reference architectures, see
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
@@ -2199,7 +2199,7 @@ services where applicable):
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
diff --git a/doc/administration/reference_architectures/25k_users.md b/doc/administration/reference_architectures/25k_users.md
index 267f81efd91..dd63b10662f 100644
--- a/doc/administration/reference_architectures/25k_users.md
+++ b/doc/administration/reference_architectures/25k_users.md
@@ -36,7 +36,7 @@ full list of reference architectures, see
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
@@ -2199,7 +2199,7 @@ services where applicable):
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
diff --git a/doc/administration/reference_architectures/2k_users.md b/doc/administration/reference_architectures/2k_users.md
index 23b15b563f7..285669a8307 100644
--- a/doc/administration/reference_architectures/2k_users.md
+++ b/doc/administration/reference_architectures/2k_users.md
@@ -29,7 +29,7 @@ For a full list of reference architectures, see
 | NFS server (optional, not recommended)   | 1      | 4 vCPU, 3.6 GB memory   | `n1-highcpu-4`  | `c5.xlarge`  | `F4s v2` |
 
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run as reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run as reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
@@ -1027,7 +1027,7 @@ services where applicable):
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
 <!-- markdownlint-enable MD029 -->
diff --git a/doc/administration/reference_architectures/3k_users.md b/doc/administration/reference_architectures/3k_users.md
index 575dd22b729..54fcfb65346 100644
--- a/doc/administration/reference_architectures/3k_users.md
+++ b/doc/administration/reference_architectures/3k_users.md
@@ -45,7 +45,7 @@ For a full list of reference architectures, see
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
@@ -2106,7 +2106,7 @@ but with smaller performance requirements, several modifications can be consider
   - GitLab Rails and Sidekiq: Stateless services don't have a minimum node count. Two are enough for redundancy.
   - Gitaly and Praefect: A quorum is not strictly necessary. Two Gitaly nodes and two Praefect nodes are enough for redundancy.
 - Running select components in reputable Cloud PaaS solutions: Select components of the GitLab setup can instead be run on Cloud Provider PaaS solutions. By doing this, additional dependent components can also be removed:
-  - PostgreSQL: Can be run on reputable Cloud PaaS solutions such as Google Cloud SQL or AWS RDS. In this setup, the PgBouncer and Consul nodes are no longer required:
+  - PostgreSQL: Can be run on reputable Cloud PaaS solutions such as Google Cloud SQL or Amazon RDS. In this setup, the PgBouncer and Consul nodes are no longer required:
     - Consul may still be desired if [Prometheus](../monitoring/prometheus/index.md) auto discovery is a requirement, otherwise you would need to [manually add scrape configurations](../monitoring/prometheus/index.md#adding-custom-scrape-configurations) for all nodes.
       - As Redis Sentinel runs on the same box as Consul in this architecture, it may need to be run on a separate box if Redis is still being run via Omnibus.
   - Redis: Can be run on reputable Cloud PaaS solutions such as Google Memorystore and AWS ElastiCache. In this setup, the Redis Sentinel is no longer required.
@@ -2170,7 +2170,7 @@ services where applicable):
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
diff --git a/doc/administration/reference_architectures/50k_users.md b/doc/administration/reference_architectures/50k_users.md
index be44f464e7e..7c7d4519d53 100644
--- a/doc/administration/reference_architectures/50k_users.md
+++ b/doc/administration/reference_architectures/50k_users.md
@@ -36,7 +36,7 @@ full list of reference architectures, see
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
@@ -2213,7 +2213,7 @@ services where applicable):
 
 <!-- Disable ordered list rule https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#md029---ordered-list-item-prefix -->
 <!-- markdownlint-disable MD029 -->
-1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and AWS RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
+1. Can be optionally run on reputable third-party external PaaS PostgreSQL solutions. Google Cloud SQL and Amazon RDS are known to work, however Azure Database for PostgreSQL is [not recommended](https://gitlab.com/gitlab-org/quality/reference-architectures/-/issues/61) due to performance issues. Consul is primarily used for PostgreSQL high availability so can be ignored when using a PostgreSQL PaaS setup. However it is also used optionally by Prometheus for Omnibus auto host discovery.
 2. Can be optionally run on reputable third-party external PaaS Redis solutions. Google Memorystore and AWS Elasticache are known to work.
 3. Can be optionally run on reputable third-party load balancing services (LB PaaS). AWS ELB is known to work.
 4. Should be run on reputable third-party object storage (storage PaaS) for cloud implementations. Google Cloud Storage and AWS S3 are known to work.
diff --git a/doc/api/graphql/reference/index.md b/doc/api/graphql/reference/index.md
index c38ac224fb4..546ff2f8647 100644
--- a/doc/api/graphql/reference/index.md
+++ b/doc/api/graphql/reference/index.md
@@ -4711,17 +4711,17 @@ Input type: `VulnerabilityCreateInput`
 | <a id="mutationvulnerabilitycreateclientmutationid"></a>`clientMutationId` | [`String`](#string) | A unique identifier for the client performing the mutation. |
 | <a id="mutationvulnerabilitycreateconfidence"></a>`confidence` | [`VulnerabilityConfidence`](#vulnerabilityconfidence) | Confidence of the vulnerability (defaults to `unknown`). |
 | <a id="mutationvulnerabilitycreateconfirmedat"></a>`confirmedAt` | [`Time`](#time) | Timestamp of when the vulnerability state changed to confirmed (defaults to creation time if status is `confirmed`). |
-| <a id="mutationvulnerabilitycreatedescription"></a>`description` | [`String!`](#string) | Description of the vulnerability. |
+| <a id="mutationvulnerabilitycreatedescription"></a>`description` | [`String!`](#string) | Long text section that describes the vulnerability in more detail. |
 | <a id="mutationvulnerabilitycreatedetectedat"></a>`detectedAt` | [`Time`](#time) | Timestamp of when the vulnerability was first detected (defaults to creation time). |
 | <a id="mutationvulnerabilitycreatedismissedat"></a>`dismissedAt` | [`Time`](#time) | Timestamp of when the vulnerability state changed to dismissed (defaults to creation time if status is `dismissed`). |
 | <a id="mutationvulnerabilitycreateidentifiers"></a>`identifiers` | [`[VulnerabilityIdentifierInput!]!`](#vulnerabilityidentifierinput) | Array of CVE or CWE identifiers for the vulnerability. |
-| <a id="mutationvulnerabilitycreatemessage"></a>`message` | [`String`](#string) | Additional information about the vulnerability. |
+| <a id="mutationvulnerabilitycreatemessage"></a>`message` | [`String`](#string) | Short text section that describes the vulnerability. This may include the finding's specific information. |
 | <a id="mutationvulnerabilitycreatename"></a>`name` | [`String!`](#string) | Name of the vulnerability. |
 | <a id="mutationvulnerabilitycreateproject"></a>`project` | [`ProjectID!`](#projectid) | ID of the project to attach the vulnerability to. |
 | <a id="mutationvulnerabilitycreateresolvedat"></a>`resolvedAt` | [`Time`](#time) | Timestamp of when the vulnerability state changed to resolved (defaults to creation time if status is `resolved`). |
 | <a id="mutationvulnerabilitycreatescanner"></a>`scanner` | [`VulnerabilityScannerInput!`](#vulnerabilityscannerinput) | Information about the scanner used to discover the vulnerability. |
 | <a id="mutationvulnerabilitycreateseverity"></a>`severity` | [`VulnerabilitySeverity`](#vulnerabilityseverity) | Severity of the vulnerability (defaults to `unknown`). |
-| <a id="mutationvulnerabilitycreatesolution"></a>`solution` | [`String`](#string) | How to fix this vulnerability. |
+| <a id="mutationvulnerabilitycreatesolution"></a>`solution` | [`String`](#string) | Instructions for how to fix the vulnerability. |
 | <a id="mutationvulnerabilitycreatestate"></a>`state` | [`VulnerabilityState`](#vulnerabilitystate) | State of the vulnerability (defaults to `detected`). |
 
 #### Fields
@@ -13935,7 +13935,7 @@ Counts of requirements by their state.
 | Name | Type | Description |
 | ---- | ---- | ----------- |
 | <a id="runnersetupinstallinstructions"></a>`installInstructions` | [`String!`](#string) | Instructions for installing the runner on the specified architecture. |
-| <a id="runnersetupregisterinstructions"></a>`registerInstructions` | [`String`](#string) | Instructions for registering the runner. |
+| <a id="runnersetupregisterinstructions"></a>`registerInstructions` | [`String`](#string) | Instructions for registering the runner. The actual registration tokens are not included in the commands. Instead, a placeholder `$REGISTRATION_TOKEN` is shown. |
 
 ### `SastCiConfiguration`
 
diff --git a/doc/ci/cloud_deployment/index.md b/doc/ci/cloud_deployment/index.md
index 408d68fb726..80e4d8fbe27 100644
--- a/doc/ci/cloud_deployment/index.md
+++ b/doc/ci/cloud_deployment/index.md
@@ -104,7 +104,7 @@ GitLab also provides [Docker images](https://gitlab.com/gitlab-org/cloud-deploy/
 - Use `registry.gitlab.com/gitlab-org/cloud-deploy/aws-ecs:latest` to deploy your application to AWS ECS.
 
 Before getting started with this process, you need a cluster on AWS ECS, as well as related
-components, like an ECS service, ECS task definition, a database on AWS RDS, and so on.
+components, like an ECS service, ECS task definition, a database on Amazon RDS, and so on.
 [Read more about AWS ECS](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/Welcome.html).
 
 The ECS task definition can be:
diff --git a/doc/ci/services/postgres.md b/doc/ci/services/postgres.md
index 62838e04969..0bd43917cd1 100644
--- a/doc/ci/services/postgres.md
+++ b/doc/ci/services/postgres.md
@@ -37,9 +37,9 @@ And then configure your application to use the database, for example:
 
 ```yaml
 Host: postgres
-User: $PG_USER
-Password: $PG_PASSWORD
-Database: $PG_DB
+User: $POSTGRES_USER
+Password: $POSTGRES_PASSWORD
+Database: $POSTGRES_DB
 ```
 
 If you're wondering why we used `postgres` for the `Host`, read more at
diff --git a/doc/development/database/loose_foreign_keys.md b/doc/development/database/loose_foreign_keys.md
new file mode 100644
index 00000000000..157c1284512
--- /dev/null
+++ b/doc/development/database/loose_foreign_keys.md
@@ -0,0 +1,182 @@
+---
+stage: Enablement
+group: Database
+info: To determine the technical writer assigned to the Stage/Group associated with this page, see https://about.gitlab.com/handbook/engineering/ux/technical-writing/#assignments
+---
+
+# Loose foreign keys
+
+## Problem statement
+
+In relational databases (including PostgreSQL), foreign keys provide a way to link
+two database tables together, and ensure data-consistency between them. In GitLab,
+[foreign keys](../foreign_keys.md) are vital part of the database design process.
+Most of our database tables have foreign keys.
+
+With the ongoing database [decomposition work](https://gitlab.com/groups/gitlab-org/-/epics/6168),
+linked records might be present on two different database servers. Ensuring data consistency
+between two databases is not possible with standard PostgreSQL foreign keys. PostgreSQL
+does not support foreign keys operating within a single database server, defining
+a link between two database tables in two different database servers over the network.
+
+Example:
+
+- Database "Main": `projects` table
+- Database "CI": `ci_pipelines` table
+
+A project can have many pipelines. When a project is deleted, the associated `ci_pipeline` (via the
+`project_id` column) records must be also deleted.
+
+With a multi-database setup, this cannot be achieved with foreign keys.
+
+## Asynchronous approach
+
+Our preferred approach to this problem is eventual consistency. With the loose foreign keys
+feature, we can configure delayed association cleanup without negatively affecting the
+application performance.
+
+### How it works
+
+In the previous example, a record in the `projects` table can have multiple `ci_pipeline`
+records. To keep the cleanup process separate from the actual parent record deletion,
+we can:
+
+1. Create a `DELETE` trigger on the `projects` table.
+   Record the deletions in a separate table (`deleted_records`).
+1. A job checks the `deleted_records` table every 5 minutes.
+1. For each record in the table, delete the associated `ci_pipelines` records
+   using the `project_id` column.
+
+NOTE:
+For this procedure to work, we must register which tables to clean up asynchronously.
+
+## Example migration and configuration
+
+### Configure the model
+
+First, tell the application that the `projects` table has a new loose foreign key.
+You can do this in the `Project` model:
+
+```ruby
+class Project < ApplicationRecord
+  # ...
+
+  include LooseForeignKey
+
+  loose_foreign_key :ci_pipelines, :project_id, on_delete: :async_delete # or async_nullify
+
+  # ...
+end
+```
+
+This instruction ensures the asynchronous cleanup process knows about the association, and the
+how to do the cleanup. In this case, the associated `ci_pipelines` records are deleted.
+
+### Track record changes
+
+To know about deletions in the `projects` table, configure a `DELETE` trigger using a database
+migration (post-migration). The trigger needs to be configured only once. If the model already has
+at least one `loose_foreign_key` definition, then this step can be skipped:
+
+```ruby
+class TrackProjectRecordChanges < Gitlab::Database::Migration[1.0]
+  include Gitlab::Database::MigrationHelpers::LooseForeignKeyHelpers
+
+  enable_lock_retries!
+
+  def up
+    track_record_deletions(:projects)
+  end
+
+  def down
+    untrack_record_deletions(:projects)
+  end
+end
+```
+
+### Remove the foreign key
+
+If there is an existing foreign key, then it can be removed from the database. As of GitLab 14.5,
+the following foreign key describes the link between the `projects` and `ci_pipelines` tables:
+
+```sql
+ALTER TABLE ONLY ci_pipelines
+ADD CONSTRAINT fk_86635dbd80
+FOREIGN KEY (project_id)
+REFERENCES projects(id)
+ON DELETE CASCADE;
+```
+
+The migration should run after the `DELETE` trigger is installed. If the foreign key is deleted
+earlier, there is a good chance of introducing data inconsistency which needs manual cleanup:
+
+```ruby
+class RemoveProjectsCiPipelineFk < Gitlab::Database::Migration[1.0]
+  enable_lock_retries!
+
+  def up
+    remove_foreign_key_if_exists(:ci_pipelines, :projects, name: "fk_86635dbd80")
+  end
+
+  def down
+    add_concurrent_foreign_key(:ci_pipelines, :projects, name: "fk_86635dbd80", column: :project_id, target_column: :id, on_delete: "cascade")
+  end
+end
+```
+
+At this point, the setup phase is concluded. The deleted `projects` records should be automatically
+picked up by the scheduled cleanup worker job.
+
+## Caveats of loose foreign keys
+
+### Record creation
+
+The feature provides an efficient way of cleaning up associated records after the parent record is
+deleted. Without foreign keys, it's the application's responsibility to validate if the parent record
+exists when a new associated record is created.
+
+A bad example: record creation with the given ID (`project_id` comes from user input).
+In this example, nothing prevents us from passing a random project ID:
+
+```ruby
+Ci::Pipeline.create!(project_id: params[:project_id])
+```
+
+A good example: record creation with extra check:
+
+```ruby
+project = Project.find(params[:project_id])
+Ci::Pipeline.create!(project_id: project.id)
+```
+
+### Association lookup
+
+Consider the following HTTP request:
+
+```plaintext
+GET /projects/5/pipelines/100
+```
+
+The controller action ignores the `project_id` parameter and finds the pipeline using the ID:
+
+```ruby
+  def show
+  # bad, avoid it
+  pipeline = Ci::Pipeline.find(params[:id]) # 100
+end
+```
+
+This endpoint still works when the parent `Project` model is deleted. This can be considered a
+a data leak which should not happen under normal circumstances:
+
+```ruby
+def show
+  # good
+  project = Project.find(params[:project_id])
+  pipeline = project.pipelines.find(params[:pipeline_id]) # 100
+end
+```
+
+NOTE:
+This example is unlikely in GitLab, because we usually look up the parent models to perform
+permission checks.
diff --git a/doc/development/documentation/styleguide/word_list.md b/doc/development/documentation/styleguide/word_list.md
index f1e6a147571..30d93de5134 100644
--- a/doc/development/documentation/styleguide/word_list.md
+++ b/doc/development/documentation/styleguide/word_list.md
@@ -524,8 +524,8 @@ Use lowercase for **runners**. These are the agents that run CI/CD jobs. See als
 
 Do not use **(s)** to make a word optionally plural. It can slow down comprehension. For example:
 
-Do: Select the jobs you want.
-Do not: Select the job(s) you want.
+- Do: Select the jobs you want.
+- Do not: Select the job(s) you want.
 
 If you can select multiples of something, then write the word as plural.
 
diff --git a/doc/install/aws/gitlab_hybrid_on_aws.md b/doc/install/aws/gitlab_hybrid_on_aws.md
index 5edc9c1245f..3c035b33be8 100644
--- a/doc/install/aws/gitlab_hybrid_on_aws.md
+++ b/doc/install/aws/gitlab_hybrid_on_aws.md
@@ -219,7 +219,7 @@ If EKS node autoscaling is employed, it is likely that your average loading will
 | **<u>Gitaly Cluster</u>** [Details](gitlab_sre_for_aws.md#gitaly-sre-considerations) |                                                              |                                                         |                                 |                                                              |
 | Gitaly Instances (in ASG)                                    | 12 vCPU, 45GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | **m5.large** x 3 nodes<br />(12 vCPU, 48 GB)            | $0.192 x 3 = $0.58/hr           | [Gitaly & Praefect Must Have an Uneven Node Count for HA](gitlab_sre_for_aws.md#gitaly-and-praefect-elections) |
 | Praefect (Instances in ASG with load balancer)               | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | **c5.large** x 3 nodes<br />(6 vCPU, 12 GB)             | $0.09 x 3 = $0.21/hr            | [Gitaly & Praefect Must Have an Uneven Node Count for HA](gitlab_sre_for_aws.md#gitaly-and-praefect-elections) |
-| Praefect PostgreSQL(1) (AWS RDS)                             | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | N/A Reuses GitLab PostgreSQL                            | $0                              |                                                              |
+| Praefect PostgreSQL(1) (Amazon RDS)                             | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | N/A Reuses GitLab PostgreSQL                            | $0                              |                                                              |
 | Internal Load Balancing Node                                 | 2 vCPU, 1.8 GB                                               | AWS ELB                                                 | $0.10/hr                        | $0.10/hr                                                     |
 
 ### 5K Cloud Native Hybrid on EKS
@@ -273,7 +273,7 @@ If EKS node autoscaling is employed, it is likely that your average loading will
 | **<u>Gitaly Cluster</u>** [Details](gitlab_sre_for_aws.md#gitaly-sre-considerations) |                                                              |                                                         |                                 |                                                              |
 | Gitaly Instances (in ASG)                                    | 24 vCPU, 90GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | **m5.2xlarge** x 3 nodes<br />(24 vCPU, 96GB)           | $0.384 x 3 = $1.15/hr           | [Gitaly & Praefect Must Have an Uneven Node Count for HA](gitlab_sre_for_aws.md#gitaly-and-praefect-elections) |
 | Praefect (Instances in ASG with load balancer)               | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | **c5.large** x 3 nodes<br />(6 vCPU, 12 GB)             | $0.09 x 3 = $0.21/hr            | [Gitaly & Praefect Must Have an Uneven Node Count for HA](gitlab_sre_for_aws.md#gitaly-and-praefect-elections) |
-| Praefect PostgreSQL(1) (AWS RDS)                             | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | N/A Reuses GitLab PostgreSQL                            | $0                              |                                                              |
+| Praefect PostgreSQL(1) (Amazon RDS)                             | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | N/A Reuses GitLab PostgreSQL                            | $0                              |                                                              |
 | Internal Load Balancing Node                                 | 2 vCPU, 1.8 GB                                               | AWS ELB                                                 | $0.10/hr                        | $0.10/hr                                                     |
 
 ### 10K Cloud Native Hybrid on EKS
@@ -326,7 +326,7 @@ If EKS node autoscaling is employed, it is likely that your average loading will
 | **<u>Gitaly Cluster</u>** [Details](gitlab_sre_for_aws.md#gitaly-sre-considerations) |  |  |  |  |
 | Gitaly Instances (in ASG) | 48 vCPU, 180GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | **m5.4xlarge** x 3 nodes<br />(48 vCPU, 180 GB) | $0.77 x 3 = $2.31/hr | [Gitaly & Praefect Must Have an Uneven Node Count for HA](gitlab_sre_for_aws.md#gitaly-and-praefect-elections) |
 | Praefect (Instances in ASG with load balancer) | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | **c5.large** x 3 nodes<br />(6 vCPU, 12 GB) | $0.09 x 3 = $0.21/hr | [Gitaly & Praefect Must Have an Uneven Node Count for HA](gitlab_sre_for_aws.md#gitaly-and-praefect-elections) |
-| Praefect PostgreSQL(1) (AWS RDS) | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | N/A Reuses GitLab PostgreSQL | $0 |  |
+| Praefect PostgreSQL(1) (Amazon RDS) | 6 vCPU, 5.4 GB<br />([across 3 nodes](gitlab_sre_for_aws.md#gitaly-and-praefect-elections)) | N/A Reuses GitLab PostgreSQL | $0 |  |
 | Internal Load Balancing Node | 2 vCPU, 1.8 GB | AWS ELB | $0.10/hr | $0.10/hr |
 
 ### 50K Cloud Native Hybrid on EKS
diff --git a/doc/install/aws/manual_install_aws.md b/doc/install/aws/manual_install_aws.md
index 985e6abd34f..18d6f9e964c 100644
--- a/doc/install/aws/manual_install_aws.md
+++ b/doc/install/aws/manual_install_aws.md
@@ -32,7 +32,7 @@ For the Cloud Native Hybrid architectures there are two Infrastructure as Code o
 
 ## Introduction
 
-For the most part, we'll make use of Omnibus GitLab in our setup, but we'll also leverage native AWS services. Instead of using the Omnibus bundled PostgreSQL and Redis, we will use AWS RDS and ElastiCache.
+For the most part, we'll make use of Omnibus GitLab in our setup, but we'll also leverage native AWS services. Instead of using the Omnibus bundled PostgreSQL and Redis, we will use Amazon RDS and ElastiCache.
 
 In this guide, we'll go through a multi-node setup where we'll start by
 configuring our Virtual Private Cloud and subnets to later integrate
diff --git a/doc/user/admin_area/merge_requests_approvals.md b/doc/user/admin_area/merge_requests_approvals.md
index 18151fc17d5..19cf1dbc65a 100644
--- a/doc/user/admin_area/merge_requests_approvals.md
+++ b/doc/user/admin_area/merge_requests_approvals.md
@@ -7,7 +7,7 @@ type: reference, concepts
 
 # Merge request approval rules **(PREMIUM SELF)**
 
-> Introduced in [GitLab Premium](https://gitlab.com/gitlab-org/gitlab/-/issues/39060) 12.8.
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/39060) in GitLab 12.8.
 
 Merge request approval rules prevent users from overriding certain settings on the project
 level. When enabled at the instance level, these settings are no longer editable on the
diff --git a/doc/user/admin_area/settings/account_and_limit_settings.md b/doc/user/admin_area/settings/account_and_limit_settings.md
index 3549aa5323b..81c1c6b8fd8 100644
--- a/doc/user/admin_area/settings/account_and_limit_settings.md
+++ b/doc/user/admin_area/settings/account_and_limit_settings.md
@@ -148,7 +148,7 @@ add the line below to `/etc/gitlab/gitlab.rb` before increasing the max attachme
 nginx['client_max_body_size'] = "200m"
 ```
 
-## Customize session duration for Git Operations when 2FA is enabled **(PREMIUM)**
+## Customize session duration for Git Operations when 2FA is enabled **(PREMIUM SELF)**
 
 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/296669) in GitLab 13.9.
 > - It's deployed behind a feature flag, disabled by default.
@@ -173,7 +173,7 @@ To set a limit on how long these sessions are valid:
 
 ## Limit the lifetime of personal access tokens **(ULTIMATE SELF)**
 
-> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/3649) in GitLab Ultimate 12.6.
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/3649) in GitLab 12.6.
 
 Users can optionally specify a lifetime for
 [personal access tokens](../../profile/personal_access_tokens.md).
@@ -222,7 +222,7 @@ Disabling SSH key expiration immediately enables all expired SSH keys.
 
 ## Allow expired Personal Access Tokens to be used **(ULTIMATE SELF)**
 
-> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/214723) in GitLab Ultimate 13.1.
+> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/214723) in GitLab 13.1.
 > - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/issues/296881) in GitLab 13.9.
 
 By default, expired personal access tokens (PATs) **are not usable**.
diff --git a/doc/user/admin_area/settings/index.md b/doc/user/admin_area/settings/index.md
index 688734849e5..5b78eecad5d 100644
--- a/doc/user/admin_area/settings/index.md
+++ b/doc/user/admin_area/settings/index.md
@@ -41,7 +41,7 @@ To access the default page for Admin Area settings:
 | [Kroki](../../../administration/integration/kroki.md#enable-kroki-in-gitlab) | Allow rendering of diagrams in AsciiDoc and Markdown documents using [kroki.io](https://kroki.io). |
 | [Mailgun](../../../administration/integration/mailgun.md) | Enable your GitLab instance to receive invite email bounce events from Mailgun, if it is your email provider. |
 | [PlantUML](../../../administration/integration/plantuml.md) | Allow rendering of PlantUML diagrams in documents. |
-| [Slack application](../../../user/project/integrations/gitlab_slack_application.md#configuration) **(FREE SAAS)** | Slack integration allows you to interact with GitLab via slash commands in a chat window. This option is only available on GitLab.com, though it may be [available for self-managed instances in the future](https://gitlab.com/gitlab-org/gitlab/-/issues/28164). |
+| [Slack application](../../../user/project/integrations/gitlab_slack_application.md#configuration) | Slack integration allows you to interact with GitLab via slash commands in a chat window. This option is only available on GitLab.com, though it may be [available for self-managed instances in the future](https://gitlab.com/gitlab-org/gitlab/-/issues/28164). |
 | [Third party offers](third_party_offers.md) | Control the display of third party offers. |
 | [Snowplow](../../../development/snowplow/index.md) | Configure the Snowplow integration. |
 | [Google GKE](../../project/clusters/add_gke_clusters.md) | Google GKE integration allows you to provision GKE clusters from GitLab. |
@@ -69,7 +69,7 @@ To access the default page for Admin Area settings:
 | Option | Description |
 | ------ | ----------- |
 | [Continuous Integration and Deployment](continuous_integration.md) | Auto DevOps, runners and job artifacts. |
-| [Required pipeline configuration](continuous_integration.md#required-pipeline-configuration) **(PREMIUM SELF)** | Set an instance-wide auto included [pipeline configuration](../../../ci/yaml/index.md). This pipeline configuration is run after the project's own configuration. |
+| [Required pipeline configuration](continuous_integration.md#required-pipeline-configuration) | Set an instance-wide auto included [pipeline configuration](../../../ci/yaml/index.md). This pipeline configuration is run after the project's own configuration. |
 | [Package Registry](continuous_integration.md#package-registry-configuration) | Settings related to the use and experience of using the GitLab Package Registry. Note there are [risks involved](../../packages/container_registry/index.md#use-with-external-container-registries) in enabling some of these settings. |
 
 ## Reporting
@@ -88,7 +88,7 @@ To access the default page for Admin Area settings:
 | [Profiling - Performance bar](../../../administration/monitoring/performance/performance_bar.md#enable-the-performance-bar-for-non-administrators) | Enable access to the Performance Bar for non-administrator users in a given group. |
 | [Self monitoring](../../../administration/monitoring/gitlab_self_monitoring_project/index.md#create-the-self-monitoring-project) | Enable or disable instance self monitoring. |
 | [Usage statistics](usage_statistics.md) | Enable or disable version check and Service Ping. |
-| [Pseudonymizer data collection](../../../administration/pseudonymizer.md) **(ULTIMATE)** | Enable or disable the Pseudonymizer data collection. |
+| [Pseudonymizer data collection](../../../administration/pseudonymizer.md) | Enable or disable the Pseudonymizer data collection. |
 
 ## Network
 
@@ -105,11 +105,11 @@ To access the default page for Admin Area settings:
 | [Incident Management](../../../operations/incident_management/index.md) Limits | Limit the number of inbound alerts that can be sent to a project. |
 | [Notes creation limit](rate_limit_on_notes_creation.md)| Set a rate limit on the note creation requests. |
 
-## Geo
+## Geo **(PREMIUM SELF)**
 
 | Option | Description |
 | ------ | ----------- |
-| Geo    | Geo allows you to replicate your GitLab instance to other geographical locations. Redirects to **Admin Area > Geo > Settings** are no longer available at **Admin Area > Settings > Geo** in [GitLab 13.0](https://gitlab.com/gitlab-org/gitlab/-/issues/36896). |
+| [Geo](../../../administration/geo/index.md) | Geo allows you to replicate your GitLab instance to other geographical locations. Redirects to **Admin Area > Geo > Settings** are no longer available at **Admin Area > Settings > Geo** in [GitLab 13.0](https://gitlab.com/gitlab-org/gitlab/-/issues/36896). |
 
 ## Preferences
 
diff --git a/doc/user/admin_area/settings/instance_template_repository.md b/doc/user/admin_area/settings/instance_template_repository.md
index 044863729db..71eb7bbbdc9 100644
--- a/doc/user/admin_area/settings/instance_template_repository.md
+++ b/doc/user/admin_area/settings/instance_template_repository.md
@@ -7,7 +7,7 @@ type: reference
 
 # Instance template repository **(PREMIUM SELF)**
 
-> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/5986) in GitLab Premium 11.3.
+> [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/5986) in GitLab 11.3.
 
 In hosted systems, enterprises often have a need to share their own templates
 across teams. This feature allows an administrator to pick a project to be the
diff --git a/doc/user/discussions/index.md b/doc/user/discussions/index.md
index aa4e3ce6f49..919d5bad6e2 100644
--- a/doc/user/discussions/index.md
+++ b/doc/user/discussions/index.md
@@ -125,7 +125,7 @@ If an issue or merge request is locked and closed, you cannot reopen it.
 > - [Deployed behind a feature flag](../feature_flags.md), disabled by default.
 > - Disabled on GitLab.com.
 > - Not recommended for production use.
-> - To use in GitLab self-managed instances, ask a GitLab administrator to enable it. **(FREE SELF)**
+> - To use in GitLab self-managed instances, ask a GitLab administrator to enable it.
 
 WARNING:
 This feature might not be available to you. Check the **version history** note above for details.
@@ -178,7 +178,7 @@ When you reply to a standard comment, you create a thread.
 Prerequisites:
 
 - You must have at least the [Guest role](../permissions.md#project-members-permissions).
-- You must be in an issue, merge request, or epic. Commits and snippets threads are not supported.
+- You must be in an issue, merge request, or epic. Threads in commits and snippets are not supported.
 
 To create a thread by replying to a comment:
 
diff --git a/doc/user/search/img/basic_search.png b/doc/user/search/img/basic_search_v14_4.png
similarity index 100%
rename from doc/user/search/img/basic_search.png
rename to doc/user/search/img/basic_search_v14_4.png
diff --git a/doc/user/search/img/issues_mrs_shortcut.png b/doc/user/search/img/issues_mrs_shortcut.png
deleted file mode 100644
index 5be8079030ac9dfbc78037092171dbf0df5fd84c..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 4523
zcmZ`-2|SeF*B|vmXeDJSX;Il`P-I^c64}C#vG0bNF*Eip(uPWyl!{ieJxFTIShFt?
z8j}$XGlap|m%+?`^!vTP_kBN~_r0I{Jonsl&pF?7&RstDdG1+RnCuah5CnlhdrU81
zvH^j3pj>)k*G}%c%QUos+x+EgaMb_=Dtjoj>CVgT^I&XDE`orrBa>X((cjhq>u}Xv
z(-Rp4cK1Shc!R@(P+TbxNIP7UO9pvk-KE2W0udO^aGeu>Bs977HXCw6`i}?}u5-fS
zs+F`M674Om237(qozNAOmX_8=d--VETr&Pgo!iqn;fKYdG$D|%urP4gIWQ9K3sKh4
z(10kZKvYx|xe|()2n5zWToHje`L~h(vUABB<B9f1Vf~Q^>21629>@@^&WRJ-K>wD%
z{lxnF{5KK;^G{gZ03q8W5M{6u<X_udRqbuArX||nn~S_{UsqZCkL3U2{ez<o*#`d~
z&iozeA1*gkT|sTgziHDI6n7cn=Vnp>b=eUE0*Uu;KRjYR?K9lW)2z&GjW`_6=H})c
zlQ}gxxwN#r&SF6z5II@*v9Yl&Zeg=GHdsAu4yP;S+XF=on~~DRVQ@I$2jAc&3?Kl^
zD1n3h0bqi|nE*KK9xym1EiD5MPDufCWAsZcCr#Do3=A-9U#6viF&y^P@bEB)&5@OJ
z_lJPVCAYYSfj-X4>Uw$_P@I}wH^q5X%iw$mIFq&M*)?qT76jrw^z&zS_Gdr82j|cG
z-@N(SzyNJ+9aCA^J~}$t*Ecl3u(ZCuPNgoiwlu#+dcwi*m6es%)zy)a(WRxund#~I
z`E>;9WmQ#|wM_zzKE`5g_4f9WNc|knT0=v_-26g!S66#S$HwN?#KiKCA3ypsEhZ)=
zfD-ucF<Ni$bin{|YHjw-8{+u)K8KLvnc3Ot>D85$4J!3lo|$H#N072vN@M)F57FAQ
zgOtUE1qOpbp-^ZvT26q5Pd+J+Iz?WfZ?LzZckjqvz^Z~_51jP2HaBYO+jU`B#RtHp
zTOA8{Y=o6DVYGutAnJxz6&4kN15(C*Psm<$1As4B?9=G>=if;)N=`ZYX%V%xwHuSa
z%L#S*zVF#vn?qflDuy>))h$giQQAt^tu$;GN2x~VpdL}_GqdylM&_G~3+G}#(z&~H
z+VqlvZ8&B6#XZ+S<3lY*(%0)ALrUx2>(zM4YO;y?0~@<e?SE-%>SxjWcHk<(G(GT>
zfA7+8Xw-DfuT^%w7V~S$shh~QMwQxCQ*Zd&rv|P%I`_Z-(w1~hsA$+N4I<Z}b)v@K
z^T694WNSF#7>-uU7gqvR0bfu{@{9at(b=i5?uEg;5=cIPO0k1oRoVeX&Bzg}aQx6;
zGyENuFoXzftD@HjY~ogOz9S?69T*r07<UYqF9%HyJVmVb!)BL@i^)wNOo2<|Yv#$Y
z`%SF4f%(H<c*Y5x`er+rW8?UKovAF?eemx{jZ9jUeQc$6quO|h*P_Z1ucnq1W!3dN
zWw+FC-MtmAcI}9y*6FZbgOfz1wldEEbn{uMH{nXY-(n$&<yA<vle*_ZiQ;b%A1BQ_
z_KiRGeiD?$m{(rOizs`3_^e*CkYB>YMOf+nMEg<4`Un@5r&*n?I^{{$;?OczYkl0{
z!?vk**O?@ql%3DyIuWW`QcuowpU}LPjxo+Q*bn&<NMAg{AMWhjyX4$*8y$z6SPBD5
z<OW1{`aaWcrd%IZmG<*{E~A}X(x<%AS*F}%SC0wCz5S~-0QN8rGK+dA+C&1xw23F0
z9Y<?_E{x??3g3RcB(sCMLPi7Aq3=e`Jz-%R@O&}-IK?r6fZ2Am#t#;3ou!w1^B7N?
z95Cr9?s^okhz<!B9dT$RIm4O=QiG41$R5q=x>|XLNToVN5CS2dnMpcYG%{cJq-wBF
z-|cwzp+eWQ0AI1!Pj>s~5KSHgV7oGjh!dsp>fGM{?Hs{FHXJ5iEG8bP2)Q86-`>2E
zoNU}yZ8LcH_&$>bK<`!mlgv+<SL&l*54EiBluML|$jOn}yAt(fy}&RA)wEHxg1QwC
zzk`l(5yy&W-^Yqe_=-a(?rIN+UmzdG8LW;EIGe8K21~eJGlu2du_zBIu*u60miT4G
zCtC{P@_*U#ovL}#>>q6>p1S5CkvAXWtv{OV|GXKRvD~n!biZ%yvC7Y$7-h-dVHrI4
zAU?FsPb$`GX9Gd~X$Q1M18AFoN_+@)|EMP;)bB<eMg5_ihyxP2n|cvJ;!{J2I7s?F
z{7@fnrB@osGk8qcP1Ry=L7>hV7Eep^a?XVK$6!sEA)GpOpK-ml$!^fiPZU-i?7U}>
z{jPnlbWzLA6%gAIK2?+$tQxJe8=wmQUzPF~w8OkdA%)&}Ia2#o`?zJ+csH`?K3!4c
zv#RFvBx1p(2Z{9+d&x5!aT_g{HOMx-n-hoS(`$DlnLmXj2QC=bRYU-9;$qON!5YxQ
zx%q3p!)ZT2z*o!`-Q`JDZ&SzyySj9zl1G-$R4$$1ym`-GH&!l5FXq=K?Fiofx2Ec5
znfsRf_;^;$GnB?SCk>)IV9S<xQC(K%*__fE#i@Cum{F;Oe>{+5ETk;ZJAQrC&J6FL
z0$KZ@Zlz)@WN1uxKJX~)G}n!S+Sw;w!Z}CzV@1?rYi)|^RHGJZb2U!U;KHy%^w&IQ
zuD!k3s|HohJ$(}?;xop}<<-u(AFdDY{va&Qa(!8ZCY(7jwe~xh9PSp?Qnft7v<Lv0
z-t1`1+VCBD`PxISob?-<q$-^JAz{n<3PEm4(2b{d<R-&owd7|vjwv=ig|ieF7oRm8
zR1_X%xYoGEZ56o<Yoa`hbDJG+z6-b|Qz^^ryd749xTY4bjUU|t;S=PyD_>&ap}>Sf
z2yAsCsh;EtteA_VmTwm33IIW)1!qt<xFa*`O5FJ~ptBYxWw<jNGP%^TH3x0vLGePL
z$v2mTgLer-tB(0~Z}6ak_CbTFQ^+GA@=6MS9SI5?_YT1u-@ZQUvt%0-Z?6(8jdyvX
z%Y=|4b1OfUCHv0By6q$PF=D6`zPJ~F1pkTCSBI!$6PXRdcfGUTHkg07oi1A@-CvDl
zX$VVX`4~r^7CDe^cefzneJtH>{7Tf_$CoV&)t&NRpDm*krt%~!ukZN2N<-&!+Xphr
zoYYEVUz)LsXc$u-Z+vI+<1QuB`k${Y%Z%)fDdIOt9%Xr0nA!6iZ*N?gcU%^s&+CT(
z(~r2?!pReD2Q;xJL#NdUtD>-o)$<$j5kBUdZ<du@S+nYOyn@m(Rt+D^r_Qv}$Wy^}
zqh^mXli(R4PrvY+2q~oE4l6j105QClr^iOKr1AnpEO(VWlV5y%-wa5o*4|f;1JXlY
zC5!pC9Zz?lumg?-L~8qJiDSxEWdJ(f_T`pcrPODMftivwkfyNUkmbG@Sn_lv+Vr5T
zQoH<6sYg3W47P9?ALvSPZh^MpXodAr{dY^ifPJb@f-*U}0XFviaOK;Fw#vtmoY5M)
z)UXJ&Q(v@6Ba~c&-Rj#berE4nczp(`QoKe?FhE<$YkH)BC2)jHn6F4v1gnu=2tIRp
zCa{a#WJG|Ij_wQpJc0VGQ_?TBFZx@bh~QD(9(y2KPw%XQ40+$KDGDWEaBKNSb+=~O
zCqfN-?#pr1ayne4jKH4zHgkWNdq6<QhIiB=OY}5j_+eXPtT%8nQ=vLySsTx4!43B~
z$DQ9AU&kDVBosbm%Vi&DDmd$e&G)to;#rdXyBO{5@+CJ4YhgzF@ux}?3QJ%o?-l-r
z2y+)-4vmopikk0zXGWc(g-hF+D+rYSPK+<C?Jgr98+z(;{dyK3G_De{wBkY>{>3?m
zTFzt`&Px-^f+d;G(c=UHf%3U#n9L8b(K^u=CGf0{3WI8)B2!?`l!_aba)7%Z%H<g6
z-CbyKZ)fFBc_>md{LohTrXI!Muo$!-&eS67Xg;aK%<PVvu>kgToeQw#XWEqZe(7l`
zUkW;_S!H#($@IvDQ>y5EylqYTiQ5+Z0wYpK6oC7a)Tf0RyZ8E6YI*9Ydc1uYe9==l
zBCYjX(mb@loMK-5>tiQ^N})zK@L}g7?#Ks?`tvG3CJr7B%QkbUesQFC#>VMqHZHZ|
zq;pfnN)^pGWG<=jhV1L2G~z?`u}_cfTsLy*0m0TuRd_SJntBe=`e@bY8MV7tXP+MW
zz%yAQ@cW=&9IiJE+#5Lq9=WbnV)#Zg{40s2=*%`X@wh4&mQ<p=aWEB=rti`Moz2}C
zh0kn)?@v)xq1o1M9Yf*@cD4<-c9`%>C{#7kc8jWbz>fDg(~5Ez$JbuDLU31x*uzG8
z(r(#RwcSoEp@r)8jaU$yA{A%k@?oVBO79NnRu_WhG+`8qbh^t*?JN6Zb9mut45^(^
z?s@Y6*5cP;)++Y!xb#xvsmmE!HWGaY$rmyZU!g#D*?Yc%cNx2PKp&Sn>ct#`#f-5W
zuEcsOeDoT~D)!F_zb_j9>5JkzZRFm8YCxq1D%@53RhEi7JN%6hZg{9whGeC4>CQPC
zETqJ1_)%}+^Z6=BJ|<#FrkSY?7^*ZZ4$4K8I+Ux<^o*QzSM>4)<R(ik&YLH6wSS4g
zu{0tLn-TfRnY?II0+PsYt$J~27T0N(?|ZSZErPRzUpseJm)N-Wq7_Fkcyt_!4mIfm
z?==$`kRd0&x;1mVYt2O?UK?|Dno#N;59@turGpByu=GxgaJs^@AF&aNW_f-Rs}-qC
z^31r#_i@cRfFiO`nvtplR2D2h)1*atk5qL!0V3M+&Q)^McklC~zQN>8#~rV97vsG~
z&flz0OGmD(n#g3)vtnmSiCP-OP1>YiBPlO&`ax|$$cy>v4=5M+M;{Qy$)AN9)9?jS
zfpKGx&A9l3u67#;V1rZ6e-%BJI1A9H7xaa=7bpyg@ds9$w`Ty4R(;2f{DQY~1YyX~
ze0|2HZF6{S3Kfz(uazzzktDA{O!3CX<;~wX^g$k2A#j7WR=1R;o}A5jeB8N8A=OML
zA^hvTouV>}2UMl36mh}Znu{80IVCU`W~S595T0i&TGTn(EmpF*dv#~P1LGKAk3)Wi
z6ybrqYsT_kO5a4;E2%kMA!fPTpBu)XH6(@)Rf2Y&TfoVWBP*WDj|a2bMHf8>J4F}i
zF=Ld-*uz`_5R@J^--%lw*0~<wuM>qmy1?Jf8&AJ}#&S}3f*P~`nyD)6#xQaE&fXec
zfQS<~+G;mg-d7(cO4eDK#?IL!HktMB)Cy4TItqU$)w)?;P~&iK&Za_NG*(m{*m!mG
z^H^4qOQ;0h*hl>%qsEu^smA$TW}e`B>m@3lRdTbN*;_B)^U}O>CctV0mu2Rd)4#rY
zKsYoq0@z=rUb;^+yeVYqT{yZGrTX5j$A_pJWY2QIxn#rnAHj(sb6M~uy2wZ>z}K;<
z>XWl$(3P~$at;~&Tu_P}%Af|#qZW=Hx=obGn74azamdJKz0d-p2e2FKf`dNqb-}#D
zc;hACUJ*HoE-$i_{Pn2185<cP*YTI)-c-Bvdh)e=NP%_kF#$Tm!Ne<*dFg00x$4+l
zYsHr4+RZjm?w5=pptQYBZ^dulA9lm)MPcq-o^zY(ck-{D>cvi$ajx%okn6t%AR%?1
z9#nh|Q$6o+k3qS``HX2f3;LpT@V2RKDc#mlqPN;<U(bf+_2-HBzkUvfCC0^81z)60
z914{QL11oX4E(^o28=qj3~j>Fg|W`=q^Z5Kr1M>bFKKs=q@wP;d05mfY7n16HkJf|
bVlh053e05D(L}@T-zcU=7MFmFZVCSZ6#Wry

diff --git a/doc/user/search/img/issues_mrs_shortcut_v14_4.png b/doc/user/search/img/issues_mrs_shortcut_v14_4.png
new file mode 100644
index 0000000000000000000000000000000000000000..2610e6114464bed42c5d296efea2d514a480e856
GIT binary patch
literal 6741
zcmcgxXH-*Ln?A&-^bSFK^MX{BUW9;f0g)<IsRDvXj}ThGp!9Y@iqr%YMUf&R5UPL>
zsR5;kfJnyxL3#@?hwGZT-<|npt@&ownjfd_v(LNt+535)_u21`H8#|tqvoUr0Dw+U
zSIZOtD2&15Eae%nWY>u|1H4cmOm#GYvOew~-~-fE!$1Q7-XznI9Z!SLR6e@a2mqjO
zJ2@!u-o?%UaE_>_rC}Cmx02VG#H~>M;7~coU{>TOjfeb?M1^lYJ~GXZ9-P@ey-dFS
zFsh>SjDpEUc4x{|PmSt3o(Yn-gn}e+8PO6JDbecY?RO0<k>PwkuYU*zeY_28b{yg;
zHfq|NA4}q=jIiRxkmsb2KQlo!7`soQnV}l8XCUV(Biv}A*BGG#9FHM~o1dHgk9YCM
z{`ROXgR_9o>xRHJ3@KjvXb81EI{8+rN821LNEj)f-26cSB=Pxvvx&7hEhc{kP?Y<C
zQW7B+Q=3&+0l<r>Wle<Ppb48O@cv~gqL3a+4g4Xnpv6PU3h-a;i&Z8`^uK-k_DBSH
zF!PVajG_QMDwoBd-xyE~^z!<Kl(uhL$yYn<jUtoxxA;(ZxxhBySiq;>#(whVUA3U~
zd(4w4<mZu_hM>^^;r?z?H$i<>ZD;MfBXTZo6<tD_dU$rCEsDOJSB(Qdjz5K2T-V>g
z<y(Gb*m4y@Y!&TE1LJI?LBT;sKild_6ZH%eeBtD~Ma1*L{##|`jR|09mbJiNHWs#I
zX!c;f$t4L{i99a)^kt}xgjSnpDtL7nN?l<;YtbmImr{}z>oD1T{8n8V^Xof?ZLvpl
zkVf)lA;JYl(f7o_?d8PuXUocnUB8qcrhbNlYbF8MOKU5rS^kim<!()?ZPNx>70p}o
zkwSR94XGC9_QgosxUxI9Rt}j^__=2Pi2D^pGCzmFm4xgI1mH8?llqW!SFGvLQhE0=
zHVsjjG@*LxohdVuo3GMTVk*<!gv#1b4pnisDO!SIh{^8+(*q|oy8L>GNPq1rkzR)Q
zqC?cUyOqanZ@fX#oa9Ub9OAs2d{uhJ?Z>rW-H0en0ZsB8GIct(yUbqHJuf8w@^Pl2
zsDw!S{hI8@34`V;icG<Jsacn_ReE&quRs#15S@fze3p_u@I>pwg$P!YsG1+^J)hP2
z(!+0kR5HOEo_7C%d}?vVBDnEM1jjR(WgFBZh<R#f4B?G2wwjO|LuXR2LR}T;CFX6k
z2crQ7f7bk9t`tiDsbWMGL|;c#7i_PcNK4l+2|gn}Vk}%>rB(>{JdAi9aK4|2>m)40
zDFR~2Y~N@;N5>3JPS@zlf}pG46Ebx>Rll(w!D!9uT=Zzs>!~=Tca{@_mSQSyS*3sX
zCg4K<G!C~xi5Ok~8c5;5zK$2frDq=VnK9mtVz$*h!IqG5NWAjz%UO0DS0ANvC#zq)
z{F(%p6w6FEd<d8HJ(g-!y@u78JR;|Em?t@2pLw%8zTXg#NnCn#2)vhCW40}YQvkz#
z?%q?N-z5Hm_ygKsXa>%KNbq$<LjZ1}e<(3wTa1St|F}T`<kFYhH+L$V=$K>eL)XgH
zc!2jmeiFiu!iQs(U;XK{TOidKo*G3RZIvJA_!lO<f}htatYk@l1_1atMbhN)(W`^y
zx6Q7$PvZ4X9G`Iyjs?$&XgE~_Kj$wl=ny&FxB&oG9|h4zdkYxwwGJDyK&;=!6}-iB
z>wlyk6xshd^)PW~b#iQXCRv>_f<H;DVX|R0BSx0VP1Hy)%-??qb+A%1F=8KXzzFqC
zTO;pnkcLVuC&p^LVS2L6#oog5O^uE3^vcW2>yfM9w&VaHiD50Tmh|KE3yZ?(_e#tL
zP$Dv4o&59a&SxX_t@B|2lXcC;Md&wG1~?zW8&%sInvaj_Cs1+e6oBDrU+l7GJNgLc
zW>6RlZ*QoKOkaSU&`+%qx1uYIlWI`?paF-|02w1S=HLT*TJu<<N=wjqw5};=;|v<|
zUQdw3a&~`gR}X#dG}UOOAjmr|n&>!|Mm~h|>HRV9W&yB7?*nQY4l-B;BY5hkgq#N4
zpx|W5Mu1bw3EBn{LB4wM`w4jofdq$T`g^rXYP8x|F4EQ2bz*PcI{d@N>#<ynzv}|m
z#tjnU97ZNCzEnCd#Wl?S(ilmQNCPCLvr!Jl5~rtIbxEy@BG0t3jqg)!<^#2{hP4Y5
zi$0)r|841h*BsJ#Tz9O<cAp>GOZs|{AmJ|90|}Q^$h&Fcd6zj@tZM<hGy#zek@e*j
znc!bu3%0N8{qh2~*zwM&i{iW0m$&ddk25%rEl;v0`s?<TRHat7>nQzTnrDZJa@Kxz
zBmAL_uM)sbbHL^%sEXnWw?uDm9oT*sU63W@c};mXhmB|5+8tGK0u+U}#rkK5NAdg^
zb~JIJm|o-~4|Ub5ctRokz=@Led+nE}a2nG$x5Z+;G~LtJZK(%`=(Kw2S-%U9V&L)h
z+9LeO(3fz!#@F}rCTQ-zUP69Kfj{<}Q~=u!VR17MtM2()tbxsF%4f6Ya6u<cZ{TT^
zJgkjJ9vy^RZP9NE7PG{i1Ck;SSHKCO=l=WX{|_hWU#_-ni{0i~`q4d=%yJ+_zS1~t
z^(|9<PuUHyf<UgYJ%@_<ErbA8Q1Bik{yytG_{zfDw`x+#_NnSkD^d~48Cp<Ne2vOd
zYoVz<)%Nh%NW6E;s=S?CwSg$kbz<ITpL%KWQU;+kU*$L6drx#aF7m3Es6iI-^>T;1
z`|>7ByA;EOI;dFvGoKXC8q&fi-+ExEFab)0`lxXj5qBUG^Vdf?_h_g8AlnHeIm>x(
zNtfti-`uZ;&2Qu)^t<+}<tTn@4%|O_=(JrgHs3$9<HsF7r8VhqudW{Upv@r?(koF2
z8eN2#P!&*Wj&8;1E*DD9=L#-vNX@+SAN(?BC2X87B!N+_xk;kEiN$f_F3~-6S)Yhv
z##{+|aLUmZ!nWL+o)=$N)Xj?#=x;LMXcLs&DxxCdDEB>hynpAf?)CAAf*+6_zaVmY
z@&s}f1Tuvbo}<s8GddW2_$8Q&&BE4aV-xYoe8|kq%!#Ku$pPa16e$LV9#d=QAf<Xv
z*ul&esm+Sy>zItlnchT6W%;YvB7}a2NAVEsnJRavl#bW+Q*@Bh#IxT4#+}$x?UB=3
zt2#<$Gc&93-a^ii3W<+)szo!0gc(79j1H4xkPA|-J(v1j|4QH~syhf)MD+TQ(-K~7
z^E^fzQkpmBOrrJ6AAoLpMmWvc2WTpPdj&6<Ijczf0kwpS%shREeaJ^&!QUpPs|WJU
zjj1+LxoQhiGMBKZ{b@vH(&KtlEO-0(<qQYQ7kH`gmV8O$0v|6;Ib_nM5k)q!@OOu%
zXzKK}Q`|rZOcW|y4+pGdDDTVFPH-GS6}cG~zs2y;>GB&rXoLI<%=5ni^%gR*{9#~1
z)(9Pjy7OKvg&`MI`QcNhMO*uv1UQ8t<037i8w2EYjMWLEr_7sS6WG#a-=NHWD}1VM
zYoqr>4PE>-)ZI;vD`W9*Nj6!7!#u(_NGjUR^Hv?7yMyn2kmF_%3z{QGSDI|D;i5d<
zoy=Ugpwx_&Qs^#v5!TUwr7$U;8XB8eY3Aa`pG1{jPU;suktq^37AdI+AHkH|{Gn2i
z>DrH%5fT?MMyRG*Tv;8i;v#nKwpMpaXWo>u{jGP)3NXxJqm~uQ0s;J895MvCL|fl+
zyDzN}9@0sxo%(sla_N?k|5lKdS(u}q-4*qzamvRVPdixi`GD8gu@SblhmuaU!Ef=d
zlvUm=9sD___HmW)nMz&f8>nb!t$9YYSf{k22#f`iNUW>C`8jD~0j4FE#RnfRiB$jG
zUFUJjH?>d7hUZl{)4EH%J&<QzVu#-B5_cI0bp{*37urPKL_J_}wuQ*i+_#x*S-JNk
z@OY!P1cA}fQ@oTBfZEHwV2<W=UI_9nm^E8c5hztrJ2jMij<~=|-IrAVTR)M*-&(zf
zlGVY%7BW<Wxq*)??)iA<aps5qVVa_h8<)--i$9;1`HE#|d>U`;Us~)3VY?O-(z%5v
zBtDwq+5h6Dn%Bj#HQseh_W(|DW?Kr3URO{5A8{2A4F;osWAIj2M|Y-lJxto}J^`by
z^H=2cE!=rpYl;`Csi_&RVpdR47;YFD83E&^A+s+=(bz`Ra5Ie6@<iPO6#pcO{)y$$
zdiY!(5n;EZvU*6Y;EXE|ZaO>b-_sCwj)YF9tdh_@Fbsg!(WY3gT-nC=rNNC*VGgdZ
zHL)<*d_<q!&&mT;g}DXF`&5*y=+?#xdbAhDKL@c_qyEJSiJ8Zexo8F_hP(UBZhMFX
z^?1$<OYq;C=c6m$=W2X^ZBJHaLuch4N<S+&G)02s=hdu&oLc{Y@7TxHSwA~2unVQJ
z>q=2CBb3TB95$%YoUr#oLB7g!S#>YknKiQX{p2S4>tD1=XQHpVoQJ$qFODCU7DEms
zL;PX;yVg?IoBI#6|Cps(T2g)&nys|=c`fZAqt3lR8&W!(VQcXvpq?(wg1KzS+#@kG
z)O!GF+GWzilRq}7x`}zHx;@aB8>9=8`T+7-|HjM#Lz49XJ7RIIJJ6Xt<L@*^;8f?n
zyu{=do<cWbQxPbHj*73-@vHSqzuHe@^M{j~jvVH<$IZiGue|I3Fbk@!6+yt*9iLn+
z9x7!{C{KI(<W@~-@57#wE~bphyGb(63p#Tj6Yug%#)o%u%_s5EXR}ca+CCz+CTXWr
z%GR>2Pj$(_Q1jCUQl#5z1_I$P56vbEoK-({V0H(;EVm-@ntWPHszr6#*!*~h&?4^9
znHHQu-_<*IZR=lEug~{k7exLH1yvrV*rK&IjkjXxY@<5^Su_Y1`~Dj${V7=xx@7Z>
zyLaYyu5a;N>kyg?)4Y>xunyhenAbJ-zxvEpHos?AqKJEH4eLo#Ep(EB-pr16?g70{
zqpPiD!Ed%hwx7TMYv6YW>n!+0q-b;A)|<8I`|+~JV=BmjrF~QUG7v>mmtiC$68_O_
zl7ui-%MCqWW1Tj`jSFykYsT1KC*WRCzj`~(L0;!lO~Qo!-9A+_=*^ty&hc}b<X!oe
zOCcnayg%+Yn4>N54ADJ;=xcK#M)_X?$-BPDprFw!!JBR`An#!LU+IKluHhO<HCLO$
z?g&uJzbL=gHCO&(03ts3nRR{StI<|zx62NXfvx~@uurQX@rq3;*QfYr<;bSdC#o!m
zY=~}-`IC_=IvQUs&Q^)e=8NyL_iQ%9YPyhpDt<}c6UXBo@l`F~)D7U@(XFg7Ohbj8
z1ynRaRm}>^|EQ8OZs_2B4~FL4Ci4KxF)WO3p|`}|j6{Z{LTpEoK!uQ@&sk9Ya{YG#
z_g@Y(f0xTCjWlL<_iV!3OF}5ltqy*JWm(d%KH242=4)<FPHONqvn%g8AF}yc3+tls
zwLKD^>6>YJM#OVfwCbFbk}|rrvw|9JXY)im19hWlS&d+@rv$NuKu*`fh6VadC9*fo
zYr-5mo8Q1EJW=~`<6&!_3KKZVjpQ?ChlyeDd@f+_+&L;nm3m*eku1$Tm4-N&z|mxi
zsL2l#hK6Rxf(s&NJ|+Z-a?M$C#&-;NvlI8^9hb~I3NIu`x{M;lM@o;1ya;V!HTxlX
znNA*)EVeXz+;hHds0wEESH3~1L1`PLV<Ie@n?YI?S3z#|ak-mc(NuP$`$g7cbsi&}
z_sg7=feK|Y+}z>1<JgM)u2PR<@zBs>by$x^$X;Ko@~sX1mgI|jypKaK_@jw?sc#Y{
zjc}z;m8&TyGL5ssJK0dkvNEn~yN!mk934_yJ^o?5gty{lvy0tb3#a)WZ&6k?Ge#|4
zsQn^@zQf+Kn`1M_SfvV8nn##z+`YVaZ{@{)HH}7kbiDiJ9nsX7i_yj<B?F!-N+s0;
zN^XNn=l4vBki>(e@GQ<(P6N*KAr4c>lBLY15%(l)ew9M!v!1!!93dI6S_KPXV_Xzj
zGfp~A3)@nfki2%=H2w-=O&b;>hk5=-^I+JkRiBi=XNl@-FW=~u9a&X9Xywi~wKe!8
zkLVjv;)ocRia>NFYOk4`zR7j#L+k1=V^Rof_91I``ID>r_b2f_cF&s*6;#VRx!uQo
zykB3#l3Hb8Z5=ijTMBidH*GFPYGaq8@vly3I^_92JuF+N>+n$zZ_X^${H2~0EYUr+
zItyXQjtrzH=Du?B4V6V3CQ9C(LW)}{>8s@_?5d`;VF=rWtM%%b72C2P@P~dgMrw3=
zTcSK{WDS7<LC%l1*Xx=FFEzJB(^UQ!YB2kg8f4Cw-n32hy0=t<7>3ZX*Bl%{vV`|c
zJ#swqs#bSzUc63KC0`xW6J*hRE4ndk?pQFkLwY4tokeMRw^vDf<WVR+-n2V~OJN*V
z!cyFb9n{X3$UchT^mYwBY;AW&?AJZFIl6sLvd&b^;K%LKDh%;fW;aR2I-$v?kihd!
z#>CBu!E(vnY;0Ufzsap78Anjy`mC0#o+mx`l<K~phXCDVDSxVAzO;T0nfsa2I7b_z
zaw8@8#s!_b<34=<OmdTi`x`GhS#Ay#O9g_<ypx5nZ-L^#fl1QR?(FvVaJI$t{Cr3D
z&i?*ac3ygt!d??O7EY0L_8%j<qA|Lo#+Nzd@e5FGBt@}+H1Zx#@&6<@bb^Y`0`Ch>
zmicisJL`tRf0H^Vdg5J2XUT1$asBUct3y$F%+0rVAK7Ph*Oxe)5odC<{v$v`sNZFL
z>RqpnP=9?>9Vfb#)<U2^o(A#8RoY?{m7lYYfYw2waquZSt7v!)X{c>KcqiWaDDgDW
zYw7a{>kduWJ*lvN*Aa^UNk@?XrX!Tdx%Xy6J~e;vm{_#=6t+>js={m3Hr{1J=kjz>
zA7RY*R7}5&=|NgL<=_!Epx`j#@>yq%g!mE3rnR>=yJ2gaG%}qm!z2Fgd$Nf27c&=j
zB>nH5$Oj(NzvM$2l<3TsG?dtDUfPR(j(LbpcKzML5UW2w9C~>rs&0RO0Abu))cp*{
zO9Sr;hJLmG&?d(x5u=L@F5u{xNa+%A3!<D_vHnXi#Fz)w{saYsFxxz%yFZ&Ynuzeu
zyZW+(Fk0#3#WH9^R4Sg!Cg%g|uXVA0z5DH4($7yAB7?zFY9&qdGL48exji&n^T_nz
zWz$w6>=#3fMy@7Bmc{r5Uh`*jL3g;Me0<(<E;WaxyA{V4f$+N|&|h2@A2i7V&o`$U
z4E3uq&)JPIgx+kZaHW=2wdj43l{G0dw8M?=<NOZ-5Oat4x2CSW@+I)TD6pz=^m>Zx
zPPm|&tc|06w+~zqXK`zOFa$}4y2GwHA|Ky+q=$Ox6u{RuT|D=>r<3pUP|ZPZ8iR;^
zrziWaqE6Yw7m0M8H)Vxl#t#phW{<ODh!R<CRis_o`z_;QEx4uUf`6*?<175ePaOOq
za^eC(ylgaPJ}`2i`25lWdx1dRkj&hA<~KLrwDr5xe-iQVT;)NZ1X=j6P%m?$<d-)F
zaR|}kx&XC|K2K@f(Jn5<ry<7@;qWrScb$_$7X<N+W~B;F$GM>LB1KXJ3v2OM<Z?F#
zOuPgtQh>e}{Fm>IgKoEc=6{tT@pDCkNweo6N8})6NXR{LFf9q;Qwv?pS3|k;DBi+G
zm<1jm9rE|DHXk?DH#L#;e{B$ei-EIXLQQ|2l^NYtwlP2d{9tRue#L@47V`d$kP5**
zY_I)W&@p*~FpQpV)rO=CSGu4Mwo6fG_?g+bx-%@C!MzFJ1c9UjQvK>{)%ITu<eLIN
z^lX@nj7xWc?SqNJ(cLvXADGHa5^Nax;5)7Cn_o+qY$C81Gm<nLwc0zt{AqP(d*4YS
zlXY6&H@CL08_`F)p$iognBQVX?U3>e#2C!aKVymDk8z@0mHV^CXY~UcVdEBs^_q>;
z>%7me-9C9q>zfOEF&SjodGhfi<}Jak%itD@;`5(j8%;UlMgro-$wpdWkHy|RdIgum
o^?^xJdL>e;AUN<3UMwBaP*0p)5dM^LvRwq|X&Y*lX*xvw8!aMux&QzG

literal 0
HcmV?d00001

diff --git a/doc/user/search/index.md b/doc/user/search/index.md
index f741743e6be..a0ce026f79c 100644
--- a/doc/user/search/index.md
+++ b/doc/user/search/index.md
@@ -35,7 +35,7 @@ You can also filter the results using the search and filter field, as described
 GitLab shows shortcuts to issues and merge requests created by you or assigned to you
 in the search field in the upper right corner:
 
-![shortcut to your issues and merge requests](img/issues_mrs_shortcut.png)
+![shortcut to your issues and merge requests](img/issues_mrs_shortcut_v14_4.png)
 
 ### Filter issue and merge request lists
 
@@ -290,7 +290,7 @@ To start a search, type into the search bar on the top-right of the screen. You
 in all GitLab and may also see the options to search in a group or project if you are in the
 group or project dashboard.
 
-![basic search](img/basic_search.png)
+![basic search](img/basic_search_v14_4.png)
 
 After the results are returned, you can modify the search, select a different type of data to
 search, or choose a specific group or project.
diff --git a/lib/api/users.rb b/lib/api/users.rb
index f16e1148618..ce0a0e9b502 100644
--- a/lib/api/users.rb
+++ b/lib/api/users.rb
@@ -1062,6 +1062,7 @@ module API
         requires :credit_card_expiration_year, type: Integer, desc: 'The year the credit card expires'
         requires :credit_card_holder_name, type: String, desc: 'The credit card holder name'
         requires :credit_card_mask_number, type: String, desc: 'The last 4 digits of credit card number'
+        requires :credit_card_type, type: String, desc: 'The credit card network name'
       end
       put ":user_id/credit_card_validation", feature_category: :users do
         authenticated_as_admin!
diff --git a/lib/gitlab/usage/metric.rb b/lib/gitlab/usage/metric.rb
index 5b1ac189c13..24e044c5740 100644
--- a/lib/gitlab/usage/metric.rb
+++ b/lib/gitlab/usage/metric.rb
@@ -25,6 +25,10 @@ module Gitlab
         unflatten_key_path(intrumentation_object.instrumentation)
       end
 
+      def with_suggested_name
+        unflatten_key_path(intrumentation_object.suggested_name)
+      end
+
       private
 
       def unflatten_key_path(value)
diff --git a/lib/gitlab/usage/metrics/names_suggestions/generator.rb b/lib/gitlab/usage/metrics/names_suggestions/generator.rb
index b47dc5689d4..96ee3e1a2a7 100644
--- a/lib/gitlab/usage/metrics/names_suggestions/generator.rb
+++ b/lib/gitlab/usage/metrics/names_suggestions/generator.rb
@@ -18,6 +18,10 @@ module Gitlab
 
             private
 
+            def instrumentation_metrics
+              ::Gitlab::UsageDataMetrics.suggested_names
+            end
+
             def count(relation, column = nil, batch: true, batch_size: nil, start: nil, finish: nil)
               Gitlab::Usage::Metrics::NameSuggestion.for(:count, column: column, relation: relation)
             end
diff --git a/lib/gitlab/usage_data.rb b/lib/gitlab/usage_data.rb
index dd66f9133bb..0d469c8b752 100644
--- a/lib/gitlab/usage_data.rb
+++ b/lib/gitlab/usage_data.rb
@@ -45,23 +45,10 @@ module Gitlab
         clear_memoized
 
         with_finished_at(:recording_ce_finished_at) do
-          license_usage_data
-            .merge(system_usage_data_license)
-            .merge(system_usage_data_settings)
-            .merge(system_usage_data)
-            .merge(system_usage_data_monthly)
-            .merge(system_usage_data_weekly)
-            .merge(features_usage_data)
-            .merge(components_usage_data)
-            .merge(object_store_usage_data)
-            .merge(topology_usage_data)
-            .merge(usage_activity_by_stage)
-            .merge(usage_activity_by_stage(:usage_activity_by_stage_monthly, monthly_time_range_db_params))
-            .merge(analytics_unique_visits_data)
-            .merge(compliance_unique_visits_data)
-            .merge(search_unique_visits_data)
-            .merge(redis_hll_counters)
-            .deep_merge(aggregated_metrics_data)
+          usage_data = usage_data_metrics
+          usage_data = usage_data.with_indifferent_access.deep_merge(instrumentation_metrics.with_indifferent_access) if Feature.enabled?(:usage_data_instrumentation)
+
+          usage_data
         end
       end
 
@@ -729,6 +716,30 @@ module Gitlab
 
       private
 
+      def usage_data_metrics
+        license_usage_data
+          .merge(system_usage_data_license)
+          .merge(system_usage_data_settings)
+          .merge(system_usage_data)
+          .merge(system_usage_data_monthly)
+          .merge(system_usage_data_weekly)
+          .merge(features_usage_data)
+          .merge(components_usage_data)
+          .merge(object_store_usage_data)
+          .merge(topology_usage_data)
+          .merge(usage_activity_by_stage)
+          .merge(usage_activity_by_stage(:usage_activity_by_stage_monthly, monthly_time_range_db_params))
+          .merge(analytics_unique_visits_data)
+          .merge(compliance_unique_visits_data)
+          .merge(search_unique_visits_data)
+          .merge(redis_hll_counters)
+          .deep_merge(aggregated_metrics_data)
+      end
+
+      def instrumentation_metrics
+        Gitlab::UsageDataMetrics.uncached_data # rubocop:disable UsageData/LargeTable
+      end
+
       def metric_time_period(time_period)
         time_period.present? ? '28d' : 'none'
       end
diff --git a/lib/gitlab/usage_data_metrics.rb b/lib/gitlab/usage_data_metrics.rb
index 1ef201121d9..48f695d5db1 100644
--- a/lib/gitlab/usage_data_metrics.rb
+++ b/lib/gitlab/usage_data_metrics.rb
@@ -5,7 +5,17 @@ module Gitlab
     class << self
       # Build the Usage Ping JSON payload from metrics YAML definitions which have instrumentation class set
       def uncached_data
-        ::Gitlab::Usage::Metric.all.map(&:with_value).reduce({}, :deep_merge)
+        build_payload(:with_value)
+      end
+
+      def suggested_names
+        build_payload(:with_suggested_name)
+      end
+
+      private
+
+      def build_payload(method_symbol)
+        ::Gitlab::Usage::Metric.all.map(&method_symbol).reduce({}, :deep_merge)
       end
     end
   end
diff --git a/lib/gitlab/usage_data_non_sql_metrics.rb b/lib/gitlab/usage_data_non_sql_metrics.rb
index 1ff4588d091..f425ea92729 100644
--- a/lib/gitlab/usage_data_non_sql_metrics.rb
+++ b/lib/gitlab/usage_data_non_sql_metrics.rb
@@ -6,7 +6,10 @@ module Gitlab
 
     class << self
       def uncached_data
-        super.with_indifferent_access.deep_merge(instrumentation_metrics_queries.with_indifferent_access)
+        # instrumentation_metrics is already included with feature flag enabled
+        return super if Feature.enabled?(:usage_data_instrumentation)
+
+        super.with_indifferent_access.deep_merge(instrumentation_metrics.with_indifferent_access)
       end
 
       def add_metric(metric, time_frame: 'none')
@@ -50,7 +53,7 @@ module Gitlab
 
       private
 
-      def instrumentation_metrics_queries
+      def instrumentation_metrics
         ::Gitlab::Usage::Metric.all.map(&:with_instrumentation).reduce({}, :deep_merge)
       end
     end
diff --git a/lib/gitlab/usage_data_queries.rb b/lib/gitlab/usage_data_queries.rb
index f64da2fbf13..171b0a22820 100644
--- a/lib/gitlab/usage_data_queries.rb
+++ b/lib/gitlab/usage_data_queries.rb
@@ -6,7 +6,10 @@ module Gitlab
   class UsageDataQueries < UsageData
     class << self
       def uncached_data
-        super.with_indifferent_access.deep_merge(instrumentation_metrics_queries.with_indifferent_access)
+        # instrumentation_metrics is already included with feature flag enabled
+        return super if Feature.enabled?(:usage_data_instrumentation)
+
+        super.with_indifferent_access.deep_merge(instrumentation_metrics.with_indifferent_access)
       end
 
       def add_metric(metric, time_frame: 'none')
@@ -71,7 +74,7 @@ module Gitlab
 
       private
 
-      def instrumentation_metrics_queries
+      def instrumentation_metrics
         ::Gitlab::Usage::Metric.all.map(&:with_instrumentation).reduce({}, :deep_merge)
       end
     end
diff --git a/lib/gitlab/utils/usage_data.rb b/lib/gitlab/utils/usage_data.rb
index d46210f6efe..0c4d767f126 100644
--- a/lib/gitlab/utils/usage_data.rb
+++ b/lib/gitlab/utils/usage_data.rb
@@ -43,8 +43,13 @@ module Gitlab
       HISTOGRAM_FALLBACK = { '-1' => -1 }.freeze
       DISTRIBUTED_HLL_FALLBACK = -2
       MAX_BUCKET_SIZE = 100
+      INSTRUMENTATION_CLASS_FALLBACK = -100
 
       def add_metric(metric, time_frame: 'none')
+        # Results of this method should be overwritten by instrumentation class values
+        # -100 indicates the metric was not properly merged.
+        return INSTRUMENTATION_CLASS_FALLBACK if Feature.enabled?(:usage_data_instrumentation)
+
         metric_class = "Gitlab::Usage::Metrics::Instrumentations::#{metric}".constantize
 
         metric_class.new(time_frame: time_frame).value
diff --git a/locale/gitlab.pot b/locale/gitlab.pot
index 8bdaca3e728..13ef153a368 100644
--- a/locale/gitlab.pot
+++ b/locale/gitlab.pot
@@ -8644,9 +8644,6 @@ msgstr ""
 msgid "Configure advanced permissions, Large File Storage, and two-factor authentication settings."
 msgstr ""
 
-msgid "Configure approvals by authors and committers on all projects."
-msgstr ""
-
 msgid "Configure existing installation"
 msgstr ""
 
@@ -10909,12 +10906,6 @@ msgstr ""
 msgid "Define a custom pattern with cron syntax"
 msgstr ""
 
-msgid "Define approval rules."
-msgstr ""
-
-msgid "Define approval rules. %{linkStart}Learn more.%{linkEnd}"
-msgstr ""
-
 msgid "Define custom rules for what constitutes spam, independent of Akismet"
 msgstr ""
 
@@ -21561,6 +21552,15 @@ msgstr ""
 msgid "MergeRequestAnalytics|Time to merge"
 msgstr ""
 
+msgid "MergeRequestApprovals|Define approval rules and settings to ensure %{link_start}separation of duties%{link_end} for new merge requests."
+msgstr ""
+
+msgid "MergeRequestApprovals|Enforce %{link_start}separation of duties%{link_end} for all projects."
+msgstr ""
+
+msgid "MergeRequestApprovals|Enforce %{separationLinkStart}separation of duties%{separationLinkEnd} for all projects. %{learnLinkStart}Learn more.%{learnLinkEnd}"
+msgstr ""
+
 msgid "MergeRequestDiffs|Commenting on lines %{selectStart}start%{selectEnd} to %{end}"
 msgstr ""
 
@@ -26071,9 +26071,6 @@ msgstr ""
 msgid "Profiles| You are going to change the username %{currentUsernameBold} to %{newUsernameBold}. Profile and projects will be redirected to the %{newUsername} namespace but this redirect will expire once the %{currentUsername} namespace is registered by another user or group. Please update your Git repository remotes as soon as possible."
 msgstr ""
 
-msgid "Profiles|\"Busy\" will be shown next to your name"
-msgstr ""
-
 msgid "Profiles|%{provider} Active"
 msgstr ""
 
@@ -26101,6 +26098,9 @@ msgstr ""
 msgid "Profiles|An error occurred while updating your username, please try again."
 msgstr ""
 
+msgid "Profiles|An indicator appears next to your name and avatar"
+msgstr ""
+
 msgid "Profiles|Avatar cropper"
 msgstr ""
 
@@ -31294,10 +31294,10 @@ msgstr ""
 msgid "SetPasswordToCloneLink|set a password"
 msgstr ""
 
-msgid "SetStatusModal|A busy indicator is shown next to your name and avatar."
+msgid "SetStatusModal|Add status emoji"
 msgstr ""
 
-msgid "SetStatusModal|Add status emoji"
+msgid "SetStatusModal|An indicator appears next to your name and avatar"
 msgstr ""
 
 msgid "SetStatusModal|Busy"
@@ -39888,12 +39888,18 @@ msgstr ""
 msgid "can only have one escalation policy"
 msgstr ""
 
+msgid "can't be nil"
+msgstr ""
+
 msgid "can't be the same as the source project"
 msgstr ""
 
 msgid "can't include: %{invalid_storages}"
 msgstr ""
 
+msgid "can't reference a branch that does not exist"
+msgstr ""
+
 msgid "cannot be a date in the past"
 msgstr ""
 
@@ -40269,6 +40275,12 @@ msgstr ""
 msgid "container_name cannot be larger than %{max_length} chars"
 msgstr ""
 
+msgid "contains URLs that exceed the 1024 character limit (%{urls})"
+msgstr ""
+
+msgid "contains invalid URLs (%{urls})"
+msgstr ""
+
 msgid "contribute to this project."
 msgstr ""
 
@@ -40337,6 +40349,12 @@ msgstr ""
 msgid "does not have a supported extension. Only %{extension_list} are supported"
 msgstr ""
 
+msgid "does not match dast_site.project"
+msgstr ""
+
+msgid "does not match dast_site_validation.project"
+msgstr ""
+
 msgid "download it"
 msgstr ""
 
@@ -40390,6 +40408,9 @@ msgstr ""
 msgid "example.com"
 msgstr ""
 
+msgid "exceeds the %{max_value_length} character limit"
+msgstr ""
+
 msgid "exceeds the limit of %{bytes} bytes"
 msgstr ""
 
@@ -41068,6 +41089,12 @@ msgstr ""
 msgid "must be unique by status and elapsed time within a policy"
 msgstr ""
 
+msgid "must have a repository"
+msgstr ""
+
+msgid "must match %{association}.project_id"
+msgstr ""
+
 msgid "my-awesome-group"
 msgstr ""
 
diff --git a/spec/frontend/vue_shared/components/runner_instructions/runner_instructions_modal_spec.js b/spec/frontend/vue_shared/components/runner_instructions/runner_instructions_modal_spec.js
index 7f2a90a864a..8536ffed573 100644
--- a/spec/frontend/vue_shared/components/runner_instructions/runner_instructions_modal_spec.js
+++ b/spec/frontend/vue_shared/components/runner_instructions/runner_instructions_modal_spec.js
@@ -52,7 +52,7 @@ describe('RunnerInstructionsModal component', () => {
   const findBinaryInstructions = () => wrapper.findByTestId('binary-instructions');
   const findRegisterCommand = () => wrapper.findByTestId('register-command');
 
-  const createComponent = (options = {}) => {
+  const createComponent = ({ props, ...options } = {}) => {
     const requestHandlers = [
       [getRunnerPlatformsQuery, runnerPlatformsHandler],
       [getRunnerSetupInstructionsQuery, runnerSetupInstructionsHandler],
@@ -64,6 +64,8 @@ describe('RunnerInstructionsModal component', () => {
       shallowMount(RunnerInstructionsModal, {
         propsData: {
           modalId: 'runner-instructions-modal',
+          registrationToken: 'MY_TOKEN',
+          ...props,
         },
         localVue,
         apolloProvider: fakeApollo,
@@ -119,18 +121,30 @@ describe('RunnerInstructionsModal component', () => {
       expect(instructions).toBe(installInstructions);
     });
 
-    it('register command is shown', () => {
+    it('register command is shown with a replaced token', () => {
       const instructions = findRegisterCommand().text();
 
-      expect(instructions).toBe(registerInstructions);
+      expect(instructions).toBe(
+        'sudo gitlab-runner register --url http://gdk.test:3000/ --registration-token MY_TOKEN',
+      );
+    });
+
+    describe('when a register token is not shown', () => {
+      beforeEach(async () => {
+        createComponent({ props: { registrationToken: undefined } });
+        await nextTick();
+      });
+
+      it('register command is shown without a defined registration token', () => {
+        const instructions = findRegisterCommand().text();
+
+        expect(instructions).toBe(registerInstructions);
+      });
     });
   });
 
   describe('after a platform and architecture are selected', () => {
-    const {
-      installInstructions,
-      registerInstructions,
-    } = mockGraphqlInstructionsWindows.data.runnerSetup;
+    const { installInstructions } = mockGraphqlInstructionsWindows.data.runnerSetup;
 
     beforeEach(async () => {
       runnerSetupInstructionsHandler.mockResolvedValue(mockGraphqlInstructionsWindows);
@@ -158,7 +172,9 @@ describe('RunnerInstructionsModal component', () => {
     it('register command is shown', () => {
       const command = findRegisterCommand().text();
 
-      expect(command).toBe(registerInstructions);
+      expect(command).toBe(
+        './gitlab-runner.exe register --url http://gdk.test:3000/ --registration-token MY_TOKEN',
+      );
     });
   });
 
diff --git a/spec/lib/gitlab/usage/metric_spec.rb b/spec/lib/gitlab/usage/metric_spec.rb
index ea8d1a135a6..19d2d3048eb 100644
--- a/spec/lib/gitlab/usage/metric_spec.rb
+++ b/spec/lib/gitlab/usage/metric_spec.rb
@@ -45,4 +45,10 @@ RSpec.describe Gitlab::Usage::Metric do
       expect(described_class.new(issue_count_metric_definiton).with_instrumentation).to eq({ counts: { issues: "SELECT COUNT(\"issues\".\"id\") FROM \"issues\"" } })
     end
   end
+
+  describe '#with_suggested_name' do
+    it 'returns key_path metric with the corresponding generated query' do
+      expect(described_class.new(issue_count_metric_definiton).with_suggested_name).to eq({ counts: { issues: 'count_issues' } })
+    end
+  end
 end
diff --git a/spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb b/spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb
index 0f95da74ff9..dbbc718e147 100644
--- a/spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb
+++ b/spec/lib/gitlab/usage/metrics/names_suggestions/generator_spec.rb
@@ -25,10 +25,30 @@ RSpec.describe Gitlab::Usage::Metrics::NamesSuggestions::Generator do
     end
 
     context 'for count with default column metrics' do
-      it_behaves_like 'name suggestion' do
-        # corresponding metric is collected with count(Board)
-        let(:key_path) { 'counts.boards' }
-        let(:name_suggestion) { /count_boards/ }
+      context 'with usage_data_instrumentation feature flag' do
+        context 'when enabled' do
+          before do
+            stub_feature_flags(usage_data_instrumentation: true)
+          end
+
+          it_behaves_like 'name suggestion' do
+            # corresponding metric is collected with ::Gitlab::UsageDataMetrics.suggested_names
+            let(:key_path) { 'counts.boards' }
+            let(:name_suggestion) { /count_boards/ }
+          end
+        end
+
+        context 'when disabled' do
+          before do
+            stub_feature_flags(usage_data_instrumentation: false)
+          end
+
+          it_behaves_like 'name suggestion' do
+            # corresponding metric is collected with count(Board)
+            let(:key_path) { 'counts.boards' }
+            let(:name_suggestion) { /count_boards/ }
+          end
+        end
       end
     end
 
diff --git a/spec/lib/gitlab/usage_data_metrics_spec.rb b/spec/lib/gitlab/usage_data_metrics_spec.rb
index ee0cfb1407e..c3bec5fff58 100644
--- a/spec/lib/gitlab/usage_data_metrics_spec.rb
+++ b/spec/lib/gitlab/usage_data_metrics_spec.rb
@@ -76,4 +76,16 @@ RSpec.describe Gitlab::UsageDataMetrics do
       end
     end
   end
+
+  describe '.suggested_names' do
+    subject { described_class.suggested_names }
+
+    let(:suggested_names) do
+      ::Gitlab::Usage::Metric.all.map(&:with_suggested_name).reduce({}, :deep_merge)
+    end
+
+    it 'includes Service Ping suggested names' do
+      expect(subject).to match_array(suggested_names)
+    end
+  end
 end
diff --git a/spec/lib/gitlab/usage_data_spec.rb b/spec/lib/gitlab/usage_data_spec.rb
index 833bf260019..ae1c0eceadb 100644
--- a/spec/lib/gitlab/usage_data_spec.rb
+++ b/spec/lib/gitlab/usage_data_spec.rb
@@ -80,6 +80,12 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
         end
       end
     end
+
+    it 'allows indifferent access' do
+      allow(::Gitlab::UsageDataCounters::HLLRedisCounter).to receive(:unique_events).and_return(1)
+      expect(subject[:search_unique_visits][:search_unique_visits_for_any_target_monthly]).to eq(1)
+      expect(subject[:search_unique_visits]['search_unique_visits_for_any_target_monthly']).to eq(1)
+    end
   end
 
   describe 'usage_activity_by_stage_package' do
@@ -428,7 +434,6 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
       end
 
       expect(described_class.usage_activity_by_stage_plan({})).to include(
-        issues: 3,
         notes: 2,
         projects: 2,
         todos: 2,
@@ -439,7 +444,6 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
         projects_jira_dvcs_server_active: 2
       )
       expect(described_class.usage_activity_by_stage_plan(described_class.monthly_time_range_db_params)).to include(
-        issues: 2,
         notes: 1,
         projects: 1,
         todos: 1,
@@ -450,6 +454,44 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
         projects_jira_dvcs_server_active: 1
       )
     end
+
+    context 'with usage_data_instrumentation feature flag' do
+      context 'when enabled' do
+        it 'merges the data from instrumentation classes' do
+          stub_feature_flags(usage_data_instrumentation: true)
+
+          for_defined_days_back do
+            user = create(:user)
+            project = create(:project, creator: user)
+            create(:issue, project: project, author: user)
+            create(:issue, project: project, author: User.support_bot)
+          end
+
+          expect(described_class.usage_activity_by_stage_plan({})).to include(issues: Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+          expect(described_class.usage_activity_by_stage_plan(described_class.monthly_time_range_db_params)).to include(issues: Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+
+          uncached_data = described_class.uncached_data
+          expect(uncached_data[:usage_activity_by_stage][:plan]).to include(issues: 3)
+          expect(uncached_data[:usage_activity_by_stage_monthly][:plan]).to include(issues: 2)
+        end
+      end
+
+      context 'when disabled' do
+        it 'does not merge the data from instrumentation classes' do
+          stub_feature_flags(usage_data_instrumentation: false)
+
+          for_defined_days_back do
+            user = create(:user)
+            project = create(:project, creator: user)
+            create(:issue, project: project, author: user)
+            create(:issue, project: project, author: User.support_bot)
+          end
+
+          expect(described_class.usage_activity_by_stage_plan({})).to include(issues: 3)
+          expect(described_class.usage_activity_by_stage_plan(described_class.monthly_time_range_db_params)).to include(issues: 2)
+        end
+      end
+    end
   end
 
   describe 'usage_activity_by_stage_release' do
@@ -466,17 +508,53 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
         deployments: 2,
         failed_deployments: 2,
         releases: 2,
-        successful_deployments: 2,
-        releases_with_milestones: 2
+        successful_deployments: 2
       )
       expect(described_class.usage_activity_by_stage_release(described_class.monthly_time_range_db_params)).to include(
         deployments: 1,
         failed_deployments: 1,
         releases: 1,
-        successful_deployments: 1,
-        releases_with_milestones: 1
+        successful_deployments: 1
       )
     end
+
+    context 'with usage_data_instrumentation feature flag' do
+      before do
+        for_defined_days_back do
+          user = create(:user)
+          create(:deployment, :failed, user: user)
+          release = create(:release, author: user)
+          create(:milestone, project: release.project, releases: [release])
+          create(:deployment, :success, user: user)
+        end
+      end
+
+      context 'when enabled' do
+        before do
+          stub_feature_flags(usage_data_instrumentation: true)
+        end
+
+        it 'merges data from instrumentation classes' do
+          expect(described_class.usage_activity_by_stage_release({})).to include(releases_with_milestones: Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+          expect(described_class.usage_activity_by_stage_release(described_class.monthly_time_range_db_params)).to include(releases_with_milestones: Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+
+          uncached_data = described_class.uncached_data
+          expect(uncached_data[:usage_activity_by_stage][:release]).to include(releases_with_milestones: 2)
+          expect(uncached_data[:usage_activity_by_stage_monthly][:release]).to include(releases_with_milestones: 1)
+        end
+      end
+
+      context 'when disabled' do
+        before do
+          stub_feature_flags(usage_data_instrumentation: false)
+        end
+
+        it 'does not merge data from instrumentation classes' do
+          expect(described_class.usage_activity_by_stage_release({})).to include(releases_with_milestones: 2)
+          expect(described_class.usage_activity_by_stage_release(described_class.monthly_time_range_db_params)).to include(releases_with_milestones: 1)
+        end
+      end
+    end
   end
 
   describe 'usage_activity_by_stage_verify' do
@@ -525,16 +603,16 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
     subject { described_class.data }
 
     it 'gathers usage data' do
-      expect(subject.keys).to include(*UsageDataHelpers::USAGE_DATA_KEYS)
+      expect(subject.keys).to include(*UsageDataHelpers::USAGE_DATA_KEYS.map(&:to_s))
     end
 
     it 'gathers usage counts', :aggregate_failures do
       count_data = subject[:counts]
-
       expect(count_data[:boards]).to eq(1)
       expect(count_data[:projects]).to eq(4)
-      expect(count_data.keys).to include(*UsageDataHelpers::COUNTS_KEYS)
-      expect(UsageDataHelpers::COUNTS_KEYS - count_data.keys).to be_empty
+      count_keys = UsageDataHelpers::COUNTS_KEYS.map(&:to_s)
+      expect(count_data.keys).to include(*count_keys)
+      expect(count_keys - count_data.keys).to be_empty
       expect(count_data.values).to all(be_a_kind_of(Integer))
     end
 
@@ -619,7 +697,7 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
          external_diffs: { enabled: false },
          lfs: { enabled: true, object_store: { enabled: false, direct_upload: true, background_upload: false, provider: "AWS" } },
          uploads: { enabled: nil, object_store: { enabled: false, direct_upload: true, background_upload: false, provider: "AWS" } },
-         packages: { enabled: true, object_store: { enabled: false, direct_upload: false, background_upload: true, provider: "AWS" } } }
+         packages: { enabled: true, object_store: { enabled: false, direct_upload: false, background_upload: true, provider: "AWS" } } }.with_indifferent_access
       )
     end
 
@@ -793,12 +871,37 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
     subject { described_class.license_usage_data }
 
     it 'gathers license data' do
-      expect(subject[:uuid]).to eq(Gitlab::CurrentSettings.uuid)
       expect(subject[:version]).to eq(Gitlab::VERSION)
       expect(subject[:installation_type]).to eq('gitlab-development-kit')
-      expect(subject[:active_user_count]).to eq(User.active.size)
       expect(subject[:recorded_at]).to be_a(Time)
     end
+
+    context 'with usage_data_instrumentation feature flag' do
+      context 'when enabled' do
+        it 'merges uuid and hostname data from instrumentation classes' do
+          stub_feature_flags(usage_data_instrumentation: true)
+
+          expect(subject[:uuid]).to eq(Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+          expect(subject[:hostname]).to eq(Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+          expect(subject[:active_user_count]).to eq(Gitlab::Utils::UsageData::INSTRUMENTATION_CLASS_FALLBACK)
+
+          uncached_data = described_class.data
+          expect(uncached_data[:uuid]).to eq(Gitlab::CurrentSettings.uuid)
+          expect(uncached_data[:hostname]).to eq(Gitlab.config.gitlab.host)
+          expect(uncached_data[:active_user_count]).to eq(User.active.size)
+        end
+      end
+
+      context 'when disabled' do
+        it 'does not merge uuid and hostname data from instrumentation classes' do
+          stub_feature_flags(usage_data_instrumentation: false)
+
+          expect(subject[:uuid]).to eq(Gitlab::CurrentSettings.uuid)
+          expect(subject[:hostname]).to eq(Gitlab.config.gitlab.host)
+          expect(subject[:active_user_count]).to eq(User.active.size)
+        end
+      end
+    end
   end
 
   context 'when not relying on database records' do
@@ -1061,18 +1164,46 @@ RSpec.describe Gitlab::UsageData, :aggregate_failures do
         expect(subject[:settings][:gitaly_apdex]).to be_within(0.001).of(0.95)
       end
 
-      it 'reports collected data categories' do
-        expected_value = %w[standard subscription operational optional]
+      context 'with usage_data_instrumentation feature flag' do
+        context 'when enabled' do
+          before do
+            stub_feature_flags(usage_data_instrumentation: true)
+          end
 
-        allow_next_instance_of(ServicePing::PermitDataCategoriesService) do |instance|
-          expect(instance).to receive(:execute).and_return(expected_value)
+          it 'reports collected data categories' do
+            expected_value = %w[standard subscription operational optional]
+
+            allow_next_instance_of(ServicePing::PermitDataCategoriesService) do |instance|
+              expect(instance).to receive(:execute).and_return(expected_value)
+            end
+
+            expect(described_class.data[:settings][:collected_data_categories]).to eq(expected_value)
+          end
+
+          it 'gathers service_ping_features_enabled' do
+            expect(described_class.data[:settings][:service_ping_features_enabled]).to eq(Gitlab::CurrentSettings.usage_ping_features_enabled)
+          end
         end
 
-        expect(subject[:settings][:collected_data_categories]).to eq(expected_value)
-      end
+        context 'when disabled' do
+          before do
+            stub_feature_flags(usage_data_instrumentation: false)
+          end
 
-      it 'gathers service_ping_features_enabled' do
-        expect(subject[:settings][:service_ping_features_enabled]).to eq(Gitlab::CurrentSettings.usage_ping_features_enabled)
+          it 'reports collected data categories' do
+            expected_value = %w[standard subscription operational optional]
+
+            allow_next_instance_of(ServicePing::PermitDataCategoriesService) do |instance|
+              expect(instance).to receive(:execute).and_return(expected_value)
+            end
+
+            expect(subject[:settings][:collected_data_categories]).to eq(expected_value)
+          end
+
+          it 'gathers service_ping_features_enabled' do
+            expect(subject[:settings][:service_ping_features_enabled]).to eq(Gitlab::CurrentSettings.usage_ping_features_enabled)
+          end
+        end
       end
 
       it 'gathers user_cap_feature_enabled' do
diff --git a/spec/lib/gitlab/utils/usage_data_spec.rb b/spec/lib/gitlab/utils/usage_data_spec.rb
index 1d01d5c7e6a..4411b10cdfb 100644
--- a/spec/lib/gitlab/utils/usage_data_spec.rb
+++ b/spec/lib/gitlab/utils/usage_data_spec.rb
@@ -8,8 +8,26 @@ RSpec.describe Gitlab::Utils::UsageData do
   describe '#add_metric' do
     let(:metric) { 'UuidMetric'}
 
-    it 'computes the metric value for given metric' do
-      expect(described_class.add_metric(metric)).to eq(Gitlab::CurrentSettings.uuid)
+    context 'with usage_data_instrumentation feature flag' do
+      context 'when enabled' do
+        before do
+          stub_feature_flags(usage_data_instrumentation: true)
+        end
+
+        it 'returns -100 value to be overriden' do
+          expect(described_class.add_metric(metric)).to eq(-100)
+        end
+      end
+
+      context 'when disabled' do
+        before do
+          stub_feature_flags(usage_data_instrumentation: false)
+        end
+
+        it 'computes the metric value for given metric' do
+          expect(described_class.add_metric(metric)).to eq(Gitlab::CurrentSettings.uuid)
+        end
+      end
     end
   end
 
diff --git a/spec/models/legacy_diff_note_spec.rb b/spec/models/legacy_diff_note_spec.rb
index ee3bbf186b9..b9e1bd62f33 100644
--- a/spec/models/legacy_diff_note_spec.rb
+++ b/spec/models/legacy_diff_note_spec.rb
@@ -8,4 +8,58 @@ RSpec.describe LegacyDiffNote do
 
     it { is_expected.to eq('note') }
   end
+
+  describe 'callbacks' do
+    describe '#set_diff' do
+      let(:note) do
+        build(:legacy_diff_note_on_merge_request, st_diff: '_st_diff_').tap do |record|
+          record.instance_variable_set(:@diff, {})
+        end
+      end
+
+      context 'when not importing' do
+        it 'updates st_diff' do
+          note.save!(validate: false)
+
+          expect(note.st_diff).to eq({})
+        end
+      end
+
+      context 'when importing' do
+        before do
+          note.importing = true
+        end
+
+        it 'does not update st_diff' do
+          note.save!(validate: false)
+
+          expect(note.st_diff).to eq('_st_diff_')
+        end
+
+        context 'when feature flag is false' do
+          before do
+            stub_feature_flags(skip_legacy_diff_note_callback_on_import: false)
+          end
+
+          it 'updates st_diff' do
+            note.save!(validate: false)
+
+            expect(note.st_diff).to eq({})
+          end
+        end
+
+        context 'when st_diff is blank' do
+          before do
+            note.st_diff = nil
+          end
+
+          it 'updates st_diff' do
+            note.save!(validate: false)
+
+            expect(note.st_diff).to eq({})
+          end
+        end
+      end
+    end
+  end
 end
diff --git a/spec/models/protected_branch_spec.rb b/spec/models/protected_branch_spec.rb
index 587a9683a8e..f7c723cd134 100644
--- a/spec/models/protected_branch_spec.rb
+++ b/spec/models/protected_branch_spec.rb
@@ -163,27 +163,32 @@ RSpec.describe ProtectedBranch do
         expect(described_class.protected?(project, 'staging/some-branch')).to eq(false)
       end
 
+      it 'returns false when branch name is nil' do
+        expect(described_class.protected?(project, nil)).to eq(false)
+      end
+
       context 'with caching', :use_clean_rails_memory_store_caching do
         let_it_be(:project) { create(:project, :repository) }
-        let_it_be(:protected_branch) { create(:protected_branch, project: project, name: "jawn") }
+        let_it_be(:protected_branch) { create(:protected_branch, project: project, name: "“jawn”") }
 
         before do
-          allow(described_class).to receive(:matching).once.and_call_original
+          allow(described_class).to receive(:matching).with(protected_branch.name, protected_refs: anything).once.and_call_original
+
           # the original call works and warms the cache
-          described_class.protected?(project, 'jawn')
+          described_class.protected?(project, protected_branch.name)
         end
 
         it 'correctly invalidates a cache' do
-          expect(described_class).to receive(:matching).once.and_call_original
+          expect(described_class).to receive(:matching).with(protected_branch.name, protected_refs: anything).once.and_call_original
 
           create(:protected_branch, project: project, name: "bar")
           # the cache is invalidated because the project has been "updated"
-          expect(described_class.protected?(project, 'jawn')).to eq(true)
+          expect(described_class.protected?(project, protected_branch.name)).to eq(true)
         end
 
         it 'correctly uses the cached version' do
           expect(described_class).not_to receive(:matching)
-          expect(described_class.protected?(project, 'jawn')).to eq(true)
+          expect(described_class.protected?(project, protected_branch.name)).to eq(true)
         end
       end
     end
diff --git a/spec/models/users/credit_card_validation_spec.rb b/spec/models/users/credit_card_validation_spec.rb
index d2b4f5ebd65..4711754f5c0 100644
--- a/spec/models/users/credit_card_validation_spec.rb
+++ b/spec/models/users/credit_card_validation_spec.rb
@@ -6,6 +6,7 @@ RSpec.describe Users::CreditCardValidation do
   it { is_expected.to belong_to(:user) }
 
   it { is_expected.to validate_length_of(:holder_name).is_at_most(26) }
+  it { is_expected.to validate_length_of(:network).is_at_most(32) }
   it { is_expected.to validate_numericality_of(:last_digits).is_less_than_or_equal_to(9999) }
 
   describe '.similar_records' do
diff --git a/spec/requests/api/users_spec.rb b/spec/requests/api/users_spec.rb
index fb01845b63a..50e5025fd47 100644
--- a/spec/requests/api/users_spec.rb
+++ b/spec/requests/api/users_spec.rb
@@ -1464,6 +1464,7 @@ RSpec.describe API::Users do
         credit_card_expiration_year: expiration_year,
         credit_card_expiration_month: 1,
         credit_card_holder_name: 'John Smith',
+        credit_card_type: 'AmericanExpress',
         credit_card_mask_number: '1111'
       }
     end
@@ -1495,6 +1496,7 @@ RSpec.describe API::Users do
           credit_card_validated_at: credit_card_validated_time,
           expiration_date: Date.new(expiration_year, 1, 31),
           last_digits: 1111,
+          network: 'AmericanExpress',
           holder_name: 'John Smith'
         )
       end
diff --git a/spec/services/users/upsert_credit_card_validation_service_spec.rb b/spec/services/users/upsert_credit_card_validation_service_spec.rb
index bede30e1898..952d482f1bd 100644
--- a/spec/services/users/upsert_credit_card_validation_service_spec.rb
+++ b/spec/services/users/upsert_credit_card_validation_service_spec.rb
@@ -15,6 +15,7 @@ RSpec.describe Users::UpsertCreditCardValidationService do
       credit_card_expiration_year: expiration_year,
       credit_card_expiration_month: 1,
       credit_card_holder_name: 'John Smith',
+      credit_card_type: 'AmericanExpress',
       credit_card_mask_number: '1111'
     }
   end
@@ -30,7 +31,16 @@ RSpec.describe Users::UpsertCreditCardValidationService do
           result = service.execute
 
           expect(result.status).to eq(:success)
-          expect(user.reload.credit_card_validated_at).to eq(credit_card_validated_time)
+
+          user.reload
+
+          expect(user.credit_card_validation).to have_attributes(
+            credit_card_validated_at: credit_card_validated_time,
+            network: 'AmericanExpress',
+            holder_name: 'John Smith',
+            last_digits: 1111,
+            expiration_date: Date.new(expiration_year, 1, 31)
+          )
         end
       end
 
@@ -97,6 +107,7 @@ RSpec.describe Users::UpsertCreditCardValidationService do
           expiration_date: Date.new(expiration_year, 1, 31),
           holder_name: "John Smith",
           last_digits: 1111,
+          network: "AmericanExpress",
           user_id: user_id
         }