From 953b58d0613979636f5be43ef1c407f2118feec8 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 11 Jul 2022 09:08:40 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../javascripts/google_tag_manager/index.js | 8 ++++ .../javascripts/pages/projects/init_blob.js | 2 +- .../queries/blob_info.query.graphql | 1 + .../javascripts/terms/components/app.vue | 10 +++- .../source_viewer/components/chunk.vue | 5 ++ .../source_viewer/components/chunk_line.vue | 31 +++++++++--- .../source_viewer/source_viewer.vue | 2 + app/assets/stylesheets/framework/files.scss | 4 ++ .../stylesheets/framework/highlight.scss | 44 ++++++++++++++++- app/assets/stylesheets/highlight/common.scss | 48 +++++++++++++------ .../stylesheets/highlight/themes/dark.scss | 14 +++++- .../stylesheets/highlight/themes/monokai.scss | 14 +++++- .../stylesheets/highlight/themes/none.scss | 14 +++++- .../highlight/themes/solarized-dark.scss | 14 +++++- .../highlight/themes/solarized-light.scss | 14 +++++- .../stylesheets/highlight/white_base.scss | 14 +++++- app/controllers/users/terms_controller.rb | 4 ++ app/services/merge_requests/base_service.rb | 5 -- app/views/shared/_file_highlight.html.haml | 9 ++-- .../content_security_policy/config_loader.rb | 3 +- .../frontend/google_tag_manager/index_spec.js | 11 +++++ spec/frontend/repository/mock_data.js | 1 + .../components/chunk_line_spec.js | 15 ++++-- .../source_viewer/components/chunk_spec.js | 2 + .../source_viewer/source_viewer_spec.js | 3 +- .../config_loader_spec.rb | 4 +- spec/mailers/devise_mailer_spec.rb | 30 ++++++++++++ .../merge_requests/update_service_spec.rb | 26 +++++++++- .../policies/project_policy_shared_context.rb | 3 +- .../projects/blob/_viewer.html.haml_spec.rb | 1 + 30 files changed, 308 insertions(+), 48 deletions(-) diff --git a/app/assets/javascripts/google_tag_manager/index.js b/app/assets/javascripts/google_tag_manager/index.js index 2969121bf06..c8204f397ff 100644 --- a/app/assets/javascripts/google_tag_manager/index.js +++ b/app/assets/javascripts/google_tag_manager/index.js @@ -176,6 +176,14 @@ export const trackSaasTrialGetStarted = () => { }); }; +export const trackTrialAcceptTerms = () => { + if (!isSupported()) { + return; + } + + pushEvent('saasTrialAcceptTerms'); +}; + export const trackCheckout = (selectedPlan, quantity) => { if (!isSupported()) { return; diff --git a/app/assets/javascripts/pages/projects/init_blob.js b/app/assets/javascripts/pages/projects/init_blob.js index 7db34816cfe..f37a2987685 100644 --- a/app/assets/javascripts/pages/projects/init_blob.js +++ b/app/assets/javascripts/pages/projects/init_blob.js @@ -11,7 +11,7 @@ export default () => { // eslint-disable-next-line no-new new BlobLinePermalinkUpdater( document.querySelector('#blob-content-holder'), - '.diff-line-num[data-line-number], .diff-line-num[data-line-number] *', + '.file-line-num[data-line-number], .file-line-num[data-line-number] *', document.querySelectorAll('.js-data-file-blob-permalink-url, .js-blob-blame-link'), ); diff --git a/app/assets/javascripts/repository/queries/blob_info.query.graphql b/app/assets/javascripts/repository/queries/blob_info.query.graphql index 8baee80e5d6..45a7793e559 100644 --- a/app/assets/javascripts/repository/queries/blob_info.query.graphql +++ b/app/assets/javascripts/repository/queries/blob_info.query.graphql @@ -27,6 +27,7 @@ query getBlobInfo( fileType language path + blamePath editBlobPath gitpodBlobUrl ideEditPath diff --git a/app/assets/javascripts/terms/components/app.vue b/app/assets/javascripts/terms/components/app.vue index aedf5b6acfe..a54a198faed 100644 --- a/app/assets/javascripts/terms/components/app.vue +++ b/app/assets/javascripts/terms/components/app.vue @@ -7,6 +7,7 @@ import { isLoggedIn } from '~/lib/utils/common_utils'; import { __ } from '~/locale'; import csrf from '~/lib/utils/csrf'; import '~/behaviors/markdown/render_gfm'; +import { trackTrialAcceptTerms } from '~/google_tag_manager'; export default { name: 'TermsApp', @@ -73,6 +74,7 @@ export default { this.setScrollableViewportHeight(); event.target.removeEventListener(FLASH_CLOSED_EVENT, this.handleFlashClose); }, + trackTrialAcceptTerms, }, }; @@ -99,7 +101,13 @@ export default { {{ $options.i18n.decline }} -
+
diff --git a/app/assets/javascripts/vue_shared/components/source_viewer/components/chunk_line.vue b/app/assets/javascripts/vue_shared/components/source_viewer/components/chunk_line.vue index 7b62f0cdb7d..b6854ee0375 100644 --- a/app/assets/javascripts/vue_shared/components/source_viewer/components/chunk_line.vue +++ b/app/assets/javascripts/vue_shared/components/source_viewer/components/chunk_line.vue @@ -1,5 +1,5 @@