From 953eb09e086c8f2842512a62e56e32223b5bf974 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 13 Apr 2022 18:08:33 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/reports.gitlab-ci.yml | 6 - .gitlab/ci/rules.gitlab-ci.yml | 12 - GITALY_SERVER_VERSION | 2 +- .../clusters_list/clusters_util.js | 13 +- .../clusters_list/components/agent_token.vue | 2 +- .../javascripts/clusters_list/constants.js | 4 +- .../incidents/components/incidents_list.vue | 15 +- .../javascripts/pipeline_editor/constants.js | 2 - .../components/pipelines_list/empty_state.vue | 2 +- .../empty_state/ci_templates.vue | 81 ++++ .../pipelines_ci_templates.vue | 62 +-- .../filtered_search_bar_root.vue | 32 +- .../stylesheets/startup/startup-dark.scss | 5 +- .../stylesheets/startup/startup-general.scss | 5 +- .../stylesheets/startup/startup-signin.scss | 5 +- .../clusters/clusters_controller.rb | 12 +- app/controllers/groups_controller.rb | 5 - .../import/gitlab_groups_controller.rb | 5 - .../jira_connect/subscriptions_controller.rb | 4 +- app/graphql/resolvers/base_resolver.rb | 2 +- app/helpers/merge_requests_helper.rb | 2 +- app/models/ci/pipeline.rb | 2 + app/models/concerns/issuable.rb | 12 - app/presenters/README.md | 8 +- app/presenters/ci/bridge_presenter.rb | 4 +- app/presenters/ci/build_presenter.rb | 6 +- app/presenters/commit_status_presenter.rb | 2 +- .../dev_ops_report/metric_presenter.rb | 44 +- app/presenters/event_presenter.rb | 2 +- app/presenters/gitlab/blame_presenter.rb | 2 +- app/presenters/label_presenter.rb | 2 - app/presenters/pages_domain_presenter.rb | 2 - .../alert_management/alerts/update_service.rb | 21 +- .../prepare_update_service.rb | 13 +- app/services/issues/create_service.rb | 5 +- app/views/groups/milestones/index.html.haml | 4 +- app/views/groups/settings/_export.html.haml | 2 - ...ci_variables_builder_config_variables.yml} | 12 +- .../development/vulnerability_reads_table.yml | 2 +- ...merge_request_rules_approved_approvers.yml | 2 +- db/docs/boards.yml | 2 +- db/docs/ci_build_report_results.yml | 2 +- db/docs/ci_pipelines.yml | 2 +- db/docs/ci_pipelines_config.yml | 2 +- db/docs/ci_runner_namespaces.yml | 2 +- db/docs/ci_unit_test_failures.yml | 2 +- db/docs/deployment_merge_requests.yml | 2 +- db/docs/description_versions.yml | 2 +- db/docs/dora_daily_metrics.yml | 2 +- db/docs/experiment_subjects.yml | 2 +- db/docs/experiment_users.yml | 2 +- db/docs/fork_network_members.yml | 2 +- db/docs/in_product_marketing_emails.yml | 2 +- db/docs/issue_email_participants.yml | 2 +- db/docs/issue_metrics.yml | 2 +- db/docs/issue_user_mentions.yml | 1 - db/docs/lfs_objects_projects.yml | 1 + db/docs/lists.yml | 2 +- db/docs/members.yml | 3 +- db/docs/merge_request_assignees.yml | 2 +- db/docs/merge_request_metrics.yml | 3 +- db/docs/merge_request_user_mentions.yml | 1 - db/docs/merge_requests_closing_issues.yml | 2 +- db/docs/namespace_root_storage_statistics.yml | 2 +- db/docs/namespace_statistics.yml | 2 +- db/docs/notification_settings.yml | 2 +- db/docs/project_authorizations.yml | 2 +- db/docs/project_auto_devops.yml | 2 +- db/docs/project_repositories.yml | 2 +- db/docs/project_repository_states.yml | 2 +- db/docs/project_repository_storage_moves.yml | 2 +- db/docs/project_settings.yml | 2 +- db/docs/push_event_payloads.yml | 2 +- db/docs/push_rules.yml | 2 +- db/docs/resource_iteration_events.yml | 2 +- db/docs/resource_label_events.yml | 3 +- db/docs/resource_state_events.yml | 3 +- db/docs/timelogs.yml | 2 +- .../packages/dependency_proxy.md | 14 + doc/development/database/index.md | 1 + .../migrations_for_multiple_databases.md | 390 ++++++++++++++++++ .../database/multiple_databases.md | 57 +++ doc/development/migration_style_guide.md | 26 +- doc/development/single_table_inheritance.md | 4 +- doc/development/sql.md | 8 +- .../dependency_scanning/index.md | 21 + doc/user/clusters/agent/install/index.md | 182 +++----- doc/user/packages/dependency_proxy/index.md | 8 + .../active_record/migration/migration.rb | 4 + .../post_deployment_migration/migration.rb | 4 + haml_lint/linter/documentation_links.rb | 10 +- lib/api/group_export.rb | 2 - lib/gitlab/ci/config.rb | 17 + lib/gitlab/ci/variables/builder.rb | 16 +- lib/gitlab/database/migration.rb | 8 +- .../restrict_allowed_schemas.rb | 18 +- lib/gitlab/tracking.rb | 17 + lib/gitlab/view/presenter/base.rb | 18 +- locale/gitlab.pot | 11 +- package.json | 4 +- qa/qa/support/api.rb | 13 +- qa/qa/tools/reliable_report.rb | 128 ++++-- qa/spec/tools/reliable_report_spec.rb | 75 +++- spec/controllers/groups_controller_spec.rb | 26 -- spec/features/clusters/create_agent_spec.rb | 2 +- .../groups/import_export/export_file_spec.rb | 16 - .../jira_connect/subscriptions_spec.rb | 2 +- .../expires_at_field_spec.js.snap | 2 +- .../components/agent_token_spec.js | 4 +- .../components/incidents_list_spec.js | 16 +- .../registry_breadcrumb_spec.js.snap | 10 +- .../components/registry_breadcrumb_spec.js | 8 +- .../pipelines_filtered_search_spec.js | 2 +- .../empty_state/ci_templates_spec.js | 85 ++++ .../pipelines_ci_templates_spec.js | 72 +--- spec/frontend/pipelines/empty_state_spec.js | 2 +- spec/frontend/pipelines/pipelines_spec.js | 2 +- .../runner_filtered_search_bar_spec.js | 2 +- .../filtered_search_bar_root_spec.js | 32 +- .../linter/documentation_links_spec.rb | 6 + spec/lib/gitlab/ci/variables/builder_spec.rb | 111 +++++ .../restrict_gitlab_schema_spec.rb | 6 +- spec/lib/gitlab/database/migration_spec.rb | 2 +- spec/lib/gitlab/tracking_spec.rb | 38 ++ spec/lib/gitlab/view/presenter/base_spec.rb | 34 +- spec/models/ci/pipeline_spec.rb | 22 + spec/models/concerns/issuable_spec.rb | 27 -- spec/presenters/ci/bridge_presenter_spec.rb | 9 +- .../graphql/mutations/boards/create_spec.rb | 10 + spec/requests/api/group_export_spec.rb | 149 +++---- .../import/gitlab_groups_controller_spec.rb | 14 - .../alerts/update_service_spec.rb | 44 +- .../prepare_update_service_spec.rb | 23 -- spec/services/issues/create_service_spec.rb | 19 +- .../boards_create_shared_examples.rb | 10 - .../escalation_status_shared_examples.rb | 22 - yarn.lock | 20 +- 137 files changed, 1505 insertions(+), 902 deletions(-) create mode 100644 app/assets/javascripts/pipelines/components/pipelines_list/empty_state/ci_templates.vue rename app/assets/javascripts/pipelines/components/pipelines_list/{ => empty_state}/pipelines_ci_templates.vue (72%) rename config/feature_flags/development/{group_import_export.yml => ci_variables_builder_config_variables.yml} (51%) create mode 100644 doc/development/database/migrations_for_multiple_databases.md create mode 100644 spec/frontend/pipelines/empty_state/ci_templates_spec.js rename spec/frontend/pipelines/{ => empty_state}/pipelines_ci_templates_spec.js (65%) delete mode 100644 spec/support/shared_examples/services/incident_management/escalation_status_shared_examples.rb diff --git a/.gitlab/ci/reports.gitlab-ci.yml b/.gitlab/ci/reports.gitlab-ci.yml index d040abfe902..3628013fc9b 100644 --- a/.gitlab/ci/reports.gitlab-ci.yml +++ b/.gitlab/ci/reports.gitlab-ci.yml @@ -87,12 +87,6 @@ gemnasium-dependency_scanning: - apk add git-lfs rules: !reference [".reports:rules:gemnasium-dependency_scanning", rules] -bundler-audit-dependency_scanning: - rules: !reference [".reports:rules:bundler-audit-dependency_scanning", rules] - -retire-js-dependency_scanning: - rules: !reference [".reports:rules:retire-js-dependency_scanning", rules] - gemnasium-python-dependency_scanning: rules: !reference [".reports:rules:gemnasium-python-dependency_scanning", rules] diff --git a/.gitlab/ci/rules.gitlab-ci.yml b/.gitlab/ci/rules.gitlab-ci.yml index ed60cb9ef17..8824c333f96 100644 --- a/.gitlab/ci/rules.gitlab-ci.yml +++ b/.gitlab/ci/rules.gitlab-ci.yml @@ -1480,18 +1480,6 @@ when: never - changes: *dependency-patterns -.reports:rules:bundler-audit-dependency_scanning: - rules: - - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /bundler-audit/ || $DS_DEFAULT_ANALYZERS !~ /bundler-audit/' - when: never - - changes: *bundler-patterns - -.reports:rules:retire-js-dependency_scanning: - rules: - - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /retire.js/ || $DS_DEFAULT_ANALYZERS !~ /retire.js/' - when: never - - changes: *nodejs-patterns - .reports:rules:gemnasium-python-dependency_scanning: rules: - if: '$DEPENDENCY_SCANNING_DISABLED || $GITLAB_FEATURES !~ /\bdependency_scanning\b/ || $DS_EXCLUDED_ANALYZERS =~ /gemnasium-python/ || $DS_DEFAULT_ANALYZERS !~ /gemnasium-python/' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 81cd42ad6ea..b3d3729f21a 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -3c00908c2743ef03a2d5b7057bf8f87d5b267a75 +9413ca591ebe30dcb133c86d0ec53f6bc2fc30bb diff --git a/app/assets/javascripts/clusters_list/clusters_util.js b/app/assets/javascripts/clusters_list/clusters_util.js index c78c93fe1ba..e7ad2f45c75 100644 --- a/app/assets/javascripts/clusters_list/clusters_util.js +++ b/app/assets/javascripts/clusters_list/clusters_util.js @@ -1,10 +1,11 @@ export function generateAgentRegistrationCommand(agentToken, kasAddress) { - return `docker run --pull=always --rm \\ - registry.gitlab.com/gitlab-org/cluster-integration/gitlab-agent/cli:stable generate \\ - --agent-token=${agentToken} \\ - --kas-address=${kasAddress} \\ - --agent-version stable \\ - --namespace gitlab-kubernetes-agent | kubectl apply -f -`; + return `helm repo add gitlab https://charts.gitlab.io +helm repo update +helm upgrade --install gitlab-agent gitlab/gitlab-agent \\ + --namespace gitlab-agent \\ + --create-namespace \\ + --set config.token=${agentToken} \\ + --set config.kasAddress=${kasAddress}`; } export function getAgentConfigPath(clusterAgentName) { diff --git a/app/assets/javascripts/clusters_list/components/agent_token.vue b/app/assets/javascripts/clusters_list/components/agent_token.vue index 951cf7926b4..751ad9795dd 100644 --- a/app/assets/javascripts/clusters_list/components/agent_token.vue +++ b/app/assets/javascripts/clusters_list/components/agent_token.vue @@ -9,7 +9,7 @@ import { I18N_AGENT_TOKEN } from '../constants'; export default { i18n: I18N_AGENT_TOKEN, advancedInstallPath: helpPagePath('user/clusters/agent/install/index', { - anchor: 'advanced-installation', + anchor: 'advanced-installation-method', }), components: { GlAlert, diff --git a/app/assets/javascripts/clusters_list/constants.js b/app/assets/javascripts/clusters_list/constants.js index f52bb079d5b..4a168e811aa 100644 --- a/app/assets/javascripts/clusters_list/constants.js +++ b/app/assets/javascripts/clusters_list/constants.js @@ -96,9 +96,9 @@ export const I18N_AGENT_TOKEN = { ), tokenSubtitle: s__('ClusterAgents|The agent uses the token to connect with GitLab.'), - basicInstallTitle: s__('ClusterAgents|Recommended installation method'), + basicInstallTitle: s__('ClusterAgents|Install using Helm (recommended)'), basicInstallBody: s__( - 'ClusterAgents|From a terminal, connect to your cluster and run this command. The token is included.', + 'ClusterAgents|From a terminal, connect to your cluster and run this command. The token is included in the command.', ), advancedInstallTitle: s__('ClusterAgents|Advanced installation methods'), diff --git a/app/assets/javascripts/incidents/components/incidents_list.vue b/app/assets/javascripts/incidents/components/incidents_list.vue index 9e0c31e29e5..bfc5bd823a2 100644 --- a/app/assets/javascripts/incidents/components/incidents_list.vue +++ b/app/assets/javascripts/incidents/components/incidents_list.vue @@ -392,19 +392,24 @@ export default {