kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Don't fail the job if the Review App doesn't deploy properly

Browse source 
It seems the deploy function causes the job to fail if it doesn't
succeed. That wasn't the intent as we want to curl the Review App after
the deploy finished (even if it failed) because sometimes the Review App
is just a bit long to be ready.

This change wraps the Review App deployment with "set +e"/"set -e" to
ensure that the job doesn't fail right away if the deploy fails.

Signed-off-by: Rémy Coutable <remy@rymai.me>
This commit is contained in:
Rémy Coutable 2019-04-10 17:28:23 +02:00
parent b57e335829
commit 955136b56d
No known key found for this signature in database
GPG key ID: 98DFFD1C0C62B70B
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scripts/review_apps/review-apps.sh
View file

@ -109,7 +109,7 @@ function perform_review_app_deployment() {
ensure_namespace ensure_namespace
install_tiller install_tiller
install_external_dns install_external_dns
time deploy || true time deploy
wait_for_review_app_to_be_accessible wait_for_review_app_to_be_accessible
add_license add_license
} }
@ -270,7 +270,7 @@ EOF
echoinfo "Deploying with:" echoinfo "Deploying with:"
echoinfo "${HELM_CMD}" echoinfo "${HELM_CMD}"
eval $HELM_CMD eval $HELM_CMD || true
} }
function wait_for_review_app_to_be_accessible() { function wait_for_review_app_to_be_accessible() {