Fixes for Karma tests
This commit is contained in:
parent
8563499b0f
commit
958cf02e91
|
@ -18,11 +18,11 @@ describe('ParallelDiffView', () => {
|
|||
}).$mount();
|
||||
});
|
||||
|
||||
describe('computed', () => {
|
||||
describe('parallelDiffLines', () => {
|
||||
describe('assigned', () => {
|
||||
describe('diffLines', () => {
|
||||
it('should normalize lines for empty cells', () => {
|
||||
expect(component.parallelDiffLines[0].left.type).toEqual(constants.EMPTY_CELL_TYPE);
|
||||
expect(component.parallelDiffLines[1].left.type).toEqual(constants.EMPTY_CELL_TYPE);
|
||||
expect(component.diffLines[0].left.type).toEqual(constants.EMPTY_CELL_TYPE);
|
||||
expect(component.diffLines[1].left.type).toEqual(constants.EMPTY_CELL_TYPE);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
|
|
@ -190,22 +190,27 @@ describe('Diffs Module Getters', () => {
|
|||
beforeEach(() => {
|
||||
line = {};
|
||||
|
||||
discussionMock.expanded = true;
|
||||
|
||||
line.left = {
|
||||
lineCode: 'ABC',
|
||||
discussions: [discussionMock],
|
||||
};
|
||||
|
||||
line.right = {
|
||||
lineCode: 'DEF',
|
||||
discussions: [discussionMock1],
|
||||
};
|
||||
});
|
||||
|
||||
it('returns true when discussion is expanded', () => {
|
||||
discussionMock.expanded = true;
|
||||
|
||||
expect(getters.shouldRenderParallelCommentRow(localState)(line)).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns false when no discussion was found', () => {
|
||||
line.left.discussions = [];
|
||||
line.right.discussions = [];
|
||||
|
||||
localState.diffLineCommentForms.ABC = false;
|
||||
localState.diffLineCommentForms.DEF = false;
|
||||
|
||||
|
@ -220,32 +225,32 @@ describe('Diffs Module Getters', () => {
|
|||
});
|
||||
|
||||
describe('shouldRenderInlineCommentRow', () => {
|
||||
let line;
|
||||
|
||||
beforeEach(() => {
|
||||
discussionMock.expanded = true;
|
||||
|
||||
line = {
|
||||
lineCode: 'ABC',
|
||||
discussions: [discussionMock],
|
||||
};
|
||||
});
|
||||
|
||||
it('returns true when diffLineCommentForms has form', () => {
|
||||
localState.diffLineCommentForms.ABC = {};
|
||||
|
||||
expect(
|
||||
getters.shouldRenderInlineCommentRow(localState)({
|
||||
lineCode: 'ABC',
|
||||
}),
|
||||
).toEqual(true);
|
||||
expect(getters.shouldRenderInlineCommentRow(localState)(line)).toEqual(true);
|
||||
});
|
||||
|
||||
it('returns false when no line discussions were found', () => {
|
||||
expect(
|
||||
getters.shouldRenderInlineCommentRow(localState, {
|
||||
singleDiscussionByLineCode: () => [],
|
||||
})('DEF'),
|
||||
).toEqual(false);
|
||||
line.discussions = [];
|
||||
expect(getters.shouldRenderInlineCommentRow(localState)(line)).toEqual(false);
|
||||
});
|
||||
|
||||
it('returns true if all found discussions are expanded', () => {
|
||||
discussionMock.expanded = true;
|
||||
|
||||
expect(
|
||||
getters.shouldRenderInlineCommentRow(localState, {
|
||||
singleDiscussionByLineCode: () => [discussionMock],
|
||||
})('ABC'),
|
||||
).toEqual(true);
|
||||
expect(getters.shouldRenderInlineCommentRow(localState)(line)).toEqual(true);
|
||||
});
|
||||
});
|
||||
|
||||
|
|
|
@ -2,10 +2,10 @@ import LazyLoader from '~/lazy_loader';
|
|||
|
||||
let lazyLoader = null;
|
||||
|
||||
describe('LazyLoader', function () {
|
||||
describe('LazyLoader', function() {
|
||||
preloadFixtures('issues/issue_with_comment.html.raw');
|
||||
|
||||
beforeEach(function () {
|
||||
beforeEach(function() {
|
||||
loadFixtures('issues/issue_with_comment.html.raw');
|
||||
lazyLoader = new LazyLoader({
|
||||
observerNode: 'body',
|
||||
|
@ -13,8 +13,8 @@ describe('LazyLoader', function () {
|
|||
// Doing everything that happens normally in onload
|
||||
lazyLoader.loadCheck();
|
||||
});
|
||||
describe('behavior', function () {
|
||||
it('should copy value from data-src to src for img 1', function (done) {
|
||||
describe('behavior', function() {
|
||||
it('should copy value from data-src to src for img 1', function(done) {
|
||||
const img = document.querySelectorAll('img[data-src]')[0];
|
||||
const originalDataSrc = img.getAttribute('data-src');
|
||||
img.scrollIntoView();
|
||||
|
@ -26,7 +26,7 @@ describe('LazyLoader', function () {
|
|||
}, 100);
|
||||
});
|
||||
|
||||
it('should lazy load dynamically added data-src images', function (done) {
|
||||
it('should lazy load dynamically added data-src images', function(done) {
|
||||
const newImg = document.createElement('img');
|
||||
const testPath = '/img/testimg.png';
|
||||
newImg.className = 'lazy';
|
||||
|
@ -41,7 +41,7 @@ describe('LazyLoader', function () {
|
|||
}, 100);
|
||||
});
|
||||
|
||||
it('should not alter normal images', function (done) {
|
||||
it('should not alter normal images', function(done) {
|
||||
const newImg = document.createElement('img');
|
||||
const testPath = '/img/testimg.png';
|
||||
newImg.setAttribute('src', testPath);
|
||||
|
|
Loading…
Reference in New Issue