diff --git a/.rubocop.yml b/.rubocop.yml index df2e7c2cb0b..f0c6a909bd2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -382,3 +382,39 @@ Cop/BanCatchThrow: Performance/ReadlinesEach: Enabled: true + +# https://gitlab.com/gitlab-org/gitlab/-/issues/212541 +RSpec/RepeatedExample: + Exclude: + - 'spec/features/issues/filtered_search/filter_issues_spec.rb' + - 'spec/features/merge_request/user_posts_diff_notes_spec.rb' + - 'spec/features/projects/files/template_type_dropdown_spec.rb' + - 'spec/finders/environments_finder_spec.rb' + - 'spec/frontend/fixtures/merge_requests.rb' + - 'spec/graphql/gitlab_schema_spec.rb' + - 'spec/helpers/users_helper_spec.rb' + - 'spec/lib/banzai/filter/autolink_filter_spec.rb' + - 'spec/lib/banzai/filter/issuable_state_filter_spec.rb' + - 'spec/lib/gitlab/closing_issue_extractor_spec.rb' + - 'spec/lib/gitlab/danger/changelog_spec.rb' + - 'spec/lib/gitlab/git/blob_spec.rb' + - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb' + - 'spec/models/ability_spec.rb' + - 'spec/models/ci/build_spec.rb' + - 'spec/models/concerns/issuable_spec.rb' + - 'spec/models/concerns/prometheus_adapter_spec.rb' + - 'spec/models/member_spec.rb' + - 'spec/models/project_services/chat_message/pipeline_message_spec.rb' + - 'spec/models/user_spec.rb' + - 'spec/models/wiki_page_spec.rb' + - 'spec/requests/api/merge_requests_spec.rb' + - 'spec/routing/admin_routing_spec.rb' + - 'spec/rubocop/cop/migration/update_large_table_spec.rb' + - 'spec/services/notification_service_spec.rb' + - 'spec/services/web_hook_service_spec.rb' + - 'ee/spec/models/group_spec.rb' + - 'ee/spec/models/user_spec.rb' + - 'ee/spec/requests/api/merge_request_approvals_spec.rb' + - 'ee/spec/services/boards/lists/update_service_spec.rb' + - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb' + - 'ee/spec/workers/geo/file_download_dispatch_worker_spec.rb' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index bd9803aa943..3553ab14f29 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -251,10 +251,6 @@ RSpec/LetBeforeExamples: RSpec/PredicateMatcher: Enabled: false -# Offense count: 69 -RSpec/RepeatedExample: - Enabled: false - # Offense count: 584 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. diff --git a/app/assets/javascripts/vue_shared/components/file_row.vue b/app/assets/javascripts/vue_shared/components/file_row.vue index 4d60cf5b1cc..e3a606571c0 100644 --- a/app/assets/javascripts/vue_shared/components/file_row.vue +++ b/app/assets/javascripts/vue_shared/components/file_row.vue @@ -39,6 +39,10 @@ export default { 'is-open': this.file.opened, }; }, + textForTitle() { + // don't output a title if we don't have the expanded path + return this.file?.tree?.length ? this.file.tree[0].parentPath : false; + }, }, watch: { 'file.active': function fileActiveWatch(active) { @@ -106,7 +110,7 @@ export default {