kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Refer to guidelines on when to assign MRs close to the freeze

Browse source
This commit is contained in:
Douwe Maan 2019-04-16 18:44:39 +02:00
parent 0477cd00dd
commit 95dbc34e29
No known key found for this signature in database
GPG key ID: 5976703F65143D36
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
doc/development/code_review.md
View file

@ -226,7 +226,10 @@ A turnaround time of two working days is usually acceptable, since engineers
will typically have other things to work on while they're waiting for review, will typically have other things to work on while they're waiting for review,
but don't hesitate to ask the author if it's unclear what time frame would be but don't hesitate to ask the author if it's unclear what time frame would be
acceptable, how urgent the review is, or how significant the blockage. Authors acceptable, how urgent the review is, or how significant the blockage. Authors
are also encouraged to provide this information up-front to reviewers. are also encouraged to provide this information up-front to reviewers, but are
expected to be mindful of the [guidelines on when to ask for review on MRs that
are intended to go in before the feature freeze](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/PROCESS.md#between-the-1st-and-the-7th),
and realistic in their expectations if these were not followed.
If you don't think you'll be able to review a merge request within a reasonable If you don't think you'll be able to review a merge request within a reasonable
time frame, let the author know as soon as possible and try to help them find time frame, let the author know as soon as possible and try to help them find