From 97eb4a009519453821dcae6c99049e490863adce Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 29 Jun 2021 21:07:38 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_manual_todo.yml | 4 - .../pages/projects/new/components/app.vue | 26 +- .../new_namespace/components/welcome.vue | 7 +- .../new_namespace/new_namespace_page.vue | 12 +- app/controllers/projects_controller.rb | 6 - app/helpers/events_helper.rb | 3 +- app/helpers/nav/new_dropdown_helper.rb | 15 +- app/helpers/nav/top_nav_helper.rb | 2 +- app/models/error_tracking.rb | 7 + app/models/error_tracking/error.rb | 12 + app/models/error_tracking/error_event.rb | 11 + .../project_error_tracking_setting.rb | 2 + app/models/event.rb | 8 +- .../error_tracking_event_payload.json | 324 ++++++++++++++++++ .../layouts/header/_new_dropdown.html.haml | 2 +- app/views/layouts/nav/_dashboard.html.haml | 2 +- .../nav/projects_dropdown/_show.html.haml | 21 +- config/feature_flags/experiment/new_repo.yml | 8 - ...0623133635_create_error_tracking_errors.rb | 28 ++ ...4554_create_error_tracking_error_events.rb | 30 ++ db/schema_migrations/20210623133635 | 1 + db/schema_migrations/20210625094554 | 1 + db/structure.sql | 70 ++++ doc/api/graphql/reference/index.md | 1 - locale/gitlab.pot | 12 - spec/controllers/projects_controller_spec.rb | 6 - spec/factories/events.rb | 1 - spec/features/groups_spec.rb | 29 -- .../user_sees_design_activity_spec.rb | 5 - spec/features/projects/new_project_spec.rb | 69 ---- .../pages/projects/new/components/app_spec.js | 33 -- .../components/shared_runners_toggle_spec.js | 39 --- .../new_namespace/components/welcome_spec.js | 26 +- .../new_namespace/new_namespace_page_spec.js | 7 - spec/helpers/nav/new_dropdown_helper_spec.rb | 27 +- spec/helpers/nav/top_nav_helper_spec.rb | 1 - .../models/error_tracking/error_event_spec.rb | 14 + spec/models/error_tracking/error_spec.rb | 16 + spec/models/event_spec.rb | 3 +- 39 files changed, 542 insertions(+), 349 deletions(-) create mode 100644 app/models/error_tracking.rb create mode 100644 app/models/error_tracking/error.rb create mode 100644 app/models/error_tracking/error_event.rb create mode 100644 app/validators/json_schemas/error_tracking_event_payload.json delete mode 100644 config/feature_flags/experiment/new_repo.yml create mode 100644 db/migrate/20210623133635_create_error_tracking_errors.rb create mode 100644 db/migrate/20210625094554_create_error_tracking_error_events.rb create mode 100644 db/schema_migrations/20210623133635 create mode 100644 db/schema_migrations/20210625094554 create mode 100644 spec/models/error_tracking/error_event_spec.rb create mode 100644 spec/models/error_tracking/error_spec.rb diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index a8fc8d0ee23..bb4ff14c8c3 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -333,10 +333,6 @@ Rails/TimeZone: - 'spec/tooling/rspec_flaky/listener_spec.rb' - 'spec/tooling/rspec_flaky/report_spec.rb' -# WIP: https://gitlab.com/gitlab-org/gitlab/-/issues/325836 -RSpec/EmptyLineAfterFinalLetItBe: - Exclude: - RSpec/TimecopFreeze: Exclude: - 'ee/spec/controllers/admin/application_settings_controller_spec.rb' diff --git a/app/assets/javascripts/pages/projects/new/components/app.vue b/app/assets/javascripts/pages/projects/new/components/app.vue index 60a4fbc3e6b..6e9efc50be8 100644 --- a/app/assets/javascripts/pages/projects/new/components/app.vue +++ b/app/assets/javascripts/pages/projects/new/components/app.vue @@ -4,12 +4,10 @@ import blankProjectIllustration from '@gitlab/svgs/dist/illustrations/project-cr import importProjectIllustration from '@gitlab/svgs/dist/illustrations/project-import-sm.svg'; import ciCdProjectIllustration from '@gitlab/svgs/dist/illustrations/project-run-CICD-pipelines-sm.svg'; import { GlSafeHtmlDirective as SafeHtml } from '@gitlab/ui'; -import { experiment } from '~/experimentation/utils'; import { s__ } from '~/locale'; import NewNamespacePage from '~/vue_shared/new_namespace/new_namespace_page.vue'; import NewProjectPushTipPopover from './new_project_push_tip_popover.vue'; -const NEW_REPO_EXPERIMENT = 'new_repo'; const CI_CD_PANEL = 'cicd_for_external_repo'; const PANELS = [ { @@ -79,28 +77,8 @@ export default { }, computed: { - decoratedPanels() { - const PANEL_TITLES = experiment(NEW_REPO_EXPERIMENT, { - use: () => ({ - blank: s__('ProjectsNew|Create blank project'), - import: s__('ProjectsNew|Import project'), - }), - try: () => ({ - blank: s__('ProjectsNew|Create blank project/repository'), - import: s__('ProjectsNew|Import project/repository'), - }), - }); - - return PANELS.map(({ key, title, ...el }) => ({ - ...el, - title: PANEL_TITLES[key] ?? title, - })); - }, - availablePanels() { - return this.isCiCdAvailable - ? this.decoratedPanels - : this.decoratedPanels.filter((p) => p.name !== CI_CD_PANEL); + return this.isCiCdAvailable ? PANELS : PANELS.filter((p) => p.name !== CI_CD_PANEL); }, }, @@ -112,7 +90,6 @@ export default { } }, }, - EXPERIMENT: NEW_REPO_EXPERIMENT, }; @@ -122,7 +99,6 @@ export default { :panels="availablePanels" :jump-to-last-persisted-panel="hasErrors" :title="s__('ProjectsNew|Create new project')" - :experiment="$options.EXPERIMENT" persistence-key="new_project_last_active_tab" @panel-change="resetProjectErrors" > diff --git a/app/assets/javascripts/vue_shared/new_namespace/components/welcome.vue b/app/assets/javascripts/vue_shared/new_namespace/components/welcome.vue index 7878d2f1da4..8034d66b458 100644 --- a/app/assets/javascripts/vue_shared/new_namespace/components/welcome.vue +++ b/app/assets/javascripts/vue_shared/new_namespace/components/welcome.vue @@ -16,14 +16,9 @@ export default { type: Array, required: true, }, - experiment: { - type: String, - required: false, - default: null, - }, }, created() { - const trackingMixin = Tracking.mixin({ ...gon.tracking_data, experiment: this.experiment }); + const trackingMixin = Tracking.mixin(); const trackingInstance = new Vue({ ...trackingMixin, render() { diff --git a/app/assets/javascripts/vue_shared/new_namespace/new_namespace_page.vue b/app/assets/javascripts/vue_shared/new_namespace/new_namespace_page.vue index a2b432d11f4..c1e8376d656 100644 --- a/app/assets/javascripts/vue_shared/new_namespace/new_namespace_page.vue +++ b/app/assets/javascripts/vue_shared/new_namespace/new_namespace_page.vue @@ -36,11 +36,6 @@ export default { type: String, required: true, }, - experiment: { - type: String, - required: false, - default: null, - }, }, data() { @@ -103,12 +98,7 @@ export default {