Add service to create a new issue in a board list
This commit is contained in:
parent
e7a4bbb04a
commit
97ec0c05f6
|
@ -10,23 +10,21 @@ module Projects
|
||||||
issues = issues.page(params[:page])
|
issues = issues.page(params[:page])
|
||||||
|
|
||||||
render json: {
|
render json: {
|
||||||
issues: issues.as_json(
|
issues: serialize_as_json(issues),
|
||||||
only: [:iid, :title, :confidential],
|
|
||||||
include: {
|
|
||||||
assignee: { only: [:id, :name, :username], methods: [:avatar_url] },
|
|
||||||
labels: { only: [:id, :title, :description, :color, :priority], methods: [:text_color] }
|
|
||||||
}),
|
|
||||||
size: issues.total_count
|
size: issues.total_count
|
||||||
}
|
}
|
||||||
end
|
end
|
||||||
|
|
||||||
def create
|
def create
|
||||||
list = project.board.lists.find(params[:list_id])
|
list = project.board.lists.find(params[:list_id])
|
||||||
|
service = ::Boards::Issues::CreateService.new(project, current_user, issue_params)
|
||||||
|
issue = service.execute(list)
|
||||||
|
|
||||||
issue = Issues::CreateService.new(project, current_user, issue_params.merge(request: request)).execute
|
if issue.valid?
|
||||||
issue.labels << list.label if list.label
|
render json: serialize_as_json(issue)
|
||||||
|
else
|
||||||
render json: issue.to_json
|
render json: issue.errors, status: :unprocessable_entity
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
def update
|
def update
|
||||||
|
@ -70,7 +68,16 @@ module Projects
|
||||||
end
|
end
|
||||||
|
|
||||||
def issue_params
|
def issue_params
|
||||||
params.require(:issue).permit(:title)
|
params.require(:issue).permit(:title).merge(request: request)
|
||||||
|
end
|
||||||
|
|
||||||
|
def serialize_as_json(resource)
|
||||||
|
resource.as_json(
|
||||||
|
only: [:iid, :title, :confidential],
|
||||||
|
include: {
|
||||||
|
assignee: { only: [:id, :name, :username], methods: [:avatar_url] },
|
||||||
|
labels: { only: [:id, :title, :description, :color, :priority], methods: [:text_color] }
|
||||||
|
})
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
|
@ -0,0 +1,16 @@
|
||||||
|
module Boards
|
||||||
|
module Issues
|
||||||
|
class CreateService < Boards::BaseService
|
||||||
|
def execute(list)
|
||||||
|
params.merge!(label_ids: [list.label_id])
|
||||||
|
create_issue
|
||||||
|
end
|
||||||
|
|
||||||
|
private
|
||||||
|
|
||||||
|
def create_issue
|
||||||
|
::Issues::CreateService.new(project, current_user, params).execute
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
|
@ -0,0 +1,33 @@
|
||||||
|
require 'spec_helper'
|
||||||
|
|
||||||
|
describe Boards::Issues::CreateService, services: true do
|
||||||
|
describe '#execute' do
|
||||||
|
let(:project) { create(:project_with_board) }
|
||||||
|
let(:board) { project.board }
|
||||||
|
let(:user) { create(:user) }
|
||||||
|
let(:label) { create(:label, project: project, name: 'in-progress') }
|
||||||
|
let!(:list) { create(:list, board: board, label: label, position: 0) }
|
||||||
|
|
||||||
|
subject(:service) { described_class.new(project, user, title: 'New issue') }
|
||||||
|
|
||||||
|
before do
|
||||||
|
project.team << [user, :developer]
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'delegates the create proceedings to Issues::CreateService' do
|
||||||
|
expect_any_instance_of(Issues::CreateService).to receive(:execute).once
|
||||||
|
|
||||||
|
service.execute(list)
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'creates a new issue' do
|
||||||
|
expect { service.execute(list) }.to change(project.issues, :count).by(1)
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'adds the label of the list to the issue' do
|
||||||
|
issue = service.execute(list)
|
||||||
|
|
||||||
|
expect(issue.labels).to eq [label]
|
||||||
|
end
|
||||||
|
end
|
||||||
|
end
|
Loading…
Reference in New Issue