should_email_no_one -> should_not_email_anyone, feedback:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17039876
This commit is contained in:
Lin Jen-Shin 2016-10-17 18:03:53 +08:00
parent 0a11d53153
commit 98217bc067
3 changed files with 4 additions and 4 deletions

View File

@ -551,7 +551,7 @@ describe Ci::Pipeline, models: true do
shared_examples 'not sending any notification' do
it 'does not send any email' do
should_email_no_one
should_not_email_anyone
end
end

View File

@ -17,7 +17,7 @@ describe NotificationService, services: true do
it 'sends no emails when no new mentions are present' do
send_notifications
should_email_no_one
should_not_email_anyone
end
it 'emails new mentions with a watch level higher than participant' do
@ -27,7 +27,7 @@ describe NotificationService, services: true do
it 'does not email new mentions with a watch level equal to or less than participant' do
send_notifications(@u_participating, @u_mentioned)
should_email_no_one
should_not_email_anyone
end
end

View File

@ -23,7 +23,7 @@ module EmailHelpers
expect(sent_to_user?(user, recipients)).to be_falsey
end
def should_email_no_one
def should_not_email_anyone
expect(ActionMailer::Base.deliveries).to be_empty
end