should_email_no_one -> should_not_email_anyone, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6342/diffs#note_17039876
This commit is contained in:
parent
0a11d53153
commit
98217bc067
|
@ -551,7 +551,7 @@ describe Ci::Pipeline, models: true do
|
||||||
|
|
||||||
shared_examples 'not sending any notification' do
|
shared_examples 'not sending any notification' do
|
||||||
it 'does not send any email' do
|
it 'does not send any email' do
|
||||||
should_email_no_one
|
should_not_email_anyone
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -17,7 +17,7 @@ describe NotificationService, services: true do
|
||||||
|
|
||||||
it 'sends no emails when no new mentions are present' do
|
it 'sends no emails when no new mentions are present' do
|
||||||
send_notifications
|
send_notifications
|
||||||
should_email_no_one
|
should_not_email_anyone
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'emails new mentions with a watch level higher than participant' do
|
it 'emails new mentions with a watch level higher than participant' do
|
||||||
|
@ -27,7 +27,7 @@ describe NotificationService, services: true do
|
||||||
|
|
||||||
it 'does not email new mentions with a watch level equal to or less than participant' do
|
it 'does not email new mentions with a watch level equal to or less than participant' do
|
||||||
send_notifications(@u_participating, @u_mentioned)
|
send_notifications(@u_participating, @u_mentioned)
|
||||||
should_email_no_one
|
should_not_email_anyone
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -23,7 +23,7 @@ module EmailHelpers
|
||||||
expect(sent_to_user?(user, recipients)).to be_falsey
|
expect(sent_to_user?(user, recipients)).to be_falsey
|
||||||
end
|
end
|
||||||
|
|
||||||
def should_email_no_one
|
def should_not_email_anyone
|
||||||
expect(ActionMailer::Base.deliveries).to be_empty
|
expect(ActionMailer::Base.deliveries).to be_empty
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue