Test if issue authors can access private projects
This commit is contained in:
parent
fe084819b4
commit
98559adf71
2 changed files with 14 additions and 0 deletions
|
@ -41,6 +41,7 @@ v 8.12.0 (unreleased)
|
||||||
- Expose `sha` and `merge_commit_sha` in merge request API (Ben Boeckel)
|
- Expose `sha` and `merge_commit_sha` in merge request API (Ben Boeckel)
|
||||||
- Set path for all JavaScript cookies to honor GitLab's subdirectory setting !5627 (Mike Greiling)
|
- Set path for all JavaScript cookies to honor GitLab's subdirectory setting !5627 (Mike Greiling)
|
||||||
- Fix blame table layout width
|
- Fix blame table layout width
|
||||||
|
- Spec testing if issue authors can read issues on private projects
|
||||||
- Fix bug where pagination is still displayed despite all todos marked as done (ClemMakesApps)
|
- Fix bug where pagination is still displayed despite all todos marked as done (ClemMakesApps)
|
||||||
- Request only the LDAP attributes we need !6187
|
- Request only the LDAP attributes we need !6187
|
||||||
- Center build stage columns in pipeline overview (ClemMakesApps)
|
- Center build stage columns in pipeline overview (ClemMakesApps)
|
||||||
|
|
|
@ -33,4 +33,17 @@ describe ProjectPolicy, models: true do
|
||||||
it 'returns increasing permissions for each level' do
|
it 'returns increasing permissions for each level' do
|
||||||
expect(users_permissions).to eq(users_permissions.sort.uniq)
|
expect(users_permissions).to eq(users_permissions.sort.uniq)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
it 'does not include the read_issue permission when the issue author is not a member of the private project' do
|
||||||
|
project = create(:project, :private)
|
||||||
|
issue = create(:issue, project: project)
|
||||||
|
user = issue.author
|
||||||
|
|
||||||
|
expect(project.team.member?(issue.author)).to eq(false)
|
||||||
|
|
||||||
|
expect(BasePolicy.class_for(project).abilities(user, project).can_set).
|
||||||
|
not_to include(:read_issue)
|
||||||
|
|
||||||
|
expect(Ability.allowed?(user, :read_issue, project)).to be_falsy
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in a new issue