Measure Gitaly migration sites against original

We were missing data for Gitaly migration call sites against the
original implementation. This commit adds a histogram with a flag
telling us if gitaly received the call or the original implementation
did.
This commit is contained in:
Zeger-Jan van de Weg 2017-10-31 23:20:07 +01:00
parent 0134079430
commit 9936ae26b3
No known key found for this signature in database
GPG Key ID: 65F6A8D64A88ABAC
1 changed files with 5 additions and 1 deletions

View File

@ -34,10 +34,11 @@ module Gitlab
private_constant :MUTEX
class << self
attr_accessor :query_time
attr_accessor :query_time, :migrate_histogram
end
self.query_time = 0
self.migrate_histogram = Gitlab::Metrics.histogram(:gitaly_migrate_call_duration, "Gitaly migration call execution timings")
def self.stub(name, storage)
MUTEX.synchronize do
@ -171,8 +172,11 @@ module Gitlab
feature_stack = Thread.current[:gitaly_feature_stack] ||= []
feature_stack.unshift(feature)
begin
start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
yield is_enabled
ensure
total_time = Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
migrate_histogram.observe({ gitaly_enabled: is_enabled, feature: feature }, total_time)
feature_stack.shift
Thread.current[:gitaly_feature_stack] = nil if feature_stack.empty?
end