kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Preserve optional second parameter in NewNoteWorker jobs

Browse source 
If there are any old or retries in the Sidekiq queue, NewNoteWorker
will fail with the error:

wrong number of arguments (given 2, expected 1)

This change allows the optional second argument to be used
to preserve backwards compatibility. It can be removed later.

Closes #24678
This commit is contained in:
Stan Hu 2016-11-19 10:18:44 -08:00
parent 18a646c388
commit 99432cbcfb
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/workers/new_note_worker.rb
View file

@ -2,7 +2,9 @@ class NewNoteWorker
include Sidekiq::Worker
include DedicatedSidekiqQueue
def perform(note_id)
# Keep extra parameter to preserve backwards compatibility with
# old `NewNoteWorker` jobs (can remove later)
def perform(note_id, _params = {})
if note = Note.find_by(id: note_id)
NotificationService.new.new_note(note)
Notes::PostProcessService.new(note).execute