From 99f1385ee02a368e8fa7cc0bcaad78b904d1a81d Mon Sep 17 00:00:00 2001 From: Grzegorz Bizon Date: Fri, 16 Sep 2016 11:38:56 +0200 Subject: [PATCH] Restore validation of CI job environment name --- lib/gitlab/ci/config/node/environment.rb | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/gitlab/ci/config/node/environment.rb b/lib/gitlab/ci/config/node/environment.rb index bc153854a8d..d388ab6b879 100644 --- a/lib/gitlab/ci/config/node/environment.rb +++ b/lib/gitlab/ci/config/node/environment.rb @@ -18,6 +18,15 @@ module Gitlab end validates :name, presence: true + validates :name, + type: { + with: String, + message: Gitlab::Regex.environment_name_regex_message } + + validates :name, + format: { + with: Gitlab::Regex.environment_name_regex, + message: Gitlab::Regex.environment_name_regex_message } with_options if: :hash? do validates :config, allowed_keys: ALLOWED_KEYS