From 9a5dcad39c5dd81384ae4ec2398435883b944363 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 14 Sep 2020 12:09:34 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITLAB_ELASTICSEARCH_INDEXER_VERSION | 2 +- .../boards/components/board_column.vue | 33 +- .../boards/components/board_list.vue | 5 - .../boards/components/board_list_header.vue | 7 +- .../boards/components/board_new_issue.vue | 9 +- .../boards/filtered_search_boards.js | 2 +- app/assets/javascripts/boards/index.js | 4 + .../boards/queries/lists_issues.query.graphql | 5 +- .../javascripts/boards/stores/actions.js | 39 +- .../javascripts/boards/stores/boards_store.js | 10 +- .../javascripts/boards/stores/getters.js | 5 - .../boards/stores/mutation_types.js | 4 +- .../javascripts/boards/stores/mutations.js | 16 +- .../upload/design_version_dropdown.vue | 8 +- .../diffs/components/diff_file.vue | 10 +- app/assets/javascripts/ide/components/ide.vue | 3 +- .../ide/components/ide_file_row.vue | 12 +- .../javascripts/ide/components/ide_review.vue | 4 +- .../javascripts/ide/components/ide_tree.vue | 4 +- .../ide/components/repo_editor.vue | 5 +- .../javascripts/ide/components/repo_tab.vue | 7 +- .../javascripts/ide/components/repo_tabs.vue | 7 +- app/assets/javascripts/ide/lib/files.js | 8 - app/assets/javascripts/ide/services/index.js | 6 +- app/assets/javascripts/ide/stores/actions.js | 10 +- .../javascripts/ide/stores/actions/file.js | 14 +- .../javascripts/ide/stores/actions/tree.js | 6 +- app/assets/javascripts/ide/stores/getters.js | 3 + .../javascripts/ide/stores/mutations.js | 19 +- app/assets/javascripts/ide/stores/utils.js | 14 - .../components/alerts_form.vue | 8 +- .../edit/components/override_dropdown.vue | 8 +- app/assets/javascripts/issuable_form.js | 1 + .../javascripts/issue_show/stores/index.js | 5 +- .../issue_show/utils/parse_data.js | 7 + .../components/jira_import_form.vue | 16 +- .../javascripts/lib/utils/datetime_utility.js | 10 + .../milestones/project_milestone_combobox.vue | 8 +- .../components/alert_widget_form.vue | 2 +- .../components/dashboard_actions_menu.vue | 8 +- .../components/dashboard_header.vue | 8 +- .../monitoring/components/dashboard_panel.vue | 2 +- .../components/dashboards_dropdown.vue | 8 +- .../monitoring/components/refresh_button.vue | 8 +- .../wikis/components/delete_wiki_modal.vue | 11 +- .../components/pipeline_new_form.vue | 8 +- .../components/graph/linked_pipeline.vue | 7 +- .../pipelines/stores/test_reports/getters.js | 4 +- .../pipelines/stores/test_reports/utils.js | 16 - .../commits/components/author_select.vue | 8 +- .../ref/components/ref_selector.vue | 8 +- .../assignees/assignee_avatar_link.vue | 2 +- .../assignees/issuable_assignees.vue | 37 + .../assignees/uncollapsed_assignee_list.vue | 6 +- app/assets/javascripts/users_select/index.js | 7 +- .../components/mr_widget_header.vue | 2 +- .../vue_shared/components/clone_dropdown.vue | 8 +- .../vue_shared/components/file_row.vue | 12 +- .../filtered_search_bar_root.vue | 2 +- .../components/resizable_chart/constants.js | 6 +- .../resizable_chart/skeleton_loader.vue | 64 +- .../components/timezone_dropdown.vue | 8 +- app/assets/stylesheets/pages/boards.scss | 1 + app/assets/stylesheets/pages/issuable.scss | 7 - app/helpers/form_helper.rb | 23 + app/helpers/notes_helper.rb | 2 +- app/helpers/notifications_helper.rb | 10 +- app/models/alert_management/alert.rb | 10 +- app/models/project.rb | 1 + app/models/project_services/ewm_service.rb | 29 + app/models/service.rb | 2 +- .../alert_management/alert_presenter.rb | 6 +- .../prometheus_alert_presenter.rb | 4 - .../projects/prometheus/alert_presenter.rb | 18 +- .../system_notes/issuables_service.rb | 16 + .../notifications/_group_settings.html.haml | 2 +- .../notifications/_project_settings.html.haml | 2 +- app/views/shared/_no_password.html.haml | 19 +- app/views/shared/boards/_show.html.haml | 2 +- .../shared/issuable/form/_metadata.html.haml | 4 + .../_metadata_issuable_reviewer.html.haml | 10 + .../209784-fix-notes-pagination-values.yml | 5 + .../unreleased/224526-es-client-timeout.yml | 5 + .../229918_systemnote_aggregate_counts.yml | 5 + ...app-views-shared-_no_password-html-ham.yml | 5 + changelogs/unreleased/ewm-proj-service.yml | 5 + ...make-all-downstream-upstream-ids-links.yml | 5 + ...frontend-unit-test-report-case-sorting.yml | 5 + .../unreleased/mw-notification-icons.yml | 5 + .../remove-duplicated-cs-findings.yml | 5 + .../sy-unhide-alert-payload-attrs.yml | 5 + changelogs/unreleased/wc-pages-backup.yml | 5 + .../track_issue_activity_actions.yml | 7 + ...054946_add_elasticsearch_client_timeout.rb | 12 + ..._inconsistent_vulnerability_occurrences.rb | 20 + ...910131218_remove_duplicated_cs_findings.rb | 31 + db/schema_migrations/20200903054946 | 1 + db/schema_migrations/20200910131217 | 1 + db/schema_migrations/20200910131218 | 1 + db/structure.sql | 3 + doc/administration/geo/replication/index.md | 1 - .../graphql/reference/gitlab_schema.graphql | 1 + doc/api/graphql/reference/gitlab_schema.json | 6 + doc/api/graphql/reference/index.md | 1 + doc/api/project_level_variables.md | 24 +- doc/development/telemetry/usage_ping.md | 15 + doc/install/requirements.md | 2 +- doc/integration/README.md | 1 + doc/integration/elasticsearch.md | 1 + doc/integration/external-issue-tracker.md | 3 +- doc/user/project/integrations/ewm.md | 30 + doc/user/project/integrations/overview.md | 1 + doc/user/project/issues/index.md | 2 +- doc/user/search/advanced_global_search.md | 3 + lib/api/helpers/services_helpers.rb | 21 + lib/api/variables.rb | 1 - lib/backup/artifacts.rb | 2 +- lib/backup/files.rb | 27 +- lib/backup/pages.rb | 2 +- lib/backup/uploads.rb | 2 +- .../remove_duplicate_cs_findings.rb | 13 + lib/gitlab/ci/features.rb | 5 - .../issue_activity_unique_counter.rb | 45 + .../usage_data_counters/known_events.yml | 21 + locale/gitlab.pot | 51 +- .../create_table_with_foreign_keys.rb | 8 +- spec/factories/projects.rb | 6 + spec/factories/services.rb | 6 + spec/features/groups/board_sidebar_spec.rb | 2 - spec/features/issues/user_edits_issue_spec.rb | 4 +- .../merge_request/user_edits_mr_spec.rb | 28 + .../user_activates_issue_tracker_spec.rb | 15 +- spec/frontend/boards/mock_data.js | 144 +-- spec/frontend/boards/stores/actions_spec.js | 17 +- spec/frontend/boards/stores/getters_spec.js | 15 - spec/frontend/boards/stores/mutations_spec.js | 55 +- .../components/timezone_dropdown_spec.js | 4 +- .../design_version_dropdown_spec.js.snap | 8 +- .../upload/design_version_dropdown_spec.js | 10 +- spec/frontend/ide/commit_icon_spec.js | 1 - spec/frontend/ide/components/repo_tab_spec.js | 2 +- .../frontend/ide/components/repo_tabs_spec.js | 43 +- spec/frontend/ide/helpers.js | 1 - spec/frontend/ide/lib/files_spec.js | 15 +- spec/frontend/ide/services/index_spec.js | 6 +- spec/frontend/ide/stores/actions/file_spec.js | 24 +- .../ide/stores/actions/merge_request_spec.js | 2 - spec/frontend/ide/stores/actions_spec.js | 15 +- spec/frontend/ide/stores/getters_spec.js | 11 + spec/frontend/ide/stores/integration_spec.js | 2 - spec/frontend/ide/stores/mutations_spec.js | 18 +- .../__snapshots__/alerts_form_spec.js.snap | 4 +- .../edit/components/override_dropdown_spec.js | 8 +- .../components/jira_import_form_spec.js | 4 +- .../project_milestone_combobox_spec.js | 4 +- .../dashboard_template_spec.js.snap | 4 +- .../components/refresh_button_spec.js | 4 +- .../components/pipeline_new_form_spec.js | 4 +- .../pipelines/graph/linked_pipeline_spec.js | 8 +- .../test_reports/test_suite_table_spec.js | 12 - .../commits/components/author_select_spec.js | 9 +- .../ref/components/ref_selector_spec.js | 2 +- .../sidebar/issuable_assignees_spec.js | 59 ++ .../__snapshots__/clone_dropdown_spec.js.snap | 4 +- .../filtered_search_bar_root_spec.js | 2 +- .../skeleton_loader_spec.js.snap | 828 +++++++++--------- spec/helpers/notifications_helper_spec.rb | 12 +- spec/lib/backup/artifacts_spec.rb | 37 + spec/lib/backup/files_spec.rb | 46 + spec/lib/backup/pages_spec.rb | 30 + spec/lib/backup/uploads_spec.rb | 18 + .../external_issue_reference_filter_spec.rb | 43 + spec/lib/gitlab/import_export/all_models.yml | 1 + .../hll_redis_counter_spec.rb | 2 +- .../issue_activity_unique_counter_spec.rb | 111 +++ spec/models/alert_management/alert_spec.rb | 27 - .../project_services/ewm_service_spec.rb | 61 ++ spec/models/project_spec.rb | 1 + .../alert_management/alert_presenter_spec.rb | 27 +- .../prometheus_alert_presenter_spec.rb | 6 +- .../prometheus/alert_presenter_spec.rb | 128 +-- spec/requests/api/variables_spec.rb | 64 +- .../create_table_with_foreign_keys_spec.rb | 28 +- .../editable_merge_request_shared_examples.rb | 13 + .../merge_requests/edit.html.haml_spec.rb | 1 + 185 files changed, 1927 insertions(+), 1323 deletions(-) create mode 100644 app/assets/javascripts/sidebar/components/assignees/issuable_assignees.vue create mode 100644 app/models/project_services/ewm_service.rb create mode 100644 app/views/shared/issuable/form/_metadata_issuable_reviewer.html.haml create mode 100644 changelogs/unreleased/209784-fix-notes-pagination-values.yml create mode 100644 changelogs/unreleased/224526-es-client-timeout.yml create mode 100644 changelogs/unreleased/229918_systemnote_aggregate_counts.yml create mode 100644 changelogs/unreleased/233665-replace-bootstrap-alerts-in-app-views-shared-_no_password-html-ham.yml create mode 100644 changelogs/unreleased/ewm-proj-service.yml create mode 100644 changelogs/unreleased/make-all-downstream-upstream-ids-links.yml create mode 100644 changelogs/unreleased/mf-remove-frontend-unit-test-report-case-sorting.yml create mode 100644 changelogs/unreleased/mw-notification-icons.yml create mode 100644 changelogs/unreleased/remove-duplicated-cs-findings.yml create mode 100644 changelogs/unreleased/sy-unhide-alert-payload-attrs.yml create mode 100644 changelogs/unreleased/wc-pages-backup.yml create mode 100644 config/feature_flags/development/track_issue_activity_actions.yml create mode 100644 db/migrate/20200903054946_add_elasticsearch_client_timeout.rb create mode 100644 db/post_migrate/20200910131217_tmp_index_for_fixing_inconsistent_vulnerability_occurrences.rb create mode 100644 db/post_migrate/20200910131218_remove_duplicated_cs_findings.rb create mode 100644 db/schema_migrations/20200903054946 create mode 100644 db/schema_migrations/20200910131217 create mode 100644 db/schema_migrations/20200910131218 create mode 100644 doc/user/project/integrations/ewm.md create mode 100644 lib/gitlab/background_migration/remove_duplicate_cs_findings.rb create mode 100644 lib/gitlab/usage_data_counters/issue_activity_unique_counter.rb create mode 100644 spec/frontend/sidebar/issuable_assignees_spec.js create mode 100644 spec/lib/backup/artifacts_spec.rb create mode 100644 spec/lib/backup/pages_spec.rb create mode 100644 spec/lib/gitlab/usage_data_counters/issue_activity_unique_counter_spec.rb create mode 100644 spec/models/project_services/ewm_service_spec.rb diff --git a/GITLAB_ELASTICSEARCH_INDEXER_VERSION b/GITLAB_ELASTICSEARCH_INDEXER_VERSION index e70b4523ae7..24ba9a38de6 100644 --- a/GITLAB_ELASTICSEARCH_INDEXER_VERSION +++ b/GITLAB_ELASTICSEARCH_INDEXER_VERSION @@ -1 +1 @@ -2.6.0 +2.7.0 diff --git a/app/assets/javascripts/boards/components/board_column.vue b/app/assets/javascripts/boards/components/board_column.vue index 23e4edea40f..dae24338e45 100644 --- a/app/assets/javascripts/boards/components/board_column.vue +++ b/app/assets/javascripts/boards/components/board_column.vue @@ -1,11 +1,9 @@ diff --git a/app/assets/javascripts/diffs/components/diff_file.vue b/app/assets/javascripts/diffs/components/diff_file.vue index 4a68fbb20d0..02396a4ba1b 100644 --- a/app/assets/javascripts/diffs/components/diff_file.vue +++ b/app/assets/javascripts/diffs/components/diff_file.vue @@ -1,8 +1,7 @@ diff --git a/app/assets/javascripts/ide/components/ide_review.vue b/app/assets/javascripts/ide/components/ide_review.vue index 95348711e1d..e36d0a5a5b1 100644 --- a/app/assets/javascripts/ide/components/ide_review.vue +++ b/app/assets/javascripts/ide/components/ide_review.vue @@ -10,7 +10,7 @@ export default { EditorModeDropdown, }, computed: { - ...mapGetters(['currentMergeRequest', 'activeFile']), + ...mapGetters(['currentMergeRequest', 'activeFile', 'getUrlForPath']), ...mapState(['viewer', 'currentMergeRequestId']), showLatestChangesText() { return !this.currentMergeRequestId || this.viewer === viewerTypes.diff; @@ -24,7 +24,7 @@ export default { }, mounted() { if (this.activeFile && this.activeFile.pending && !this.activeFile.deleted) { - this.$router.push(`/project${this.activeFile.url}`, () => { + this.$router.push(this.getUrlForPath(this.activeFile.path), () => { this.updateViewer('editor'); }); } else if (this.activeFile && this.activeFile.deleted) { diff --git a/app/assets/javascripts/ide/components/ide_tree.vue b/app/assets/javascripts/ide/components/ide_tree.vue index 647f4d4be85..747d5044790 100644 --- a/app/assets/javascripts/ide/components/ide_tree.vue +++ b/app/assets/javascripts/ide/components/ide_tree.vue @@ -15,13 +15,13 @@ export default { }, computed: { ...mapState(['currentBranchId']), - ...mapGetters(['currentProject', 'currentTree', 'activeFile']), + ...mapGetters(['currentProject', 'currentTree', 'activeFile', 'getUrlForPath']), }, mounted() { if (!this.activeFile) return; if (this.activeFile.pending && !this.activeFile.deleted) { - this.$router.push(`/project${this.activeFile.url}`, () => { + this.$router.push(this.getUrlForPath(this.activeFile.path), () => { this.updateViewer('editor'); }); } else if (this.activeFile.deleted) { diff --git a/app/assets/javascripts/ide/components/repo_editor.vue b/app/assets/javascripts/ide/components/repo_editor.vue index d22d430cb4a..28348544f1a 100644 --- a/app/assets/javascripts/ide/components/repo_editor.vue +++ b/app/assets/javascripts/ide/components/repo_editor.vue @@ -48,6 +48,7 @@ export default { 'renderWhitespaceInCode', 'editorTheme', 'entries', + 'currentProjectId', ]), ...mapGetters([ 'currentMergeRequest', @@ -379,7 +380,7 @@ export default { :path="file.rawPath || file.path" :file-path="file.path" :file-size="file.size" - :project-path="file.projectId" + :project-path="currentProjectId" :commit-sha="currentBranchCommit" :type="fileType" /> @@ -390,7 +391,7 @@ export default { :new-sha="currentMergeRequest.sha" :old-path="file.mrChange.old_path" :old-sha="currentMergeRequest.baseCommitSha" - :project-path="file.projectId" + :project-path="currentProjectId" /> diff --git a/app/assets/javascripts/ide/components/repo_tab.vue b/app/assets/javascripts/ide/components/repo_tab.vue index bc6d23adb64..60a80a31a8b 100644 --- a/app/assets/javascripts/ide/components/repo_tab.vue +++ b/app/assets/javascripts/ide/components/repo_tab.vue @@ -1,5 +1,5 @@ - + diff --git a/app/assets/javascripts/monitoring/components/dashboard_header.vue b/app/assets/javascripts/monitoring/components/dashboard_header.vue index 67c56766d99..2c4aecba719 100644 --- a/app/assets/javascripts/monitoring/components/dashboard_header.vue +++ b/app/assets/javascripts/monitoring/components/dashboard_header.vue @@ -3,7 +3,7 @@ import { debounce } from 'lodash'; import { mapActions, mapState, mapGetters } from 'vuex'; import { GlButton, - GlNewDropdown, + GlDropdown, GlLoadingIcon, GlNewDropdownItem, GlNewDropdownHeader, @@ -28,7 +28,7 @@ export default { components: { GlIcon, GlButton, - GlNewDropdown, + GlDropdown, GlLoadingIcon, GlNewDropdownItem, GlNewDropdownHeader, @@ -181,7 +181,7 @@ export default {
-
- +
diff --git a/app/assets/javascripts/monitoring/components/dashboard_panel.vue b/app/assets/javascripts/monitoring/components/dashboard_panel.vue index 278858d3a94..e8968241af9 100644 --- a/app/assets/javascripts/monitoring/components/dashboard_panel.vue +++ b/app/assets/javascripts/monitoring/components/dashboard_panel.vue @@ -6,7 +6,7 @@ import { GlIcon, GlLink, GlLoadingIcon, - GlNewDropdown as GlDropdown, + GlDropdown, GlNewDropdownItem as GlDropdownItem, GlNewDropdownDivider as GlDropdownDivider, GlModal, diff --git a/app/assets/javascripts/monitoring/components/dashboards_dropdown.vue b/app/assets/javascripts/monitoring/components/dashboards_dropdown.vue index a4d388fb064..c9f6e4bd2f5 100644 --- a/app/assets/javascripts/monitoring/components/dashboards_dropdown.vue +++ b/app/assets/javascripts/monitoring/components/dashboards_dropdown.vue @@ -2,7 +2,7 @@ import { mapState, mapGetters } from 'vuex'; import { GlIcon, - GlNewDropdown, + GlDropdown, GlNewDropdownItem, GlNewDropdownHeader, GlNewDropdownDivider, @@ -17,7 +17,7 @@ const events = { export default { components: { GlIcon, - GlNewDropdown, + GlDropdown, GlNewDropdownItem, GlNewDropdownHeader, GlNewDropdownDivider, @@ -73,7 +73,7 @@ export default { }; diff --git a/app/assets/javascripts/monitoring/components/refresh_button.vue b/app/assets/javascripts/monitoring/components/refresh_button.vue index 0e9605450ed..3414c28d7a6 100644 --- a/app/assets/javascripts/monitoring/components/refresh_button.vue +++ b/app/assets/javascripts/monitoring/components/refresh_button.vue @@ -4,7 +4,7 @@ import { mapActions } from 'vuex'; import { GlButtonGroup, GlButton, - GlNewDropdown, + GlDropdown, GlNewDropdownItem, GlNewDropdownDivider, GlTooltipDirective, @@ -48,7 +48,7 @@ export default { components: { GlButtonGroup, GlButton, - GlNewDropdown, + GlDropdown, GlNewDropdownItem, GlNewDropdownDivider, }, @@ -152,7 +152,7 @@ export default { icon="retry" @click="refresh" /> - {{ option.label }} - + diff --git a/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue b/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue index a7b7d597fb7..653aad3d2f5 100644 --- a/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue +++ b/app/assets/javascripts/pages/shared/wikis/components/delete_wiki_modal.vue @@ -1,11 +1,12 @@ diff --git a/app/assets/javascripts/sidebar/components/assignees/assignee_avatar_link.vue b/app/assets/javascripts/sidebar/components/assignees/assignee_avatar_link.vue index 9a60172db2e..878b331fb3c 100644 --- a/app/assets/javascripts/sidebar/components/assignees/assignee_avatar_link.vue +++ b/app/assets/javascripts/sidebar/components/assignees/assignee_avatar_link.vue @@ -59,7 +59,7 @@ export default { }; }, assigneeUrl() { - return this.user.web_url; + return this.user.web_url || this.user.webUrl; }, }, }; diff --git a/app/assets/javascripts/sidebar/components/assignees/issuable_assignees.vue b/app/assets/javascripts/sidebar/components/assignees/issuable_assignees.vue new file mode 100644 index 00000000000..4697d85472b --- /dev/null +++ b/app/assets/javascripts/sidebar/components/assignees/issuable_assignees.vue @@ -0,0 +1,37 @@ + + + diff --git a/app/assets/javascripts/sidebar/components/assignees/uncollapsed_assignee_list.vue b/app/assets/javascripts/sidebar/components/assignees/uncollapsed_assignee_list.vue index fed9e5886c0..95934c0ef2a 100644 --- a/app/assets/javascripts/sidebar/components/assignees/uncollapsed_assignee_list.vue +++ b/app/assets/javascripts/sidebar/components/assignees/uncollapsed_assignee_list.vue @@ -73,9 +73,9 @@ export default { :root-path="rootPath" :issuable-type="issuableType" > -
- {{ user.name }} - {{ username }} +
+
{{ user.name }}
+
{{ username }}
diff --git a/app/assets/javascripts/users_select/index.js b/app/assets/javascripts/users_select/index.js index ad86929ec0a..e73b226772f 100644 --- a/app/assets/javascripts/users_select/index.js +++ b/app/assets/javascripts/users_select/index.js @@ -55,6 +55,7 @@ function UsersSelect(currentUser, els, options = {}) { const defaultLabel = $dropdown.data('defaultLabel'); const issueURL = $dropdown.data('issueUpdate'); const $selectbox = $dropdown.closest('.selectbox'); + const $assignToMeLink = $selectbox.next('.assign-to-me-link'); let $block = $selectbox.closest('.block'); const abilityName = $dropdown.data('abilityName'); let $value = $block.find('.value'); @@ -161,7 +162,7 @@ function UsersSelect(currentUser, els, options = {}) { }); }; - $('.assign-to-me-link').on('click', e => { + $assignToMeLink.on('click', e => { e.preventDefault(); $(e.currentTarget).hide(); @@ -451,9 +452,9 @@ function UsersSelect(currentUser, els, options = {}) { } if (getSelected().find(u => u === gon.current_user_id)) { - $('.assign-to-me-link').hide(); + $assignToMeLink.hide(); } else { - $('.assign-to-me-link').show(); + $assignToMeLink.show(); } } diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue index 3b449f4a76c..3a873a5a17e 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_header.vue @@ -4,7 +4,7 @@ import Mousetrap from 'mousetrap'; import { escape } from 'lodash'; import { GlButton, - GlNewDropdown as GlDropdown, + GlDropdown, GlNewDropdownHeader as GlDropdownHeader, GlNewDropdownItem as GlDropdownItem, GlTooltipDirective, diff --git a/app/assets/javascripts/vue_shared/components/clone_dropdown.vue b/app/assets/javascripts/vue_shared/components/clone_dropdown.vue index 6f5ea8dcbee..e02d55d372d 100644 --- a/app/assets/javascripts/vue_shared/components/clone_dropdown.vue +++ b/app/assets/javascripts/vue_shared/components/clone_dropdown.vue @@ -1,6 +1,6 @@ diff --git a/app/assets/javascripts/vue_shared/components/file_row.vue b/app/assets/javascripts/vue_shared/components/file_row.vue index 004bf882dd6..c1c4f437dee 100644 --- a/app/assets/javascripts/vue_shared/components/file_row.vue +++ b/app/assets/javascripts/vue_shared/components/file_row.vue @@ -14,6 +14,11 @@ export default { type: Object, required: true, }, + fileUrl: { + type: String, + required: false, + default: '', + }, level: { type: Number, required: true, @@ -48,6 +53,9 @@ export default { // don't output a title if we don't have the expanded path return this.file?.tree?.length ? this.file.tree[0].parentPath : false; }, + fileRouterUrl() { + return this.fileUrl || `/project${this.file.url}`; + }, }, watch: { 'file.active': function fileActiveWatch(active) { @@ -74,7 +82,7 @@ export default { this.toggleTreeOpen(this.file.path); } - if (this.$router) this.$router.push(`/project${this.file.url}`); + if (this.$router && !this.hasUrlAtCurrentRoute()) this.$router.push(this.fileRouterUrl); if (this.isBlob) this.clickedFile(this.file.path); }, @@ -104,7 +112,7 @@ export default { hasUrlAtCurrentRoute() { if (!this.$router || !this.$router.currentRoute) return true; - return this.$router.currentRoute.path === `/project${escapeFileUrl(this.file.url)}`; + return this.$router.currentRoute.path === escapeFileUrl(this.fileRouterUrl); }, }, }; diff --git a/app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue b/app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue index dae7c921988..565bab9f8cc 100644 --- a/app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue +++ b/app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue @@ -3,7 +3,7 @@ import { GlFilteredSearch, GlButtonGroup, GlButton, - GlNewDropdown as GlDropdown, + GlDropdown, GlNewDropdownItem as GlDropdownItem, GlTooltipDirective, } from '@gitlab/ui'; diff --git a/app/assets/javascripts/vue_shared/components/resizable_chart/constants.js b/app/assets/javascripts/vue_shared/components/resizable_chart/constants.js index edc5ffb7b77..68d86777995 100644 --- a/app/assets/javascripts/vue_shared/components/resizable_chart/constants.js +++ b/app/assets/javascripts/vue_shared/components/resizable_chart/constants.js @@ -1,6 +1,6 @@ export const DEFAULT_RX = 0.4; -export const DEFAULT_BAR_WIDTH = 6; -export const DEFAULT_LABEL_WIDTH = 4; -export const DEFAULT_LABEL_HEIGHT = 5; +export const DEFAULT_BAR_WIDTH = 4; +export const DEFAULT_LABEL_WIDTH = 3; +export const DEFAULT_LABEL_HEIGHT = 3; export const BAR_HEIGHTS = [5, 7, 9, 14, 21, 35, 50, 80]; export const GRID_YS = [30, 60, 90]; diff --git a/app/assets/javascripts/vue_shared/components/resizable_chart/skeleton_loader.vue b/app/assets/javascripts/vue_shared/components/resizable_chart/skeleton_loader.vue index 306fa61780f..a9f35a73db0 100644 --- a/app/assets/javascripts/vue_shared/components/resizable_chart/skeleton_loader.vue +++ b/app/assets/javascripts/vue_shared/components/resizable_chart/skeleton_loader.vue @@ -61,35 +61,37 @@ export default { }; diff --git a/app/assets/javascripts/vue_shared/components/timezone_dropdown.vue b/app/assets/javascripts/vue_shared/components/timezone_dropdown.vue index 148bd501a8e..135b9842cbf 100644 --- a/app/assets/javascripts/vue_shared/components/timezone_dropdown.vue +++ b/app/assets/javascripts/vue_shared/components/timezone_dropdown.vue @@ -1,12 +1,12 @@