kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Improve test quality

Browse source
This commit is contained in:
Shinya Maeda 2018-11-07 18:56:34 +09:00
parent 66d43c8481
commit 9b807a1091
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
spec/features/projects/environments/environment_spec.rb
View file

@ -25,7 +25,7 @@ describe 'Environment' do
end end
context 'without deployments' do context 'without deployments' do
it 'does show no deployments' do it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.') expect(page).to have_content('You don\'t have any deployments right now.')
end end
end end
@ -64,7 +64,7 @@ describe 'Environment' do
create(:deployment, :running, environment: environment, deployable: build) create(:deployment, :running, environment: environment, deployable: build)
end end
it 'does show no deployments' do it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.') expect(page).to have_content('You don\'t have any deployments right now.')
end end
end end
@ -77,7 +77,7 @@ describe 'Environment' do
create(:deployment, :failed, environment: environment, deployable: build) create(:deployment, :failed, environment: environment, deployable: build)
end end
it 'does show no deployments' do it 'does not show deployments' do
expect(page).to have_content('You don\'t have any deployments right now.') expect(page).to have_content('You don\'t have any deployments right now.')
end end
end end

2
spec/models/environment_status_spec.rb
View file

@ -99,7 +99,7 @@ describe EnvironmentStatus do
let(:user) { project.owner } let(:user) { project.owner }
before do before do
build.deployment&.update(sha: sha) build.deployment&.update!(sha: sha)
end end
context 'when environment is created on a forked project' do context 'when environment is created on a forked project' do