From 9bb25ee18f4baaadafd95ec92cfe39065d349c1d Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Thu, 3 Nov 2016 23:02:19 +0800 Subject: [PATCH] Use stubs instead of modifying global states --- spec/models/project_services/jira_service_spec.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/models/project_services/jira_service_spec.rb b/spec/models/project_services/jira_service_spec.rb index fd9abc09c57..ee0e38bd373 100644 --- a/spec/models/project_services/jira_service_spec.rb +++ b/spec/models/project_services/jira_service_spec.rb @@ -80,7 +80,9 @@ describe JiraService, models: true do stub_config_setting(relative_url_root: '/gitlab') stub_config_setting(url: Settings.send(:build_gitlab_url)) - Project.default_url_options[:script_name] = "/gitlab" + allow(JiraService).to receive(:default_url_options) do + { script_name: '/gitlab' } + end @jira_service.execute(merge_request, ExternalIssue.new("JIRA-123", project))