kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

add comment explaining use of shell commands and file operations in the same methods

This commit is contained in:
Pawel Chojnacki 2017-07-27 15:44:13 +02:00
parent 6ac0a142e0
commit 9be1732296
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/gitlab/health_checks/fs_shards_check.rb
View File

@ -77,6 +77,13 @@ module Gitlab
storages_paths&.dig(storage_name, 'path') storages_paths&.dig(storage_name, 'path')
end end
# All below test methods use shell commands to perform actions on storage volumes.
# In case a storage volume have connectivity problems causing pure Ruby IO operation to wait indefinitely,
# we can rely on shell commands to be terminated once `timeout` kills them.
#
# However we also fallback to pure Ruby file operations in case a specific shell command is missing
# so we are still able to perform healthchecks and gather metrics from such system.
def delete_test_file(tmp_path) def delete_test_file(tmp_path)
_, status = exec_with_timeout(%W{ rm -f #{tmp_path} }) _, status = exec_with_timeout(%W{ rm -f #{tmp_path} })
status.zero? status.zero?