From 9c27c90b4a8a9ea179af9588a7dbd2037829905f Mon Sep 17 00:00:00 2001 From: Robert Speicher Date: Mon, 24 Apr 2017 12:16:33 -0500 Subject: [PATCH] Rename AddColumnWithDefault to ReversibleAddColumnWithDefault We're going to add another cop that deals with another aspect of `add_column_with_default`, so we need to separate them. --- ..._with_default.rb => reversible_add_column_with_default.rb} | 2 +- rubocop/rubocop.rb | 2 +- ...ult_spec.rb => reversible_add_column_with_default_spec.rb} | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) rename rubocop/cop/migration/{add_column_with_default.rb => reversible_add_column_with_default.rb} (93%) rename spec/rubocop/cop/migration/{add_column_with_default_spec.rb => reversible_add_column_with_default_spec.rb} (87%) diff --git a/rubocop/cop/migration/add_column_with_default.rb b/rubocop/cop/migration/reversible_add_column_with_default.rb similarity index 93% rename from rubocop/cop/migration/add_column_with_default.rb rename to rubocop/cop/migration/reversible_add_column_with_default.rb index e04af8fc096..f413f06f39b 100644 --- a/rubocop/cop/migration/add_column_with_default.rb +++ b/rubocop/cop/migration/reversible_add_column_with_default.rb @@ -5,7 +5,7 @@ module RuboCop module Migration # Cop that checks if `add_column_with_default` is used with `up`/`down` methods # and not `change`. - class AddColumnWithDefault < RuboCop::Cop::Cop + class ReversibleAddColumnWithDefault < RuboCop::Cop::Cop include MigrationHelpers def_node_matcher :add_column_with_default?, <<~PATTERN diff --git a/rubocop/rubocop.rb b/rubocop/rubocop.rb index d580aa6857a..cdc0fbfd6a8 100644 --- a/rubocop/rubocop.rb +++ b/rubocop/rubocop.rb @@ -1,9 +1,9 @@ require_relative 'cop/custom_error_class' require_relative 'cop/gem_fetcher' require_relative 'cop/migration/add_column' -require_relative 'cop/migration/add_column_with_default' require_relative 'cop/migration/add_concurrent_foreign_key' require_relative 'cop/migration/add_concurrent_index' require_relative 'cop/migration/add_index' require_relative 'cop/migration/remove_concurrent_index' require_relative 'cop/migration/remove_index' +require_relative 'cop/migration/reversible_add_column_with_default' diff --git a/spec/rubocop/cop/migration/add_column_with_default_spec.rb b/spec/rubocop/cop/migration/reversible_add_column_with_default_spec.rb similarity index 87% rename from spec/rubocop/cop/migration/add_column_with_default_spec.rb rename to spec/rubocop/cop/migration/reversible_add_column_with_default_spec.rb index 6b9b6b19650..3723d635083 100644 --- a/spec/rubocop/cop/migration/add_column_with_default_spec.rb +++ b/spec/rubocop/cop/migration/reversible_add_column_with_default_spec.rb @@ -3,9 +3,9 @@ require 'spec_helper' require 'rubocop' require 'rubocop/rspec/support' -require_relative '../../../../rubocop/cop/migration/add_column_with_default' +require_relative '../../../../rubocop/cop/migration/reversible_add_column_with_default' -describe RuboCop::Cop::Migration::AddColumnWithDefault do +describe RuboCop::Cop::Migration::ReversibleAddColumnWithDefault do include CopHelper subject(:cop) { described_class.new }